From a52b979477ebaa330442fb2d54b2b8591c56fe23 Mon Sep 17 00:00:00 2001
From: Oleg Kalnichevski <olegk@apache.org>
Date: Wed, 11 Feb 2015 08:45:57 +0000
Subject: [PATCH] HTTPCLIENT-1609: Stale connection check in
 PoolingHttpClientConnectionManager has no effect Contributed by Charles Lip
 <rene1 at singnet.com.sg>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1658897 13f79535-47bb-0310-9956-ffa450edef68
---
 RELEASE_NOTES.txt                                        | 9 +++++++++
 .../src/main/java/org/apache/http/impl/conn/CPool.java   | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/RELEASE_NOTES.txt b/RELEASE_NOTES.txt
index 142e1e719..212ec25d3 100644
--- a/RELEASE_NOTES.txt
+++ b/RELEASE_NOTES.txt
@@ -1,3 +1,12 @@
+Changes since 4.4
+-------------------
+
+* [HTTPCLIENT-1609] Stale connection check in PoolingHttpClientConnectionManager has no effect.
+  Internal connection pool does not correctly implement connection validation.
+  Contributed by Charles Lip <rene1 at singnet.com.sg>
+
+
+
 Release 4.4 Final
 -------------------
 
diff --git a/httpclient/src/main/java/org/apache/http/impl/conn/CPool.java b/httpclient/src/main/java/org/apache/http/impl/conn/CPool.java
index a9318e718..00238e9d9 100644
--- a/httpclient/src/main/java/org/apache/http/impl/conn/CPool.java
+++ b/httpclient/src/main/java/org/apache/http/impl/conn/CPool.java
@@ -64,4 +64,9 @@ class CPool extends AbstractConnPool<HttpRoute, ManagedHttpClientConnection, CPo
         return new CPoolEntry(this.log, id, route, conn, this.timeToLive, this.tunit);
     }
 
+    @Override
+    protected boolean validate(final CPoolEntry entry) {
+        return !entry.getConnection().isStale();
+    }
+
 }