Javadoc fixes; add missing @Deprecated markers

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@833249 13f79535-47bb-0310-9956-ffa450edef68

httpclient/src/main/java/org/apache/http/client/protocol/RequestAcceptEncoding.java

@@ -37,7 +37,7 @@ import org.apache.http.protocol.HttpContext;
  * <p>
  * Instances of this class are stateless, therefore they're thread-safe and immutable.
  * 
- * @see http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5
+ * @see "http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5"
  * 
  * @since 4.1
  */

httpclient/src/main/java/org/apache/http/impl/auth/NegotiateScheme.java

@@ -324,7 +324,7 @@ public class NegotiateScheme implements AuthScheme {
     /**
      * Inject the class to be used to generate an SPNEGO token from a Kerberos ticket.
      * Use only with Java <= 1.5 , tested against Jboss Negotiate.
-     * @param spengoGenerator - An SpnegoTokenGenerator implementation Class
+     * @param SpengoGenerator - An SpnegoTokenGenerator implementation Class
      */
     public void setSpengoGenerator(SpnegoTokenGenerator SpengoGenerator) {
         this.spengoGenerator = SpengoGenerator;

httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java

@@ -809,7 +809,8 @@ public class DefaultRequestDirector implements RequestDirector {
                 }
             }
         }
-        
+
+        @SuppressWarnings("null")
         int status = response.getStatusLine().getStatusCode(); // can't be null
 
         if (status > 299) {

httpclient/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java

@@ -90,6 +90,7 @@ public abstract class AbstractPooledConnAdapter extends AbstractClientConnAdapte
     /**
      * @deprecated use {@link #assertValid(AbstractPoolEntry)}
      */
+    @Deprecated
     protected final void assertAttached() {
         if (poolEntry == null) {
             throw new ConnectionShutdownException();

httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ConnPoolByRoute.java

@@ -117,7 +117,7 @@ public class ConnPoolByRoute extends AbstractConnPool {
     /**
      * Creates a new connection pool, managed by route.
      * 
-     * @deprecated use {@link ConnPoolByRoute#ConnPoolByRoute(ClientConnectionOperator, ConnPerRoute)}
+     * @deprecated use {@link ConnPoolByRoute#ConnPoolByRoute(ClientConnectionOperator, ConnPerRoute, int)}
      */
     @Deprecated
     public ConnPoolByRoute(final ClientConnectionOperator operator, final HttpParams params) {

httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java

@@ -84,7 +84,6 @@ public class ThreadSafeClientConnManager implements ClientConnectionManager {
     /**
      * Creates a new thread safe connection manager.
      *
-     * @param params    the parameters for this manager.
      * @param schreg    the scheme registry.
      */
     public ThreadSafeClientConnManager(final SchemeRegistry schreg) {
@@ -138,6 +137,7 @@ public class ThreadSafeClientConnManager implements ClientConnectionManager {
      * 
      * @deprecated use {@link #createConnectionPool(ConnPerRouteBean)}
      */
+    @Deprecated
     protected AbstractConnPool createConnectionPool(final HttpParams params) {
         return new ConnPoolByRoute(connOperator, params);
     }

httpclient/src/test/java/org/apache/http/impl/conn/TestSCMWithServer.java

@@ -63,8 +63,6 @@ public class TestSCMWithServer extends ServerTestBase {
     /**
      * Helper to instantiate a <code>SingleClientConnManager</code>.
      *
-     * @param params    the parameters, or
-     *                  <code>null</code> to use defaults
      * @param schreg    the scheme registry, or
      *                  <code>null</code> to use defaults
      *

httpclient/src/test/java/org/apache/http/impl/conn/TestTSCCMNoServer.java

@@ -88,8 +88,6 @@ public class TestTSCCMNoServer extends TestCase {
     /**
      * Helper to instantiate a <code>ThreadSafeClientConnManager</code>.
      *
-     * @param params    the parameters, or
-     *                  <code>null</code> to use defaults
      * @param schreg    the scheme registry, or
      *                  <code>null</code> to use defaults
      *

httpclient/src/test/java/org/apache/http/impl/conn/TestTSCCMWithServer.java

@@ -89,8 +89,6 @@ public class TestTSCCMWithServer extends ServerTestBase {
     /**
      * Helper to instantiate a <code>ThreadSafeClientConnManager</code>.
      *
-     * @param params    the parameters, or
-     *                  <code>null</code> to use defaults
      * @param schreg    the scheme registry, or
      *                  <code>null</code> to use defaults
      *