Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTPCLIENT-740: start connection GC thread in extra call after construction 

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@618019 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Roland Weber 2008-02-03 17:02:31 +00:00
parent 0f561bdf2b
commit d3353f00e8
2 changed files with 42 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
module-client/src/main/java/org/apache/http/impl/conn/tsccm/AbstractConnPool.java
View File

@ -150,17 +150,44 @@ public abstract class AbstractConnPool implements RefQueueHandler {
boolean fair = false; //@@@ check parameters to decide
poolLock = new ReentrantLock(fair);
boolean conngc = true; //@@@ check parameters to decide
if (conngc) {
refQueue = new ReferenceQueue<Object>();
refWorker = new RefQueueWorker(refQueue, this);
Thread t = new Thread(refWorker); //@@@ use a thread factory
t.setDaemon(true);
t.setName("RefQueueWorker@" + this);
t.start();
connManager = new ConnMgrRef(mgr, null);
}
/**
* Enables connection garbage collection (GC).
* This method must be called immediately after creating the
* connection pool. It is not possible to enable connection GC
* after pool entries have been created. Neither is it possible
* to disable connection GC.
*
* @throws IllegalStateException
* if connection GC is already enabled, or if it cannot be
* enabled because there already are pool entries
*/
public void enableConnectionGC()
throws IllegalStateException {
if (refQueue != null) {
throw new IllegalStateException("Connection GC already enabled.");
}
try {
poolLock.lock();
if (numConnections > 0) { //@@@ is this check sufficient?
throw new IllegalStateException("Pool already in use.");
}
} finally {
poolLock.unlock();
}
connManager = new ConnMgrRef(mgr, refQueue);
refQueue = new ReferenceQueue<Object>();
refWorker = new RefQueueWorker(refQueue, this);
Thread t = new Thread(refWorker); //@@@ use a thread factory
t.setDaemon(true);
t.setName("RefQueueWorker@" + this);
t.start();
connManager = new ConnMgrRef(connManager.get(), refQueue);
}

7
module-client/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java
View File

@ -112,7 +112,12 @@ public class ThreadSafeClientConnManager
*/
protected AbstractConnPool createConnectionPool() {
return new ConnPoolByRoute(this);
AbstractConnPool acp = new ConnPoolByRoute(this);
boolean conngc = true; //@@@ check parameters to decide
if (conngc) {
acp.enableConnectionGC();
}
return acp;
}