Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replaced synchronized HashMap with ConcurrentHashMap 

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@916946 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Oleg Kalnichevski 2010-02-27 12:10:19 +00:00
parent 1628039b85
commit d5d5914de5
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
httpclient/src/main/java/org/apache/http/impl/client/BasicCredentialsProvider.java
View File

@ -26,9 +26,9 @@
package org.apache.http.impl.client; package org.apache.http.impl.client;
import java.util.HashMap; import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import org.apache.http.annotation.GuardedBy;
import org.apache.http.annotation.ThreadSafe; import org.apache.http.annotation.ThreadSafe;
import org.apache.http.auth.AuthScope; import org.apache.http.auth.AuthScope;
@ -43,18 +43,17 @@ import org.apache.http.client.CredentialsProvider;
@ThreadSafe @ThreadSafe
public class BasicCredentialsProvider implements CredentialsProvider { public class BasicCredentialsProvider implements CredentialsProvider {
@GuardedBy("this") private final ConcurrentHashMap<AuthScope, Credentials> credMap;
private final HashMap<AuthScope, Credentials> credMap;
/** /**
* Default constructor. * Default constructor.
*/ */
public BasicCredentialsProvider() { public BasicCredentialsProvider() {
super(); super();
this.credMap = new HashMap<AuthScope, Credentials>(); this.credMap = new ConcurrentHashMap<AuthScope, Credentials>();
} }
public synchronized void setCredentials( public void setCredentials(
final AuthScope authscope, final AuthScope authscope,
final Credentials credentials) { final Credentials credentials) {
if (authscope == null) { if (authscope == null) {
@ -72,7 +71,7 @@ public class BasicCredentialsProvider implements CredentialsProvider {
* *
*/ */
private static Credentials matchCredentials( private static Credentials matchCredentials(
final HashMap<AuthScope, Credentials> map, final Map<AuthScope, Credentials> map,
final AuthScope authscope) { final AuthScope authscope) {
// see if we get a direct hit // see if we get a direct hit
Credentials creds = map.get(authscope); Credentials creds = map.get(authscope);
@ -95,14 +94,14 @@ public class BasicCredentialsProvider implements CredentialsProvider {
return creds; return creds;
} }
public synchronized Credentials getCredentials(final AuthScope authscope) { public Credentials getCredentials(final AuthScope authscope) {
if (authscope == null) { if (authscope == null) {
throw new IllegalArgumentException("Authentication scope may not be null"); throw new IllegalArgumentException("Authentication scope may not be null");
} }
return matchCredentials(this.credMap, authscope); return matchCredentials(this.credMap, authscope);
} }
public synchronized void clear() { public void clear() {
this.credMap.clear(); this.credMap.clear();
} }