Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTPCLIENT-2051: corrected handling of 303 redirects

This commit is contained in:
Oleg Kalnichevski 2020-04-23 17:14:56 +02:00
parent 177fc804e5
commit e26d537658
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncRedirectExec.java
View File

@ -142,11 +142,16 @@ public final class AsyncRedirectExec implements AsyncExecChainHandler {
switch (statusCode) { switch (statusCode) {
case HttpStatus.SC_MOVED_PERMANENTLY: case HttpStatus.SC_MOVED_PERMANENTLY:
case HttpStatus.SC_MOVED_TEMPORARILY: case HttpStatus.SC_MOVED_TEMPORARILY:
case HttpStatus.SC_SEE_OTHER:
if (Method.POST.isSame(request.getMethod())) { if (Method.POST.isSame(request.getMethod())) {
state.currentRequest = new BasicHttpRequest(Method.GET, redirectUri); state.currentRequest = new BasicHttpRequest(Method.GET, redirectUri);
state.currentEntityProducer = null; state.currentEntityProducer = null;
} }
break;
case HttpStatus.SC_SEE_OTHER:
if (!Method.GET.isSame(request.getMethod()) && !Method.HEAD.isSame(request.getMethod())) {
state.currentRequest = new BasicHttpRequest(Method.GET, redirectUri);
state.currentEntityProducer = null;
}
} }
if (state.currentRequest == null) { if (state.currentRequest == null) {
state.currentRequest = new BasicHttpRequest(request.getMethod(), redirectUri); state.currentRequest = new BasicHttpRequest(request.getMethod(), redirectUri);

6
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/RedirectExec.java
View File

@ -145,10 +145,14 @@ public final class RedirectExec implements ExecChainHandler {
switch (statusCode) { switch (statusCode) {
case HttpStatus.SC_MOVED_PERMANENTLY: case HttpStatus.SC_MOVED_PERMANENTLY:
case HttpStatus.SC_MOVED_TEMPORARILY: case HttpStatus.SC_MOVED_TEMPORARILY:
case HttpStatus.SC_SEE_OTHER:
if (Method.POST.isSame(request.getMethod())) { if (Method.POST.isSame(request.getMethod())) {
redirect = new HttpGet(redirectUri); redirect = new HttpGet(redirectUri);
} }
break;
case HttpStatus.SC_SEE_OTHER:
if (!Method.GET.isSame(request.getMethod()) && !Method.HEAD.isSame(request.getMethod())) {
redirect = new HttpGet(redirectUri);
}
} }
if (redirect == null) { if (redirect == null) {
redirect = new BasicClassicHttpRequest(originalRequest.getMethod(), redirectUri); redirect = new BasicClassicHttpRequest(originalRequest.getMethod(), redirectUri);