Apache
/
httpcomponents-client
mirror of https://github.com/apache/httpcomponents-client.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Some well known proxies respond with Content-Length=0, when returning 304. For robustness, always use the cached entity's content length, as modern browsers do.

This commit is contained in:
Raymond, Jayson 2019-02-06 07:21:09 -08:00
parent 1f06087fad
commit e6ca403d29
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachedHttpResponseGenerator.java vendored
View File

@ -145,11 +145,10 @@ class CachedHttpResponseGenerator {
if (transferEncodingIsPresent(response)) { if (transferEncodingIsPresent(response)) {
return; return;
} }
final Header contentLength = response.getFirstHeader(HttpHeaders.CONTENT_LENGTH); // Some well known proxies respond with Content-Length=0, when returning 304. For robustness, always
if (contentLength == null) { // use the cached entity's content length, as modern browsers do.
response.setHeader(HttpHeaders.CONTENT_LENGTH, Integer.toString(body.length)); response.setHeader(HttpHeaders.CONTENT_LENGTH, Integer.toString(body.length));
} }
}
private boolean transferEncodingIsPresent(final HttpResponse response) { private boolean transferEncodingIsPresent(final HttpResponse response) {
final Header hdr = response.getFirstHeader(HttpHeaders.TRANSFER_ENCODING); final Header hdr = response.getFirstHeader(HttpHeaders.TRANSFER_ENCODING);