Apache/httpcomponents-client
1
0
Fork 0
mirror of https://github.com/apache/httpcomponents-client.git synced 2025-02-16 23:16:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better method name (no functional changes)

Browse Source
This commit is contained in:
Oleg Kalnichevski 2018-01-07 13:59:28 +01:00
parent 7cf4240b3f
commit f16ac3ec3b
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicHttpAsyncCache.java vendored
View File

@ -197,7 +197,7 @@ Cancellable storeVariantEntry(
final HttpCacheEntry entry, final HttpCacheEntry entry,
final FutureCallback<Boolean> callback) { final FutureCallback<Boolean> callback) {
final String variantKey = cacheKeyGenerator.generateVariantKey(req, entry); final String variantKey = cacheKeyGenerator.generateVariantKey(req, entry);
final String variantCacheKey = cacheKeyGenerator.generateVariantURI(host, req, entry); final String variantCacheKey = cacheKeyGenerator.generateKey(host, req, entry);
return storage.putEntry(variantCacheKey, entry, new FutureCallback<Boolean>() { return storage.putEntry(variantCacheKey, entry, new FutureCallback<Boolean>() {
@Override @Override

2
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/BasicHttpCache.java vendored
View File

@ -151,7 +151,7 @@ void storeVariantEntry(
final HttpRequest req, final HttpRequest req,
final HttpCacheEntry entry) { final HttpCacheEntry entry) {
final String variantKey = cacheKeyGenerator.generateVariantKey(req, entry); final String variantKey = cacheKeyGenerator.generateVariantKey(req, entry);
final String variantCacheKey = cacheKeyGenerator.generateVariantURI(host, req, entry); final String variantCacheKey = cacheKeyGenerator.generateKey(host, req, entry);
storeEntry(variantCacheKey, entry); storeEntry(variantCacheKey, entry);
try { try {
storage.updateEntry(cacheKey, new HttpCacheCASOperation() { storage.updateEntry(cacheKey, new HttpCacheCASOperation() {

2
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheKeyGenerator.java vendored
View File

@ -119,7 +119,7 @@ private String getFullHeaderValue(final Header[] headers) {
* @param entry the parent entry used to track the variants * @param entry the parent entry used to track the variants
* @return cache key * @return cache key
*/ */
public String generateVariantURI(final HttpHost host, final HttpRequest request, final HttpCacheEntry entry) { public String generateKey(final HttpHost host, final HttpRequest request, final HttpCacheEntry entry) {
if (!entry.hasVariants()) { if (!entry.hasVariants()) {
return generateKey(host, request); return generateKey(host, request);
} }

2
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/DefaultAsyncCacheRevalidator.java vendored
View File

@ -146,7 +146,7 @@ public void revalidateCacheEntry(
final AsyncExecChain chain, final AsyncExecChain chain,
final AsyncExecCallback asyncExecCallback, final AsyncExecCallback asyncExecCallback,
final HttpCacheEntry entry) { final HttpCacheEntry entry) {
final String cacheKey = cacheKeyGenerator.generateVariantURI(target, request, entry); final String cacheKey = cacheKeyGenerator.generateKey(target, request, entry);
scheduleRevalidation(cacheKey, new Runnable() { scheduleRevalidation(cacheKey, new Runnable() {
@Override @Override

2
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/DefaultCacheRevalidator.java vendored
View File

@ -81,7 +81,7 @@ public void revalidateCacheEntry(
final ExecChain.Scope scope, final ExecChain.Scope scope,
final ExecChain chain, final ExecChain chain,
final HttpCacheEntry entry) { final HttpCacheEntry entry) {
final String cacheKey = cacheKeyGenerator.generateVariantURI(target, request, entry); final String cacheKey = cacheKeyGenerator.generateKey(target, request, entry);
scheduleRevalidation(cacheKey, new Runnable() { scheduleRevalidation(cacheKey, new Runnable() {
@Override @Override

12
httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestCacheKeyGenerator.java vendored
View File

@ -127,7 +127,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
} }
}; };
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
Assert.assertSame(theURI, result); Assert.assertSame(theURI, result);
} }
@ -150,7 +150,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
when(mockEntry.headerIterator("Vary")).thenReturn(new BasicHeaderIterator(varyHeaders, "Vary")); when(mockEntry.headerIterator("Vary")).thenReturn(new BasicHeaderIterator(varyHeaders, "Vary"));
when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders); when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders);
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
verify(mockEntry).headerIterator("Vary"); verify(mockEntry).headerIterator("Vary");
@ -176,7 +176,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
when(mockRequest.getHeaders("Accept-Encoding")) when(mockRequest.getHeaders("Accept-Encoding"))
.thenReturn(noHeaders); .thenReturn(noHeaders);
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
verify(mockEntry).headerIterator("Vary"); verify(mockEntry).headerIterator("Vary");
@ -203,7 +203,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders); when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders);
when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders); when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders);
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
verify(mockEntry).headerIterator("Vary"); verify(mockEntry).headerIterator("Vary");
@ -232,7 +232,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders); when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders);
when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders); when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders);
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
verify(mockEntry).headerIterator("Vary"); verify(mockEntry).headerIterator("Vary");
@ -261,7 +261,7 @@ public String generateKey(final HttpHost h, final HttpRequest request) {
when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders); when(mockRequest.getHeaders("Accept-Encoding")).thenReturn(encHeaders);
when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders); when(mockRequest.getHeaders("User-Agent")).thenReturn(uaHeaders);
final String result = extractor.generateVariantURI(defaultHost, mockRequest, mockEntry); final String result = extractor.generateKey(defaultHost, mockRequest, mockEntry);
verify(mockEntry).hasVariants(); verify(mockEntry).hasVariants();
verify(mockEntry).headerIterator("Vary"); verify(mockEntry).headerIterator("Vary");