Commit Graph

24 Commits

Author SHA1 Message Date
Arturo Bernal fde3fca687 Simplify conditions and avoid extra checks.
Inline return variables.
2021-06-19 16:47:41 +02:00
Gary Gregory 75f9adea87 Remove redundant returns. 2020-11-24 09:22:25 -05:00
Carter Kozak 9866865357 HTTPCLIENT-2096: Migrate instance loggers to static fields
Note that this may change the origin of logging when classes
have been subclassed, as the logger origin will use the class
name that defined the logger where previously the subclass type
would be used. In scenarios where external libraries subclass
httpclient utilities this allows httpclient logging to maintain
the `org.apache.hc` prefix instead of inheriting arbitrary
subclass names.

Using some logging frameworks this may result in reduced churn
when httpclient components are created (new connections, for example)
because loggers are looked up once per class.
2020-07-09 11:34:48 +02:00
Carter Kozak 84bd290954
HTTPCLIENT-2095: Use slf4j interpolation instead of string concatenation where possible (#232) 2020-07-02 17:51:43 +02:00
Oleg Kalnichevski a93d5c0c1d HTTPCLIENT-2073: (regression) WindowsNegotiateScheme incorrectly rejects empty NTLM challenge 2020-04-05 13:22:13 +02:00
Michael Osipov 3730b03a99 Properly distinguish between AuthScheme and auth scheme name
Throughout the code the terms 'authScheme' and 'scheme' have been used
synonymously for an AuthScheme instance and a string-based auth scheme
name. To avoid confusion, fields, methods and variable have been adapted
to distinguish both properly. If necessary, Javadoc has been modified to
denote the nature of the input.

Also an auth scheme name is retained as-is, but normalized to lowercase
if comparsion is required.

This closes #193
2020-01-01 22:51:19 +01:00
Gary Gregory 634886ab61 [HTTPCLIENT-2046] Rename AuthSchemes enum to StandardAuthScheme final class
Modeled after StandardCharsets, the new class indicates a non-exhaustive
list of standard auth schemes by name supported by the HttpClient. The
previous enum suffered from two issues:

* it was exhaustive implying that no more auth schemes can be supported
* its sole purpose was to contain an id for the declared auth scheme;
  the enum values theirselves were never used directly

This closes #196
2020-01-01 21:57:53 +01:00
Gary Gregory 3fd383f870 [HTTPCLIENT-2044] Don't create stateless/immutable factory objects
Decide later if some of these classes should have a private default
constructor.

This closes #195
2019-12-31 20:43:56 +01:00
Gary Gregory eaa8c5f648
[HTTPCLIENT-2043] Rename classes documented as factories from *Provider to *Factory (#194)
This closes #194
2019-12-31 11:27:16 -05:00
Michael Osipov 2744c73471 Apply consistent id field names
As with HttpCore an entity should have a consistent id field, named 'id'
throughout the entire codebase.

This closes #188
2019-12-26 15:32:22 +01:00
Gary Gregory 369592d333 [HTTPCLIENT-1947] Update JNA from 4.5.2 to 5.0.0. 2018-10-22 13:08:58 -06:00
Oleg Kalnichevski 37c8006472 Javadocs; renamed some methods (no functional changes) 2018-10-17 23:40:12 +02:00
Oleg Kalnichevski ac90342039 Use enums for supported cookie policies and auth schemes 2018-10-14 20:05:17 +02:00
Oleg Kalnichevski eb71f45ee5 SLF4J logging facade 2018-01-10 13:07:37 +01:00
Oleg Kalnichevski 09aee8c422 Removed #finalize() methods deprecated in Java 9 2017-10-22 14:33:01 +02:00
Oleg Kalnichevski 6d17126cbf Moved classes and renamed packages (no functional changes) 2017-09-02 17:27:30 +02:00
Oleg Kalnichevski da5797f470 Moved classic HttpClient and HC fluent integration tests to httpclient-testing module
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1793319 13f79535-47bb-0310-9956-ffa450edef68
2017-05-01 12:38:41 +00:00
Oleg Kalnichevski e6844f5d33 Fix for HTTPCLIENT-1833
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1787549 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 12:07:13 +00:00
Oleg Kalnichevski 191183bf75 Moved sync HTTP method classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1784141 13f79535-47bb-0310-9956-ffa450edef68
2017-02-23 14:35:01 +00:00
Oleg Kalnichevski 1da6fc21ed Moved connection pool construction logic out of HttpClientBuilder into a separate builder class
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1777768 13f79535-47bb-0310-9956-ffa450edef68
2017-01-07 11:38:46 +00:00
Oleg Kalnichevski e48091da3d Upgraded HttpCore to version 5.0-alpha2; Upgraded to the latest 5.0 APIs
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1776187 13f79535-47bb-0310-9956-ffa450edef68
2016-12-27 19:48:07 +00:00
Gary D. Gregory fd412e7bf1 [HTTPCLIENT-1786] Port from Apache Commons Logging to Apache Log4j 2.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1767391 13f79535-47bb-0310-9956-ffa450edef68
2016-10-31 23:24:37 +00:00
Gary D. Gregory a287ab6387 Add final modifier to local variables.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726969 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 09:02:41 +00:00
Gary D. Gregory 3c58addf11 SVN move folders from httpclient* to httpclient5* in order to match the Maven artifact ID, which matters for multi-module builds.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726719 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 00:22:23 +00:00