Commit Graph

509 Commits

Author SHA1 Message Date
Sebastian Bazley 413c41202b HTTPCLIENT-1195 - URIBuilder-created query strings are double-escaped
Add [ ] to reserved chars
Use separate safe sets for userinfo and fragment

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1354288 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 23:23:21 +00:00
Sebastian Bazley caade0db95 Add test to check that builder behaves the same as URI
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1354115 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 17:17:05 +00:00
Sebastian Bazley 518e6da29d Change form encoded escaping to agree with previous release and browsers
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1354111 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 17:05:00 +00:00
Sebastian Bazley f32198b1fb Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1354053 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 15:10:16 +00:00
Sebastian Bazley 54f6fbf596 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1354046 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 14:57:30 +00:00
Sebastian Bazley 4efc8af634 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353782 13f79535-47bb-0310-9956-ffa450edef68
2012-06-26 00:25:44 +00:00
Sebastian Bazley 70a217c4d6 Add tests for charset String version of parse
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353699 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 18:58:17 +00:00
Sebastian Bazley 8a45b8bc44 Rename private methods to make their function clearer
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353698 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 18:57:26 +00:00
Sebastian Bazley 35d3f7ec77 Simplify nested if
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353697 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 18:33:21 +00:00
Oleg Kalnichevski 158ca6f4a0 HTTPCLIENT-1195: minor optimization
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353678 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 17:35:34 +00:00
Sebastian Bazley 3d3457f458 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353642 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 16:31:24 +00:00
Oleg Kalnichevski faef016a2c HTTPCLIENT-1201: Quick start doc improvements
Contributed by miles zarathustra <albert.bradley at thomsonreuters.com>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353605 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 15:43:28 +00:00
Oleg Kalnichevski 2e9220e97b HTTPCLIENT-1195: blanks in the query part of request URIs to be encoded as '+'
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353593 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 15:28:41 +00:00
Sebastian Bazley 9dcf1ebd67 HTTPCLIENT-1195 - URIBuilder-created query strings are double-escaped
Move normalization from URIUtils to URIBuilder so encodedPath is not dropped
Oops - don't do double normalisation

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353446 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 09:56:22 +00:00
Sebastian Bazley 77ba1e5e0d HTTPCLIENT-1195 - URIBuilder-created query strings are double-escaped
Move normalization from URIUtils to URIBuilder so encodedPath is not dropped

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353445 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 09:53:07 +00:00
Sebastian Bazley b4d78c4d69 Unused import
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353369 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 00:59:31 +00:00
Sebastian Bazley 0bef1af005 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353368 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 00:58:19 +00:00
Sebastian Bazley 9fe5039310 Add String version of format test
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353366 13f79535-47bb-0310-9956-ffa450edef68
2012-06-25 00:07:56 +00:00
Sebastian Bazley 94f76c998f Eclipse says: contentType cannot be null here
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353365 13f79535-47bb-0310-9956-ffa450edef68
2012-06-24 23:56:29 +00:00
Sebastian Bazley 21471f8486 Add tests for port and scheme copy
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353363 13f79535-47bb-0310-9956-ffa450edef68
2012-06-24 23:48:49 +00:00
Sebastian Bazley 09527b3f74 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353361 13f79535-47bb-0310-9956-ffa450edef68
2012-06-24 23:31:19 +00:00
Sebastian Bazley 1505d6dca6 Fix up query test cases so they are actually queries
Add extra encoded & to path tests

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353266 13f79535-47bb-0310-9956-ffa450edef68
2012-06-24 13:58:11 +00:00
Sebastian Bazley 9db01c3144 HTTPCLIENT-1195 - URIBuilder-created query strings are double-escaped
Ensure escapedQuery is not unescaped - fixes failed test testEscapedSpaceInQueryAbsolute

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353253 13f79535-47bb-0310-9956-ffa450edef68
2012-06-24 12:26:45 +00:00
Sebastian Bazley 3e1493d94c Restore from TestUriEscapes.java@1349668
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353122 13f79535-47bb-0310-9956-ffa450edef68
2012-06-23 12:43:31 +00:00
Oleg Kalnichevski 1863df4df9 HTTPCLIENT-1210: HttpRequestBase#toString() method
Contributed by Gary D. Gregory <garydgregory at gmail.com>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1353104 13f79535-47bb-0310-9956-ffa450edef68
2012-06-23 09:53:11 +00:00
Oleg Kalnichevski da16fdc973 HTTPCLIENT-1209: Redirect URIs are now normalized
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1352845 13f79535-47bb-0310-9956-ffa450edef68
2012-06-22 11:05:10 +00:00
Oleg Kalnichevski ddde53711c Remove user info from request URI when rewriting
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1351478 13f79535-47bb-0310-9956-ffa450edef68
2012-06-18 20:27:59 +00:00
Oleg Kalnichevski 2e3efc7d27 HTTPCLIENT-1195: URI rewrite methods in URIUtils now use URIBuilder internally
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1349669 13f79535-47bb-0310-9956-ffa450edef68
2012-06-13 07:56:35 +00:00
Oleg Kalnichevski 637f046eb1 HTTPCLIENT-1195: URIBuilder now uses single argument URI constructor to create URI instance
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1349530 13f79535-47bb-0310-9956-ffa450edef68
2012-06-12 21:11:47 +00:00
Oleg Kalnichevski e8bc96c549 Request URI does not always get updated
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1347596 13f79535-47bb-0310-9956-ffa450edef68
2012-06-07 12:59:37 +00:00
Jonathan Moore 2451e5dec7 HTTPCLIENT-1199: Added unit test to verify Oleg's recent fix.
We still do not properly handle the redirect case, however.


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1345217 13f79535-47bb-0310-9956-ffa450edef68
2012-06-01 14:53:17 +00:00
Oleg Kalnichevski f785d0ed7a HTTPCLIENT-1199: fixed request wrapping in DecompressingHttpClient
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1345166 13f79535-47bb-0310-9956-ffa450edef68
2012-06-01 13:26:53 +00:00
Jonathan Moore 2514a05895 Compiler warning cleanup: unused imports and unneeded @SuppressWarnings.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1344851 13f79535-47bb-0310-9956-ffa450edef68
2012-05-31 18:25:49 +00:00
Oleg Kalnichevski a64a3e252e HTTPCLIENT-1200: DecompressingHttpClient fails to generate correct HttpHost context attribute
Contributed by Guillaume Castagnino <casta+jira at xwing.info>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1344743 13f79535-47bb-0310-9956-ffa450edef68
2012-05-31 14:28:38 +00:00
Oleg Kalnichevski 5300548a56 HTTPCLIENT-1192: URIBuilder encodes query parameters twice
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1343355 13f79535-47bb-0310-9956-ffa450edef68
2012-05-28 18:29:50 +00:00
Oleg Kalnichevski 0da3e7251e HTTPCLIENT-1193: Fixed regression in the route tracking logic of the default connection manager causing cross-site redirect failures.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1342677 13f79535-47bb-0310-9956-ffa450edef68
2012-05-25 15:13:43 +00:00
Oleg Kalnichevski 570aa9fa37 Upgraded project version to 4.2.1-SNAPSHOT
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1340700 13f79535-47bb-0310-9956-ffa450edef68
2012-05-20 12:51:21 +00:00
Oleg Kalnichevski 91250b2a89 Reverted change to the public const value
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1339141 13f79535-47bb-0310-9956-ffa450edef68
2012-05-16 12:41:45 +00:00
Oleg Kalnichevski ae4ebcc630 Added missing AL header
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1339140 13f79535-47bb-0310-9956-ffa450edef68
2012-05-16 12:41:02 +00:00
Oleg Kalnichevski 2e2f6c2e04 HTTPCLIENT-1191: PATCH HTTP method
Contributed by Alin Vasile <alinachegalati at yahoo dot com>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1339134 13f79535-47bb-0310-9956-ffa450edef68
2012-05-16 12:21:24 +00:00
Oleg Kalnichevski c850967c01 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1337904 13f79535-47bb-0310-9956-ffa450edef68
2012-05-13 14:57:27 +00:00
Oleg Kalnichevski 561a7d7405 Reverted to using basic connection manager per default
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1337903 13f79535-47bb-0310-9956-ffa450edef68
2012-05-13 14:57:07 +00:00
Oleg Kalnichevski 7a207ae475 Removed code deprecated in release 4.0
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1337893 13f79535-47bb-0310-9956-ffa450edef68
2012-05-13 14:11:39 +00:00
Oleg Kalnichevski a8d2e5e5fa Added release version to deprecation annotations; removed references to deprecated methods / classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1335088 13f79535-47bb-0310-9956-ffa450edef68
2012-05-07 16:06:11 +00:00
Oleg Kalnichevski aa412a29b9 Deprecated DefaultResponseParser in favor of DefaultHttpResponseParser
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1334646 13f79535-47bb-0310-9956-ffa450edef68
2012-05-06 14:41:38 +00:00
Oleg Kalnichevski bfe3b7201f Added getters to URIBuilder
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1334634 13f79535-47bb-0310-9956-ffa450edef68
2012-05-06 14:17:01 +00:00
Oleg Kalnichevski 6920b38823 UrlEncodedFormEntity constructors added in 4.2 no longer throw UnsupportedEncodingException
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1334630 13f79535-47bb-0310-9956-ffa450edef68
2012-05-06 13:58:20 +00:00
Oleg Kalnichevski 93296a4779 Upgraded to HttpCore 4.2; Fixed compile errors caused by API breakage (HTTPCLIENT-1189)
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1334436 13f79535-47bb-0310-9956-ffa450edef68
2012-05-05 15:53:45 +00:00
Oleg Kalnichevski 63d06f06cd HTTPCLIENT-1186: State of newly created connections in the connection pool is not always correctly updated potentially allowing those connections to be leased to users with a different security context
Contributed by Ralf Pöhlmann <rpn at methodpark.de>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1329811 13f79535-47bb-0310-9956-ffa450edef68
2012-04-24 15:55:07 +00:00
Oleg Kalnichevski 9366926296 Renamed CompressionDecorator to DecompressingHttpClient
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1311967 13f79535-47bb-0310-9956-ffa450edef68
2012-04-10 20:19:20 +00:00