Commit Graph

592 Commits

Author SHA1 Message Date
Gary D. Gregory fcbfd1d914 Tab police and use // @formatter:[off|on]
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1783963 13f79535-47bb-0310-9956-ffa450edef68
2017-02-22 01:29:28 +00:00
Gary D. Gregory f77bdff541 Tab police.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1783844 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 08:45:54 +00:00
Gary D. Gregory a9df4780c1 Use try-with-resources to try and avoid any leaks.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1783811 13f79535-47bb-0310-9956-ffa450edef68
2017-02-20 22:56:52 +00:00
Gary D. Gregory 97f1e35a00 [HTTPCLIENT-1817] Add a "Trust All" TrustStrategy implementation.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1783809 13f79535-47bb-0310-9956-ffa450edef68
2017-02-20 22:50:39 +00:00
Oleg Kalnichevski 4d0d23dc01 Integration and compatibility tests
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1780849 13f79535-47bb-0310-9956-ffa450edef68
2017-01-29 19:22:20 +00:00
Oleg Kalnichevski cea5b2697b HTTPCLIENT-1802: Do not attempt to match SSL host to subject CN if subject alternative name of any type are given
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1779669 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 19:21:10 +00:00
Oleg Kalnichevski 4d180773db HTTPCLIENT-1788: RFC 6265 policy must not reject cookies with paths that are no prefix of the uri path
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1778460 13f79535-47bb-0310-9956-ffa450edef68
2017-01-12 19:21:03 +00:00
Oleg Kalnichevski 09bee18bd6 Use extended HostnameVerifier interface that propagates detailed exception in case of hostname verification failure when available
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1778412 13f79535-47bb-0310-9956-ffa450edef68
2017-01-12 10:09:04 +00:00
Oleg Kalnichevski 903c701ef6 HTTPCLIENT-1792: SSLConnectionSocketFactory to throw SSLPeerUnverifiedException with a better error message when hostname verification fails
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1778411 13f79535-47bb-0310-9956-ffa450edef68
2017-01-12 10:08:41 +00:00
Oleg Kalnichevski aaf638b1d5 HTTPCLIENT-1800: wrap redirect around retry in execChain
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1777769 13f79535-47bb-0310-9956-ffa450edef68
2017-01-07 11:39:15 +00:00
Oleg Kalnichevski 1da6fc21ed Moved connection pool construction logic out of HttpClientBuilder into a separate builder class
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1777768 13f79535-47bb-0310-9956-ffa450edef68
2017-01-07 11:38:46 +00:00
Oleg Kalnichevski e48091da3d Upgraded HttpCore to version 5.0-alpha2; Upgraded to the latest 5.0 APIs
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1776187 13f79535-47bb-0310-9956-ffa450edef68
2016-12-27 19:48:07 +00:00
Gary D. Gregory afb3908d2e Allow for checkstyle oddity.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1767398 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 01:21:33 +00:00
Gary D. Gregory fd412e7bf1 [HTTPCLIENT-1786] Port from Apache Commons Logging to Apache Log4j 2.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1767391 13f79535-47bb-0310-9956-ffa450edef68
2016-10-31 23:24:37 +00:00
Oleg Kalnichevski 28a6d5c481 HTTPCLIENT-1767: Null pointer dereference in EofSensorInputStream and ResponseEntityProxy
EofSensorInputStream is generating NullPointerExceptions in some rare situations. This commit fixes that behaviour for the check methods by dereferencing the instance variable to a final local variable to ensure that if it is not null at the null guard, that it will be not null after that point also to successfully close/abort the stream

In some rare cases, null parameters are sent to ReponseEntityProxy methods, this adds checks on those to ensure that the connections are still released, but the null variable is not dereferenced.

Contributed by Peter Ansell <p_ansell@yahoo.com>

Conflicts:
	httpclient5/src/main/java/org/apache/hc/client5/http/impl/sync/ResponseEntityProxy.java

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1760585 13f79535-47bb-0310-9956-ffa450edef68
2016-09-13 18:32:38 +00:00
Oleg Kalnichevski f779a4b65d Support changing system default ProxySelector
Contributed by Robin Stevens <stevensro at gmail.com>

The `ProxySelectorRoutePlanner` class which got deprecated in favor of the `SystemDefaultRoutePlanner` could deal with:
- `null` as default `ProxySelector`
- a change in the default `ProxySelector`

This change ports that behavior to the `SystemDefaultRoutePlanner`.

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1758106 13f79535-47bb-0310-9956-ffa450edef68
2016-08-28 13:02:35 +00:00
Gary D. Gregory 1aff9e9220 Use final.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1757447 13f79535-47bb-0310-9956-ffa450edef68
2016-08-23 22:27:14 +00:00
Oleg Kalnichevski 4046b8fdcc HTTPCLIENT-1748: Improved compatibility with system authentication API in applets
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1756293 13f79535-47bb-0310-9956-ffa450edef68
2016-08-13 19:55:43 +00:00
Oleg Kalnichevski 1b9c13afa9 HTTPCLIENT-1760: added protected methods to enumerate leased and available connections to PoolingHttpClientConnectionManager
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1756278 13f79535-47bb-0310-9956-ffa450edef68
2016-08-13 15:30:27 +00:00
Oleg Kalnichevski 8081dbdc02 HTTPCLIENT-1746: improved argument validation in URLEncodedUtils
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1746751 13f79535-47bb-0310-9956-ffa450edef68
2016-06-03 19:37:33 +00:00
Oleg Kalnichevski da589ff03a HTTPCLIENT-1736: do not request cred delegation by default when using Kerberos auth
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1746746 13f79535-47bb-0310-9956-ffa450edef68
2016-06-03 19:19:39 +00:00
Oleg Kalnichevski da8e60b2a4 Cleaned up comments
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1745907 13f79535-47bb-0310-9956-ffa450edef68
2016-05-28 17:00:08 +00:00
Oleg Kalnichevski facf463c44 HTTPCLIENT-1744: normalize hostname and certificate CN when matching to CN
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1745906 13f79535-47bb-0310-9956-ffa450edef68
2016-05-28 16:59:23 +00:00
Oleg Kalnichevski e6c051ee1b HTTPCLIENT-1732: SystemDefaultCredentialsProvider to take http.proxyHost and http.proxyPort system properties into account
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1737484 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 10:26:11 +00:00
Oleg Kalnichevski 66c5016394 HTTPCLIENT-1730: added #setValidateAfterInactivity to HttpClientBuilder
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1736237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 19:28:09 +00:00
Oleg Kalnichevski 055030c9f2 HTTPCLIENT-1730: javadoc improvements
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1736193 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 14:06:47 +00:00
Gary D. Gregory 52c68d6a4f Comment empty blocks.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1733182 13f79535-47bb-0310-9956-ffa450edef68
2016-03-01 22:53:05 +00:00
Gary D. Gregory cd4fc8f885 Statement unnecessarily nested within else clause.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1728604 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 04:59:28 +00:00
Oleg Kalnichevski 3df5c3d6a5 HTTPCLIENT-1716: redirect handling of unsafe methods defined by RFC 7231
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1727394 13f79535-47bb-0310-9956-ffa450edef68
2016-01-28 16:16:48 +00:00
Gary D. Gregory a287ab6387 Add final modifier to local variables.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726969 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 09:02:41 +00:00
Gary D. Gregory 1d43ae8238 [HTTPCLIENT-1715] NTLMEngineImpl.Type1Message not thread safe but declared as a constant.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726956 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 08:30:35 +00:00
Gary D. Gregory 6ba70b435c Use Java 7's try-with-resources.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726955 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 08:27:37 +00:00
Gary D. Gregory 69b509a06d Statement unnecessarily nested within else clause.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726954 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 08:25:11 +00:00
Gary D. Gregory 5868ceed56 Statement unnecessarily nested within else clause.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726953 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 08:24:45 +00:00
Gary D. Gregory 8c840c918b Statement unnecessarily nested within else clause.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726950 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 08:14:03 +00:00
Gary D. Gregory 40140009a1 Statement unnecessarily nested within else clause.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726949 13f79535-47bb-0310-9956-ffa450edef68
2016-01-27 07:59:48 +00:00
Gary D. Gregory 5929a47ff8 Add missing serial version ID (default 1L).
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726896 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 20:42:59 +00:00
Gary D. Gregory 2ed551ff45 Make some ivars final.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726895 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 20:39:50 +00:00
Gary D. Gregory 9268258fc7 Make some ivars final.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726894 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 20:39:09 +00:00
Gary D. Gregory 75bdb83e1a Make some ivars final.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726893 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 20:38:09 +00:00
Gary D. Gregory 1ecdb608e5 [HTTPCLIENT-1714] Add HttpClientBuilder.setDnsResolver(DnsResolver).
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726732 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 05:23:30 +00:00
Gary D. Gregory 3c58addf11 SVN move folders from httpclient* to httpclient5* in order to match the Maven artifact ID, which matters for multi-module builds.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1726719 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 00:22:23 +00:00