Commit Graph

54 Commits

Author SHA1 Message Date
Oleg Kalnichevski cd4de57a55 Made class thread-safe; cleaned up javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@767657 13f79535-47bb-0310-9956-ffa450edef68
2009-04-22 21:03:47 +00:00
Oleg Kalnichevski 4f51cdcf24 Javadoc updates and code cleanups
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@766758 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 17:15:05 +00:00
Oleg Kalnichevski af182ce5e9 Javadoc cleanups
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@766180 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 23:39:31 +00:00
Oleg Kalnichevski b44aee815b Javadoc and code cleanups
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765710 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 18:12:30 +00:00
Sebastian Bazley 0b44b69b29 Grammar police
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765677 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 16:17:24 +00:00
Sebastian Bazley 62a4114ace Make unchanging fields final
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765676 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 16:16:54 +00:00
Sebastian Bazley 5c462fc22f Make unchanging fields final
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765675 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 16:15:51 +00:00
Sebastian Bazley 30d394e769 Ensure final String array cannot be changed accidentally or maliciously
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765644 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 14:11:51 +00:00
Sebastian Bazley cc297408f9 Document update
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765642 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 14:09:18 +00:00
Sebastian Bazley 834c667310 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765595 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 12:22:20 +00:00
Sebastian Bazley 78a0d3346d Requires boolean, not Boolean
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765591 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 12:17:11 +00:00
Oleg Kalnichevski 0b5dd9c3a5 Fixed problem with the default HTTP response parser failing to handle garbage preceding a valid HTTP response
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@765294 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 18:19:53 +00:00
Oleg Kalnichevski ccfc5de212 Fixed bug causing empty input lines to be omitted from the wire log
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@764915 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 18:27:04 +00:00
Oleg Kalnichevski c1a13dea57 Set session buffer size to 8192, if not set explicitly
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@764911 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 18:19:52 +00:00
Oleg Kalnichevski a23c18ac1e Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@764588 13f79535-47bb-0310-9956-ffa450edef68
2009-04-13 19:53:25 +00:00
Oleg Kalnichevski c74443f68b Explicitly set default TcpNoDelay and socket buffer parameter values
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@764586 13f79535-47bb-0310-9956-ffa450edef68
2009-04-13 19:52:18 +00:00
Oleg Kalnichevski dccecd2411 Added a test case for handling of authentication failures with non-repeatable requests
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@759942 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 12:33:25 +00:00
Oleg Kalnichevski e2520f8509 Added test coverage for authentication
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@759926 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 11:34:33 +00:00
Sam Berlin 165507b8d7 include the cause of a NonRepeatableRequestException when failing.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@758447 13f79535-47bb-0310-9956-ffa450edef68
2009-03-25 22:05:45 +00:00
Oleg Kalnichevski bc063a1ad0 HTTPCLIENT-837: Fixed problem with the wire log skipping zero byte values if read one byte at a time.
Contributed by Kirill Safonov <ksafonov at swiftteams.com>

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@757528 13f79535-47bb-0310-9956-ffa450edef68
2009-03-23 20:14:05 +00:00
Sebastian Bazley 6b57ed5755 Concurrency documentation
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756799 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 23:05:07 +00:00
Sebastian Bazley 7c1fa0fda3 Change JCIP dependency scope to provided
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756524 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 15:23:10 +00:00
Sebastian Bazley d5aa3eae89 Document thread-safety
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756435 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 12:49:08 +00:00
Sebastian Bazley df02f73742 Document not thread safe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756315 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 02:42:48 +00:00
Sebastian Bazley 322911cc02 All other accesses to numConnections use poolLock to lock.
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756314 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 02:33:50 +00:00
Sebastian Bazley dd9e5e28ee NotThreadSafe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756309 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 02:21:25 +00:00
Sebastian Bazley c7e53d6acc Unused import
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756300 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:56:01 +00:00
Sebastian Bazley 208bcda71c More Immutable classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756299 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:54:42 +00:00
Sebastian Bazley 3994fe9af2 More Immutable classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756298 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:54:11 +00:00
Sebastian Bazley 1326d80e52 Private Field is not updated, might as well be final
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756297 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:53:34 +00:00
Sebastian Bazley 4753d7e3ac More ThreadSafe and Immutable classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756296 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:52:13 +00:00
Sebastian Bazley e895b182a5 As with other methods, not currently thread-safe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756294 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 01:51:09 +00:00
Sebastian Bazley f97f49b471 Make schemeRegistry final. This makes the class ThreadSafe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756183 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 20:41:46 +00:00
Oleg Kalnichevski ac3eefa92a Fixed potential thread-safety issue. Credits to Sebb
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@756157 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 19:53:53 +00:00
Sebastian Bazley adb782ce7e More non-threadsafe classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755807 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 01:30:00 +00:00
Sebastian Bazley a8571f883b HTTPCLIENT-835 : No point having protected final fields and public getters
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755793 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 00:01:31 +00:00
Sebastian Bazley f3fdcc1a06 Document classes which are not thread-safe currently
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755789 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 23:47:46 +00:00
Sebastian Bazley cdc4fc628b Some more immutable classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755784 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 23:41:04 +00:00
Sebastian Bazley 5b44cc0938 Make AbstractAuthenticationHandler immutable by changing the List to unmodifiable
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755783 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 23:38:11 +00:00
Sebastian Bazley 6c01316e2c Document MT safety concern
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755779 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 23:24:04 +00:00
Sebastian Bazley fe0e5e9654 Add JCIP annotations
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755466 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 03:37:07 +00:00
Sebastian Bazley 12545d7a13 Inline private init method so as to make class immutable
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755462 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 02:44:13 +00:00
Sebastian Bazley de1cead50d Add JCIP annotations
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755461 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 02:41:04 +00:00
Sebastian Bazley 2cc1241ed7 Make protected variables final to reduce multi-threading issues
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755457 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 02:11:44 +00:00
Sebastian Bazley 087d6af97d Fix alignment
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755453 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 01:32:47 +00:00
Sebastian Bazley 65c8f4dabd Add JCIP annotations dependency
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755450 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 00:05:59 +00:00
Oleg Kalnichevski 48634b1b4b Minor generics tweak
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755398 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 21:05:22 +00:00
Oleg Kalnichevski 8e409a71d1 Automatically retry methods considered idempotent
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@755395 13f79535-47bb-0310-9956-ffa450edef68
2009-03-17 21:04:07 +00:00
Oleg Kalnichevski bb15e4d9b3 HTTPCLIENT-833: fixed possible NPE
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@754998 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 20:33:39 +00:00
Sebastian Bazley 72eedbe0ea Avoid possible NPE
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@753460 13f79535-47bb-0310-9956-ffa450edef68
2009-03-13 22:35:53 +00:00