Commit Graph

255 Commits

Author SHA1 Message Date
Sebastian Bazley f5a01c6cb2 No point checking for null, as instanceof else clause handles it
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044527 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 22:51:44 +00:00
Sebastian Bazley 74581924cc Improve equals performance: no need to check for null; perform cheapest checks first.
Use short-cut evaluation

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044525 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 22:41:07 +00:00
Sebastian Bazley 19022393be Add some more tests for equals
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044524 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 22:38:10 +00:00
Oleg Kalnichevski 50906f44e3 Made #equals and #hashCode of HttpRoute consistent with implementations in other classes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044411 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 15:55:41 +00:00
Sebastian Bazley 9a4d4f8bdd [HTTPCLIENT-1030] HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1044366 13f79535-47bb-0310-9956-ffa450edef68
2010-12-10 14:15:54 +00:00
Sebastian Bazley 4580b4f733 Typo: credenticals => credentials
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1043920 13f79535-47bb-0310-9956-ffa450edef68
2010-12-09 12:02:43 +00:00
Sebastian Bazley 9475e26293 HTTPCLIENT-1031 Cannot clone BasicClientCookie2 without specified ports
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1043664 13f79535-47bb-0310-9956-ffa450edef68
2010-12-08 20:37:53 +00:00
Sebastian Bazley 6e306aa4fd Stuff on Execution Context does not really belong here
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1043661 13f79535-47bb-0310-9956-ffa450edef68
2010-12-08 20:27:55 +00:00
Sebastian Bazley 40ef33ce81 Clarify that getURI() may return a relative URI
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1043510 13f79535-47bb-0310-9956-ffa450edef68
2010-12-08 16:43:29 +00:00
Sebastian Bazley d1f6c23e10 HTTPCLIENT-1030) Implement "ignoreCookies" CookieSpec
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1042225 13f79535-47bb-0310-9956-ffa450edef68
2010-12-04 19:01:02 +00:00
Oleg Kalnichevski e6af69f2e4 Never ever discard Errors by catching and ignoring Throwable
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1042217 13f79535-47bb-0310-9956-ffa450edef68
2010-12-04 17:58:08 +00:00
Sebastian Bazley 23948c02cd Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1042005 13f79535-47bb-0310-9956-ffa450edef68
2010-12-03 21:14:23 +00:00
Oleg Kalnichevski 317cddd89a Upgraded project version to 4.1-beta2-SNAPSHOT
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1037288 13f79535-47bb-0310-9956-ffa450edef68
2010-11-20 18:17:57 +00:00
Oleg Kalnichevski 023363e3ff Made PlainSocketFactory non-final; improved SSLSocketFactory#connectSocket() to accept plain sockets as input
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1036123 13f79535-47bb-0310-9956-ffa450edef68
2010-11-17 17:22:28 +00:00
Oleg Kalnichevski b5340858b8 Fixed project site urls
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1036113 13f79535-47bb-0310-9956-ffa450edef68
2010-11-17 17:08:23 +00:00
Oleg Kalnichevski 9e54454530 Generate LICENSE and NOTICE resources automatically using maven plugin; fixed javadoc links to external resources
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1031582 13f79535-47bb-0310-9956-ffa450edef68
2010-11-05 14:28:48 +00:00
Oleg Kalnichevski 31590950b5 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1030510 13f79535-47bb-0310-9956-ffa450edef68
2010-11-03 16:04:47 +00:00
Oleg Kalnichevski c76574f947 Dedicated branch for testing maven-notice-plugin
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/notice-plugin-test@1026503 13f79535-47bb-0310-9956-ffa450edef68
2010-10-22 21:47:45 +00:00
Oleg Kalnichevski 6d67c55306 TABS -> SPACES
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1026121 13f79535-47bb-0310-9956-ffa450edef68
2010-10-21 19:59:18 +00:00
Oleg Kalnichevski e8bb17f4e2 Fixed examples
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1026120 13f79535-47bb-0310-9956-ffa450edef68
2010-10-21 19:57:32 +00:00
Sebastian Bazley e4d6204517 @Overrides
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1023981 13f79535-47bb-0310-9956-ffa450edef68
2010-10-18 20:16:06 +00:00
Sebastian Bazley 15c154c8ac Simplify and eliminate boxing warnings
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1023978 13f79535-47bb-0310-9956-ffa450edef68
2010-10-18 20:13:01 +00:00
Sebastian Bazley fa172d971d Make private immutable variable final
Missing @Override markers

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1023974 13f79535-47bb-0310-9956-ffa450edef68
2010-10-18 20:09:39 +00:00
Oleg Kalnichevski 29f896a0a3 HTTPCLIENT-919: Support for NTLMv1, NTLMv2, and NTLM2 Session authentication.
Contributed by Karl Wright <karl.wright at nokia.com>


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1023959 13f79535-47bb-0310-9956-ffa450edef68
2010-10-18 19:20:08 +00:00
Oleg Kalnichevski e5596fb025 HTTPCLIENT-1002: Stale connection check fails if wire logging is on
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1002956 13f79535-47bb-0310-9956-ffa450edef68
2010-09-30 07:35:30 +00:00
Oleg Kalnichevski a2deba9de5 TABS -> SPACES
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1001145 13f79535-47bb-0310-9956-ffa450edef68
2010-09-25 06:46:36 +00:00
Oleg Kalnichevski 1e70d5a39e HTTPCLIENT-1000: Maximum connection lifetimes settings for ThreadSafeClientConnManager.
Contributed by Michajlo Matijkiw <michajlo_matijkiw at comcast.com>



git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1001144 13f79535-47bb-0310-9956-ffa450edef68
2010-09-25 06:35:07 +00:00
Sebastian Bazley 86c464d15e Add missing @Deprecated annotations
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@1000096 13f79535-47bb-0310-9956-ffa450edef68
2010-09-22 17:19:31 +00:00
Oleg Kalnichevski af025e3483 Removed unused import
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@995237 13f79535-47bb-0310-9956-ffa450edef68
2010-09-08 20:15:04 +00:00
Oleg Kalnichevski 5c2dacac18 HTTPCLIENT-989: DefaultHttpRequestRetryHandler no longer retries non-idempotent http methods if NoHttpResponseException is thrown
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@995236 13f79535-47bb-0310-9956-ffa450edef68
2010-09-08 20:07:31 +00:00
Oleg Kalnichevski ebb54d79b9 Added NOTICE and LICENSE resources to test and osgi jars
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@992065 13f79535-47bb-0310-9956-ffa450edef68
2010-09-02 19:14:13 +00:00
Oleg Kalnichevski 30abf15ba6 Upgraded HttpCore to version 4.1-beta2; updated HttpClient tutorial
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@990924 13f79535-47bb-0310-9956-ffa450edef68
2010-08-30 20:01:46 +00:00
Oleg Kalnichevski 30eb471da7 Catch and log I/O exceptions thrown by #close() and #shutdown() methods
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@989328 13f79535-47bb-0310-9956-ffa450edef68
2010-08-25 19:57:51 +00:00
Oleg Kalnichevski 143f3b0a0c HTTPCLIENT-974: RequestWrapper does not use the headers of the request it wraps
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@982361 13f79535-47bb-0310-9956-ffa450edef68
2010-08-04 18:56:39 +00:00
Oleg Kalnichevski e0d37d5502 Refactored HttpCacheEntry; new API should allow for cache entries backed by a temporary file
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@980937 13f79535-47bb-0310-9956-ffa450edef68
2010-07-30 20:15:39 +00:00
Oleg Kalnichevski c2622c8ca2 HTTPCLIENT-969: BasicCookieStore#getCookies() to return a copy of Cookie list
Contributed by David Smiley <dsmiley at mitre.org>


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@967227 13f79535-47bb-0310-9956-ffa450edef68
2010-07-23 19:45:47 +00:00
Oleg Kalnichevski 8cf6a94f60 Fixed request exec count
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@965986 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 20:21:41 +00:00
Oleg Kalnichevski ee323a52fa Deprecated ConnManagerPNames and related classes; 'http.conn-manager.timeout' parameter deprecated in favor of 'http.connection.timeout'; improved javadocs for deprecated classes; renamed methods in ThreadSafeClientConnManager for better consistency
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@965983 13f79535-47bb-0310-9956-ffa450edef68
2010-07-20 20:14:09 +00:00
Oleg Kalnichevski c80f04cb45 HTTPCLIENT-951: Non-repeatable entity enclosing requests are not correctly retried when 'expect-continue' handshake is active
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@956989 13f79535-47bb-0310-9956-ffa450edef68
2010-06-22 19:28:48 +00:00
Oleg Kalnichevski 12e382daf9 Revert change committed by mistake
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954914 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:40:31 +00:00
Oleg Kalnichevski 4b73b9c74e HTTPCLIENT-948: Completed refactoring of the idle connection handling code; cleaned up logging in connection management code
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954903 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 14:15:34 +00:00
Sebastian Bazley 25071e091c Disambiguate local links so they work with the Doxia 1.1 (which is current for Maven 2.1.0)
(whilst still remaining compatible with the previous Doxia release)

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954679 13f79535-47bb-0310-9956-ffa450edef68
2010-06-15 00:15:49 +00:00
Oleg Kalnichevski a2ad042193 HTTPCLIENT-948: redesign of idle connection handling
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954659 13f79535-47bb-0310-9956-ffa450edef68
2010-06-14 22:00:56 +00:00
Oleg Kalnichevski 0f8ca31e92 HTTPCLIENT-944: maintain separate count of connect attempts
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954282 13f79535-47bb-0310-9956-ffa450edef68
2010-06-13 18:37:25 +00:00
Oleg Kalnichevski 0bb63c609a HTTPCLIENT-953: IllegalStateException thrown by RouteSpecificPool
Contributed by Guillaume <gueugaie at gmail.com>


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954258 13f79535-47bb-0310-9956-ffa450edef68
2010-06-13 16:40:04 +00:00
Oleg Kalnichevski 5f8e3d49de Changed comments
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@954257 13f79535-47bb-0310-9956-ffa450edef68
2010-06-13 16:39:31 +00:00
Oleg Kalnichevski 3be7e6ab91 HTTPCLIENT-942: tweaked example
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@953985 13f79535-47bb-0310-9956-ffa450edef68
2010-06-12 10:39:36 +00:00
Oleg Kalnichevski 555237285c HTTPCLIENT-951: Test cases
Contributed by Thierry Guérin <thi.guerin at laposte.net>



git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@953890 13f79535-47bb-0310-9956-ffa450edef68
2010-06-11 22:10:52 +00:00
Oleg Kalnichevski ade1571f00 HTTPCLIENT-952: Trust store parameter is ingored by SSLSocketFactory
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@953160 13f79535-47bb-0310-9956-ffa450edef68
2010-06-09 20:59:41 +00:00
Oleg Kalnichevski c4c6cfc413 HTTPCLIENT-948: works around the race condition described in HTTPCLIENT-948
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@950717 13f79535-47bb-0310-9956-ffa450edef68
2010-06-02 18:52:05 +00:00