Commit Graph

177 Commits

Author SHA1 Message Date
Sebastian Bazley 0152c00300 Make constants final.
Not used outside class, so don't expose mutable arrays

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@943281 13f79535-47bb-0310-9956-ffa450edef68
2010-05-11 20:30:52 +00:00
Sebastian Bazley 9e0fcc226d Make constants final
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@943279 13f79535-47bb-0310-9956-ffa450edef68
2010-05-11 20:29:47 +00:00
Oleg Kalnichevski 6974f7bfa1 HTTPCLIENT-427: Added some more acceptance tests as specified in the Section 13 of RFC 2616, in terms of MUST and MUST NOT requirements
Contributed by Jonathan Moore <jonathan_moore at comcast.com>


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@942077 13f79535-47bb-0310-9956-ffa450edef68
2010-05-07 14:16:14 +00:00
Oleg Kalnichevski f749748401 Tweaked logging in caching components
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@942073 13f79535-47bb-0310-9956-ffa450edef68
2010-05-07 13:53:13 +00:00
Sebastian Bazley fd2e7a79a9 Javadoc
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941948 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:44:24 +00:00
Sebastian Bazley a85de75581 Make class @Immutable by copying array
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941947 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:43:56 +00:00
Sebastian Bazley 62555455bd +=@NotThreadSafe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941945 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:34:29 +00:00
Sebastian Bazley b5ce3f91ec Does not throw IOException
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941944 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:31:44 +00:00
Sebastian Bazley 6f23db2533 Not Immutable, but should be ThreadSafe
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941943 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:30:20 +00:00
Sebastian Bazley fb47960bfa No need for AtomicLong fields to be volatile
Now @ThreadSafe

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941942 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 21:28:45 +00:00
Oleg Kalnichevski 1d1df0174d HTTPCLIENT-427: CacheEntry made immutable
Contributed by David Mays <david_mays at comcast.com>


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@941886 13f79535-47bb-0310-9956-ffa450edef68
2010-05-06 20:02:22 +00:00
Sebastian Bazley 1a26a94f95 Unthrown Exceptions
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940065 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 16:04:28 +00:00
Sebastian Bazley ebf24c65df No point catching an Exception only to rethrow it - just let JUnit handle it
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940063 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 15:54:06 +00:00
Sebastian Bazley a5814c279c Avoid possible NPE
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940062 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 15:50:47 +00:00
Sebastian Bazley fd513425a1 Unthrown Exceptions
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940061 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 15:47:02 +00:00
Sebastian Bazley 80415614f7 Unthrown Exceptions
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940060 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 15:45:29 +00:00
Sebastian Bazley 882eae6219 Avoid autobox warning
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@940058 13f79535-47bb-0310-9956-ffa450edef68
2010-05-01 15:45:08 +00:00
Sebastian Bazley 8e89d40f37 Add thread-safety annotations
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939883 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 23:58:50 +00:00
Sebastian Bazley 16a8c31100 CachingHttpClient(HttpCache<CacheEntry> cache, int maxObjectSizeBytes) failed to save maxObjectSizeBytes
Make all immutable private fields final

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939875 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 23:29:15 +00:00
Sebastian Bazley aab7960bce No point creating Integer when we need an int
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939863 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:46:55 +00:00
Sebastian Bazley df4e1924f6 Missing @Override
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939860 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:43:43 +00:00
Sebastian Bazley aaf723d2be Avoid possible NPE
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939859 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:43:26 +00:00
Sebastian Bazley 416085813e Unnecessary casts
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939854 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:33:56 +00:00
Sebastian Bazley 529a3e67fc Make private immutable variables final
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939845 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:18:38 +00:00
Sebastian Bazley 77dc3b08a5 Add missing @Override markers
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939843 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 22:17:51 +00:00
Oleg Kalnichevski c44b15f199 TABS -> SPACES
git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939816 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 21:03:23 +00:00
Oleg Kalnichevski 283bba855f HTTPCLIENT-427: HTTP caching support
Contributed by Joe Campbell, David Cleaver, David Mays, Jon Moore, Brad Spenla (Comcast Corporation)


git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk@939814 13f79535-47bb-0310-9956-ffa450edef68
2010-04-30 21:00:08 +00:00