From 0af3380a6064df790940b170e680f5d3b3c58ae7 Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Thu, 28 Apr 2016 13:31:58 -0700 Subject: [PATCH] Address error-prone CheckReturnValue errors Found via Guava 20.0. --- .../extensions/NovaImageExtensionExpectTest.java | 6 +++--- .../NovaSecurityGroupExtensionExpectTest.java | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaImageExtensionExpectTest.java b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaImageExtensionExpectTest.java index 08762cd9d6..4f8dc7e52c 100644 --- a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaImageExtensionExpectTest.java +++ b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaImageExtensionExpectTest.java @@ -74,9 +74,9 @@ public class NovaImageExtensionExpectTest extends BaseNovaComputeServiceExpectTe public void testCreateImage() { Builder requestResponseMap = ImmutableMap. builder(); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); - requestResponseMap.put(serverDetail, serverDetailResponse).build(); - requestResponseMap.put(createImage, createImageResponse).build(); - requestResponseMap.put(getImage, getImageResponse).build(); + requestResponseMap.put(serverDetail, serverDetailResponse); + requestResponseMap.put(createImage, createImageResponse); + requestResponseMap.put(getImage, getImageResponse); ImageExtension apiThatCreatesImage = requestsSendResponses(requestResponseMap.build()).getImageExtension().get(); diff --git a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java index 9795aa9966..caa80fd40d 100644 --- a/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java +++ b/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java @@ -69,7 +69,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService Builder requestResponseMap = ImmutableMap. builder(); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); - requestResponseMap.put(list, listResponse).build(); + requestResponseMap.put(list, listResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); @@ -90,7 +90,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService Builder requestResponseMap = ImmutableMap. builder(); requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); - requestResponseMap.put(list, listResponse).build(); + requestResponseMap.put(list, listResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); @@ -125,7 +125,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(serverReq, serverResponse); - requestResponseMap.put(list, listResponse).build(); + requestResponseMap.put(list, listResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); @@ -146,7 +146,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse); - requestResponseMap.put(list, listResponse).build(); + requestResponseMap.put(list, listResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); @@ -188,7 +188,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(create, createResponse); requestResponseMap.put(list, listResponse); - requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse).build(); + requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get(); @@ -221,7 +221,7 @@ public class NovaSecurityGroupExtensionExpectTest extends BaseNovaComputeService requestResponseMap.put(keystoneAuthWithUsernameAndPasswordAndTenantName, responseWithKeystoneAccess); requestResponseMap.put(extensionsOfNovaRequest, extensionsOfNovaResponse); requestResponseMap.put(getSecurityGroup, getSecurityGroupResponse); - requestResponseMap.put(delete, deleteResponse).build(); + requestResponseMap.put(delete, deleteResponse); SecurityGroupExtension extension = requestsSendResponses(requestResponseMap.build()).getSecurityGroupExtension().get();