From 12bd7f4fdc5d16150b6f8f9286de255e1f158d1f Mon Sep 17 00:00:00 2001 From: "adrian.f.cole" Date: Fri, 1 May 2009 21:07:55 +0000 Subject: [PATCH] Issue 3: revised factory method to be named createInputStreamMap git-svn-id: http://jclouds.googlecode.com/svn/trunk@178 3d8758e0-26b5-11de-8745-db77d3ebf521 --- pom.xml | 1 - s3/src/main/java/org/jclouds/aws/s3/S3Context.java | 2 +- .../main/java/org/jclouds/aws/s3/internal/GuiceS3Context.java | 2 +- s3/src/test/java/org/jclouds/aws/s3/S3InputStreamMapTest.java | 2 +- .../org/jclouds/samples/googleappengine/JCloudsServlet.java | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 0966e0c0d6..5925545954 100644 --- a/pom.xml +++ b/pom.xml @@ -44,7 +44,6 @@ extensions/s3nio gae s3 - s3/perftest diff --git a/s3/src/main/java/org/jclouds/aws/s3/S3Context.java b/s3/src/main/java/org/jclouds/aws/s3/S3Context.java index 7c6bf19e7a..b4ba574142 100644 --- a/s3/src/main/java/org/jclouds/aws/s3/S3Context.java +++ b/s3/src/main/java/org/jclouds/aws/s3/S3Context.java @@ -39,7 +39,7 @@ public interface S3Context { * @param bucket * @return */ - S3InputStreamMap createS3InputStreamMap(S3Bucket bucket); + S3InputStreamMap createInputStreamMap(S3Bucket bucket); /** * Creates a Map view of the specified bucket. diff --git a/s3/src/main/java/org/jclouds/aws/s3/internal/GuiceS3Context.java b/s3/src/main/java/org/jclouds/aws/s3/internal/GuiceS3Context.java index c018e78d4c..c7306c17a6 100644 --- a/s3/src/main/java/org/jclouds/aws/s3/internal/GuiceS3Context.java +++ b/s3/src/main/java/org/jclouds/aws/s3/internal/GuiceS3Context.java @@ -77,7 +77,7 @@ public class GuiceS3Context implements S3Context { /** * {@inheritDoc} */ - public S3InputStreamMap createS3InputStreamMap(S3Bucket bucket) { + public S3InputStreamMap createInputStreamMap(S3Bucket bucket) { getConnection().createBucketIfNotExists(bucket); return s3InputStreamMapFactory.createMapView(bucket); } diff --git a/s3/src/test/java/org/jclouds/aws/s3/S3InputStreamMapTest.java b/s3/src/test/java/org/jclouds/aws/s3/S3InputStreamMapTest.java index fe0fd0b7fd..1f9af708ab 100644 --- a/s3/src/test/java/org/jclouds/aws/s3/S3InputStreamMapTest.java +++ b/s3/src/test/java/org/jclouds/aws/s3/S3InputStreamMapTest.java @@ -51,7 +51,7 @@ public class S3InputStreamMapTest extends BaseS3MapTest { @SuppressWarnings("unchecked") protected BaseS3Map createMap(S3Context context, S3Bucket bucket) { - map = context.createS3InputStreamMap(bucket); + map = context.createInputStreamMap(bucket); return (BaseS3Map) map; } diff --git a/samples/googleappengine/src/main/java/org/jclouds/samples/googleappengine/JCloudsServlet.java b/samples/googleappengine/src/main/java/org/jclouds/samples/googleappengine/JCloudsServlet.java index d68166c526..3b3e3fbc61 100644 --- a/samples/googleappengine/src/main/java/org/jclouds/samples/googleappengine/JCloudsServlet.java +++ b/samples/googleappengine/src/main/java/org/jclouds/samples/googleappengine/JCloudsServlet.java @@ -62,7 +62,7 @@ public class JCloudsServlet extends HttpServlet { writer.write("List:\n"); for (S3Bucket bucket : myBuckets) { writer.write(String.format(" %1s: %2s entries%n", bucket - .getName(), context.createS3InputStreamMap(bucket) + .getName(), context.createInputStreamMap(bucket) .size())); } } catch (Exception e) {