Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Miscellaneous FindBugs fixes

This commit is contained in:
Andrew Gaul 2014-08-27 10:16:53 -07:00
parent 5399cb6877
commit 195998b3b6
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apis/rackspace-clouddns/src/main/java/org/jclouds/rackspace/clouddns/v1/binders/UpdateRecordsToJSON.java
View File

@ -66,8 +66,9 @@ public class UpdateRecordsToJSON implements Binder {
static List<UpdateRecord> toUpdateRecordList(Map<String, Record> idsToRecords) {
List<UpdateRecord> updateRecords = Lists.newArrayList();
for (String recordId : idsToRecords.keySet()) {
Record record = idsToRecords.get(recordId);
for (Map.Entry<String, Record> entry : idsToRecords.entrySet()) {
String recordId = entry.getKey();
Record record = entry.getValue();
UpdateRecord updateRecord = new UpdateRecord();
updateRecord.id = recordId;

2
apis/s3/src/main/java/org/jclouds/s3/config/S3RestClientModule.java
View File

@ -121,7 +121,7 @@ public class S3RestClientModule<S extends S3Client, A extends S3AsyncClient> ext
try {
return Optional.fromNullable(client.getBucketLocation(bucket));
} catch (ContainerNotFoundException e) {
return null;
return Optional.absent();
}
}

2
compute/src/main/java/org/jclouds/ovf/xml/internal/BaseVirtualSystemHandler.java
View File

@ -64,7 +64,7 @@ public class BaseVirtualSystemHandler<T extends BaseVirtualSystem<T>, B extends
@Inject(optional = true)
protected void setExtensionHandlers(
@Named("VirtualSystem") Map<String, Provider<? extends SectionHandler>> extensionHandlers) {
extensionHandlers = ImmutableMap.<String, Provider<? extends SectionHandler>> builder().putAll(
this.extensionHandlers = ImmutableMap.<String, Provider<? extends SectionHandler>> builder().putAll(
this.extensionHandlers).putAll(extensionHandlers).build();
}

3
compute/src/main/java/org/jclouds/ssh/SshKeys.java
View File

@ -55,6 +55,7 @@ import com.google.common.collect.ImmutableMap.Builder;
import com.google.common.hash.HashCode;
import com.google.common.hash.Hashing;
import com.google.common.io.ByteSource;
import com.google.common.io.ByteStreams;
/**
* Utilities for ssh key pairs
@ -115,7 +116,7 @@ public class SshKeys {
int byte4 = in.read();
int length = (byte1 << 24) + (byte2 << 16) + (byte3 << 8) + (byte4 << 0);
byte[] val = new byte[length];
in.read(val, 0, length);
ByteStreams.readFully(in, val);
return val;
}