From 347926543ee72a14f8587bc83f72e1064cef8784 Mon Sep 17 00:00:00 2001 From: Adrian Cole Date: Tue, 11 Nov 2014 20:15:56 -0800 Subject: [PATCH] * Change OAuthScopes into an interface as opposed to boilerplating annotations. * Fixed errors because of boilerplating annotations. --- .../compute/functions/Resources.java | 9 +----- .../GoogleComputeEngineHttpApiModule.java | 9 +++--- .../config/GoogleComputeEngineScopes.java | 28 ------------------- .../features/AddressApi.java | 9 ------ .../features/AggregatedListApi.java | 3 -- .../googlecomputeengine/features/DiskApi.java | 11 -------- .../features/DiskTypeApi.java | 3 -- .../features/FirewallApi.java | 11 -------- .../features/ForwardingRuleApi.java | 10 ------- .../features/HttpHealthCheckApi.java | 12 -------- .../features/ImageApi.java | 13 --------- .../features/InstanceApi.java | 18 ------------ .../features/MachineTypeApi.java | 6 ---- .../features/NetworkApi.java | 10 ------- .../features/OperationApi.java | 14 ---------- .../features/ProjectApi.java | 5 ---- .../features/RegionApi.java | 3 -- .../features/RouteApi.java | 11 -------- .../features/SnapshotApi.java | 8 ------ .../features/TargetPoolApi.java | 16 ----------- .../googlecomputeengine/features/ZoneApi.java | 3 -- ...ngineAuthenticatedRestContextLiveTest.java | 3 +- .../features/AddressApiExpectTest.java | 2 -- .../features/DiskApiExpectTest.java | 2 -- .../features/DiskTypeApiExpectTest.java | 1 - .../features/FirewallApiExpectTest.java | 2 -- .../features/ForwardingRuleApiExpectTest.java | 2 -- .../HttpHealthCheckApiExpectTest.java | 2 -- .../features/ImageApiExpectTest.java | 2 -- .../features/InstanceApiExpectTest.java | 2 -- .../features/MachineTypeApiExpectTest.java | 1 - .../features/NetworkApiExpectTest.java | 2 -- .../features/OperationApiExpectTest.java | 2 -- .../features/ProjectApiExpectTest.java | 2 -- .../features/RegionApiExpectTest.java | 1 - .../features/RouteApiExpectTest.java | 2 -- .../features/SnapshotApiExpectTest.java | 1 - .../features/TargetPoolApiExpectTest.java | 2 -- .../features/ZoneApiExpectTest.java | 1 - .../BaseGoogleComputeEngineExpectTest.java | 2 ++ .../ToIteratorOfListPageExpectTest.java | 4 +-- 41 files changed, 10 insertions(+), 240 deletions(-) delete mode 100644 providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineScopes.java rename providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/{functions => }/internal/ToIteratorOfListPageExpectTest.java (97%) diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java index 34ddd506b2..8ddfec9085 100644 --- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java +++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java @@ -18,8 +18,6 @@ package org.jclouds.googlecomputeengine.compute.functions; import static javax.ws.rs.core.MediaType.APPLICATION_JSON; import static org.jclouds.Fallbacks.NullOnNotFoundOr404; -import static org.jclouds.googlecomputeengine.config.GoogleComputeEngineScopes.COMPUTE_READONLY_SCOPE; -import static org.jclouds.googlecomputeengine.config.GoogleComputeEngineScopes.COMPUTE_SCOPE; import java.net.URI; @@ -34,7 +32,6 @@ import org.jclouds.googlecomputeengine.domain.Instance; import org.jclouds.googlecomputeengine.domain.Network; import org.jclouds.googlecomputeengine.domain.Operation; import org.jclouds.javax.annotation.Nullable; -import org.jclouds.oauth.v2.config.OAuthScopes; import org.jclouds.oauth.v2.filters.OAuthAuthenticationFilter; import org.jclouds.rest.annotations.EndpointParam; import org.jclouds.rest.annotations.Fallback; @@ -49,30 +46,26 @@ public interface Resources { /** Returns an instance by self-link or null if not found. */ @Named("Instances:get") @GET - @OAuthScopes(COMPUTE_READONLY_SCOPE) @Fallback(NullOnNotFoundOr404.class) @Nullable Instance instance(@EndpointParam URI selfLink); /** Returns an network by self-link or null if not found. */ @Named("Networks:get") @GET - @OAuthScopes(COMPUTE_READONLY_SCOPE) @Fallback(NullOnNotFoundOr404.class) @Nullable Network network(@EndpointParam URI selfLink); /** Returns an operation by self-link or null if not found. */ @Named("Operations:get") @GET - @OAuthScopes(COMPUTE_READONLY_SCOPE) @Fallback(NullOnNotFoundOr404.class) @Nullable Operation operation(@EndpointParam URI selfLink); /** Deletes any resource by self-link and returns the operation in progress, or null if not found. */ @Named("Resources:delete") @DELETE - @OAuthScopes(COMPUTE_SCOPE) @Fallback(NullOnNotFoundOr404.class) @Nullable Operation delete(@EndpointParam URI selfLink); /** Hard-resets the instance by self-link and returns the operation in progres */ @Named("Instances:reset") @POST @Path("/reset") - @OAuthScopes(COMPUTE_SCOPE) Operation resetInstance(@EndpointParam URI selfLink); + Operation resetInstance(@EndpointParam URI selfLink); } diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java index d37c162f55..b89fd92a90 100644 --- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java +++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineHttpApiModule.java @@ -22,7 +22,6 @@ import static java.util.concurrent.TimeUnit.SECONDS; import static javax.ws.rs.core.MediaType.APPLICATION_JSON; import static org.jclouds.Constants.PROPERTY_SESSION_INTERVAL; import static org.jclouds.googlecomputeengine.config.GoogleComputeEngineProperties.PROJECT_NAME; -import static org.jclouds.googlecomputeengine.config.GoogleComputeEngineScopes.COMPUTE_READONLY_SCOPE; import static org.jclouds.rest.config.BinderUtils.bindHttpApi; import java.net.URI; @@ -48,6 +47,7 @@ import org.jclouds.http.annotation.Redirection; import org.jclouds.http.annotation.ServerError; import org.jclouds.location.Provider; import org.jclouds.oauth.v2.config.OAuthScopes; +import org.jclouds.oauth.v2.config.OAuthScopes.ReadOrWriteScopes; import org.jclouds.oauth.v2.filters.OAuthAuthenticationFilter; import org.jclouds.providers.ProviderMetadata; import org.jclouds.rest.AuthorizationException; @@ -65,12 +65,14 @@ import com.google.inject.Provides; @ConfiguresHttpApi public final class GoogleComputeEngineHttpApiModule extends HttpApiModule { - public GoogleComputeEngineHttpApiModule() { - } @Override protected void configure() { super.configure(); bindHttpApi(binder(), UseApiToResolveProjectName.GetProject.class); + bind(OAuthScopes.class).toInstance(ReadOrWriteScopes.create( // + "https://www.googleapis.com/auth/compute.readonly", // + "https://www.googleapis.com/auth/compute" // + )); } @Override protected void bindErrorHandlers() { @@ -118,7 +120,6 @@ public final class GoogleComputeEngineHttpApiModule extends HttpApiModule