Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enforce Override annotation via Checkstyle 

Also remove bogus inheritDoc on base and static methods.
This commit is contained in:
Andrew Gaul 2014-08-31 13:34:46 -07:00
parent fdef97d527
commit 34cfdbe266
17 changed files with 40 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apis/ec2/src/main/java/org/jclouds/ec2/domain/BundleTask.java
View File

@ -31,6 +31,7 @@ public class BundleTask implements Comparable<BundleTask> {
/**
* {@inheritDoc}
*/
@Override
public int compareTo(BundleTask o) {
return (this == o) ? 0 : getBundleId().compareTo(o.getBundleId());
}

1
apis/ec2/src/main/java/org/jclouds/ec2/domain/Image.java
View File

@ -353,6 +353,7 @@ public class Image implements Comparable<Image> {
/**
* {@inheritDoc}
*/
@Override
public int compareTo(Image o) {
return (this == o) ? 0 : getId().compareTo(o.getId());
}

1
apis/ec2/src/main/java/org/jclouds/ec2/domain/KeyPair.java
View File

@ -113,6 +113,7 @@ public class KeyPair implements Comparable<KeyPair> {
/**
* {@inheritDoc}
*/
@Override
public int compareTo(KeyPair o) {
return (this == o) ? 0 : getKeyName().compareTo(o.getKeyName());
}

1
apis/ec2/src/main/java/org/jclouds/ec2/domain/PublicIpInstanceIdPair.java
View File

@ -52,6 +52,7 @@ public class PublicIpInstanceIdPair implements Comparable<PublicIpInstanceIdPair
/**
* {@inheritDoc}
*/
@Override
public int compareTo(PublicIpInstanceIdPair o) {
return (this == o) ? 0 : getPublicIp().compareTo(o.getPublicIp());
}

1
apis/ec2/src/main/java/org/jclouds/ec2/domain/UserIdGroupPair.java
View File

@ -43,6 +43,7 @@ public class UserIdGroupPair implements Comparable<UserIdGroupPair> {
/**
* {@inheritDoc}
*/
@Override
public int compareTo(UserIdGroupPair o) {
return (this == o) ? 0 : getUserId().compareTo(o.getUserId());
}

7
apis/swift/src/main/java/org/jclouds/openstack/swift/domain/internal/ObjectInfoImpl.java
View File

@ -164,6 +164,7 @@ public class ObjectInfoImpl implements ObjectInfo {
/**
* {@inheritDoc}
*/
@Override
public String getName() {
return this.name;
}
@ -172,6 +173,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public String getContainer() {
return this.container;
}
@ -180,6 +182,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public URI getUri() {
return this.uri;
}
@ -188,6 +191,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public byte[] getHash() {
return this.hash;
}
@ -196,6 +200,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public Long getBytes() {
return this.bytes;
}
@ -204,6 +209,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public String getContentType() {
return this.contentType;
}
@ -212,6 +218,7 @@ public class ObjectInfoImpl implements ObjectInfo {
* {@inheritDoc}
*/
@Nullable
@Override
public Date getLastModified() {
return this.lastModified;
}

1
apis/vcloud/src/main/java/org/jclouds/vcloud/domain/internal/CatalogImpl.java
View File

@ -86,6 +86,7 @@ public class CatalogImpl extends LinkedHashMap<String, ReferenceType> implements
/**
* {@inheritDoc}
*/
@Override
public String getDescription() {
return description;
}

3
apis/vcloud/src/main/java/org/jclouds/vcloud/options/CloneVAppOptions.java
View File

@ -72,9 +72,6 @@ public class CloneVAppOptions extends CloneOptions {
return new CloneVAppOptions().powerOn();
}
/**
* {@inheritDoc}
*/
public static CloneVAppOptions description(String description) {
return new CloneVAppOptions().description(description);
}

3
apis/vcloud/src/main/java/org/jclouds/vcloud/options/CloneVAppTemplateOptions.java
View File

@ -26,9 +26,6 @@ public class CloneVAppTemplateOptions extends CloneOptions {
}
public static class Builder {
/**
* {@inheritDoc}
*/
public static CloneVAppTemplateOptions description(String description) {
return new CloneVAppTemplateOptions().description(description);
}

2
blobstore/src/main/java/org/jclouds/blobstore/options/ListContainerOptions.java
View File

@ -145,6 +145,7 @@ public class ListContainerOptions extends ListOptions implements Cloneable {
/**
* {@inheritDoc}
*/
@Override
public ListContainerOptions afterMarker(String marker) {
return (ListContainerOptions) super.afterMarker(marker);
}
@ -152,6 +153,7 @@ public class ListContainerOptions extends ListOptions implements Cloneable {
/**
* {@inheritDoc}
*/
@Override
public ListContainerOptions maxResults(int maxKeys) {
return (ListContainerOptions) super.maxResults(maxKeys);
}

1
compute/src/main/java/org/jclouds/net/domain/IpPermission.java
View File

@ -168,6 +168,7 @@ public class IpPermission implements Comparable<IpPermission> {
/**
* {@inheritDoc}
*/
@Override
public int compareTo(IpPermission o) {
return (this == o) ? 0 : getIpProtocol().compareTo(o.getIpProtocol());
}

2
compute/src/main/java/org/jclouds/ovf/Envelope.java
View File

@ -30,6 +30,7 @@ public class Envelope extends BaseEnvelope<VirtualSystem, Envelope> {
/**
* {@inheritDoc}
*/
@Override
public Builder toBuilder() {
return new Builder().fromEnvelope(this);
}
@ -39,6 +40,7 @@ public class Envelope extends BaseEnvelope<VirtualSystem, Envelope> {
/**
* {@inheritDoc}
*/
@Override
public Envelope build() {
return new Envelope(diskSections, networkSections, additionalSections, virtualSystem);
}

6
compute/src/main/java/org/jclouds/ovf/internal/BaseEnvelope.java
View File

@ -36,9 +36,6 @@ public class BaseEnvelope<V extends BaseVirtualSystem<V>, E extends BaseEnvelope
return new Builder<V, E>();
}
/**
* {@inheritDoc}
*/
public Builder<V, E> toBuilder() {
return new Builder<V, E>().fromEnvelope(this);
}
@ -109,9 +106,6 @@ public class BaseEnvelope<V extends BaseVirtualSystem<V>, E extends BaseEnvelope
return this;
}
/**
* {@inheritDoc}
*/
@SuppressWarnings("unchecked")
public E build() {
return (E) new BaseEnvelope<V, E>(diskSections, networkSections, additionalSections, virtualSystem);

2
core/src/main/java/org/jclouds/http/options/BaseHttpRequestOptions.java
View File

@ -61,6 +61,7 @@ public class BaseHttpRequestOptions implements HttpRequestOptions {
/**
* {@inheritDoc}
*/
@Override
public Multimap<String, String> buildRequestHeaders() {
return headers;
}
@ -68,6 +69,7 @@ public class BaseHttpRequestOptions implements HttpRequestOptions {
/**
* {@inheritDoc}
*/
@Override
public Multimap<String, String> buildQueryParameters() {
return queryParameters;
}

11
providers/azureblob/src/main/java/org/jclouds/azureblob/domain/internal/MutableBlobPropertiesImpl.java
View File

@ -71,7 +71,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
}
/**
*{@inheritDoc}
* Set the blob type.
*/
public void setType(BlobType type) {
this.type = type;
@ -80,6 +80,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public String getName() {
return name;
}
@ -87,6 +88,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public Date getLastModified() {
return lastModified;
}
@ -94,6 +96,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public String getETag() {
return eTag;
}
@ -101,6 +104,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public int compareTo(BlobProperties o) {
return (this == o) ? 0 : getName().compareTo(o.getName());
}
@ -108,6 +112,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public Map<String, String> getMetadata() {
return metadata;
}
@ -123,6 +128,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public void setETag(String eTag) {
this.eTag = eTag;
}
@ -130,6 +136,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public void setName(String name) {
this.name = name;
}
@ -137,6 +144,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public void setLastModified(Date lastModified) {
this.lastModified = lastModified;
}
@ -144,6 +152,7 @@ public class MutableBlobPropertiesImpl implements MutableBlobProperties {
/**
*{@inheritDoc}
*/
@Override
public void setMetadata(Map<String, String> metadata) {
this.metadata = metadata;
}

9
providers/azureblob/src/main/java/org/jclouds/azureblob/domain/internal/MutableContainerPropertiesWithMetadataImpl.java
View File

@ -44,6 +44,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public String getName() {
return name;
}
@ -51,6 +52,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public Date getLastModified() {
return lastModified;
}
@ -58,6 +60,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public String getETag() {
return eTag;
}
@ -65,6 +68,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public int compareTo(ContainerProperties o) {
return (this == o) ? 0 : getName().compareTo(o.getName());
}
@ -72,6 +76,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public Map<String, String> getMetadata() {
return metadata;
}
@ -79,6 +84,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public void setETag(String eTag) {
this.eTag = eTag;
}
@ -86,6 +92,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public void setName(String name) {
this.name = name;
}
@ -93,6 +100,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public void setLastModified(Date lastModified) {
this.lastModified = lastModified;
}
@ -100,6 +108,7 @@ public class MutableContainerPropertiesWithMetadataImpl implements
/**
*{@inheritDoc}
*/
@Override
public void setMetadata(Map<String, String> metadata) {
this.metadata = metadata;
}

1
resources/checkstyle.xml
View File

@ -36,6 +36,7 @@
<property name="max" value="120"/>
</module>
-->
<module name="MissingOverride"/>
<module name="ModifierOrder"/>
<module name="MultipleVariableDeclarations"/>
<module name="NoWhitespaceAfter">