Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue 76: properly address UTF encoding of paths 

git-svn-id: http://jclouds.googlecode.com/svn/trunk@1843 3d8758e0-26b5-11de-8745-db77d3ebf521
This commit is contained in:
adrian.f.cole 2009-08-09 22:41:55 +00:00
parent 6f58f153b5
commit 44eed3917f
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
core/src/main/java/org/jclouds/rest/JaxrsAnnotationProcessor.java
View File

@ -532,21 +532,24 @@ public class JaxrsAnnotationProcessor {
for (Entry<Integer, Set<Annotation>> entry : indexToPathParam.entrySet()) {
for (Annotation key : entry.getValue()) {
Set<Annotation> extractors = indexToParamExtractor.get(entry.getKey());
String paramKey = ((PathParam) key).value();
String paramValue;
if (extractors != null && extractors.size() > 0) {
ParamParser extractor = (ParamParser) extractors.iterator().next();
pathParamValues.put(((PathParam) key).value(), injector.getInstance(
extractor.value()).apply(args[entry.getKey()]));
paramValue = injector.getInstance(extractor.value()).apply(args[entry.getKey()]);
} else {
String paramKey = ((PathParam) key).value();
String paramValue = URLEncoder.encode(args[entry.getKey()].toString(), "UTF-8");
for (char c : skipEncode) {
String value = Character.toString(c);
String encoded = URLEncoder.encode(value, "UTF-8");
paramValue = paramValue.replaceAll(encoded, value);
}
pathParamValues.put(paramKey, paramValue);
paramValue = args[entry.getKey()].toString();
}
paramValue = URLEncoder.encode(paramValue, "UTF-8");
// Web browsers do not always handle '+' characters well, use the well-supported
// '%20' instead.
paramValue = paramValue.replaceAll("\\+", "%20");
for (char c : skipEncode) {
String value = Character.toString(c);
String encoded = URLEncoder.encode(value, "UTF-8");
paramValue = paramValue.replaceAll(encoded, value);
}
pathParamValues.put(paramKey, paramValue);
}
}
return pathParamValues;