mirror of https://github.com/apache/jclouds.git
Replaced the deprecated BlobStoreContextFactory with the new-style BlobStoreContextBuilder for gae-tweetstore-spring
This commit is contained in:
parent
365d3af7fa
commit
4539174a7f
|
@ -43,7 +43,7 @@ import javax.servlet.ServletConfig;
|
|||
import javax.servlet.ServletException;
|
||||
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.demo.tweetstore.config.util.CredentialsCollector;
|
||||
import org.jclouds.demo.tweetstore.controller.AddTweetsController;
|
||||
import org.jclouds.demo.tweetstore.controller.EnqueueStoresController;
|
||||
|
@ -86,15 +86,13 @@ public class SpringServletConfig extends LoggingConfig implements ServletConfigA
|
|||
|
||||
private ServletConfig servletConfig;
|
||||
|
||||
private Map<String, BlobStoreContext> providerTypeToBlobStoreMap;
|
||||
private Map<String, BlobStoreContext<?, ?>> providerTypeToBlobStoreMap;
|
||||
private Twitter twitterClient;
|
||||
private String container;
|
||||
private Queue queue;
|
||||
|
||||
@PostConstruct
|
||||
public void initialize() throws IOException {
|
||||
BlobStoreContextFactory blobStoreContextFactory = new BlobStoreContextFactory();
|
||||
|
||||
Properties props = loadJCloudsProperties();
|
||||
LOGGER.trace("About to initialize members.");
|
||||
|
||||
|
@ -118,7 +116,8 @@ public class SpringServletConfig extends LoggingConfig implements ServletConfigA
|
|||
// instantiate and store references to all blobstores by provider name
|
||||
providerTypeToBlobStoreMap = Maps.newHashMap();
|
||||
for (String hint : getBlobstoreContexts(props)) {
|
||||
providerTypeToBlobStoreMap.put(hint, blobStoreContextFactory.createContext(hint, modules, props));
|
||||
providerTypeToBlobStoreMap.put(hint, BlobStoreContextBuilder
|
||||
.newBuilder(hint).modules(modules).overrides(props).build());
|
||||
}
|
||||
|
||||
// get a queue for submitting store tweet requests
|
||||
|
@ -212,7 +211,7 @@ public class SpringServletConfig extends LoggingConfig implements ServletConfigA
|
|||
@PreDestroy
|
||||
public void destroy() throws Exception {
|
||||
LOGGER.trace("About to close contexts.");
|
||||
for (BlobStoreContext context : providerTypeToBlobStoreMap.values()) {
|
||||
for (BlobStoreContext<?, ?> context : providerTypeToBlobStoreMap.values()) {
|
||||
context.close();
|
||||
}
|
||||
LOGGER.trace("Contexts closed.");
|
||||
|
|
|
@ -54,14 +54,14 @@ public class AddTweetsController extends HttpServlet implements
|
|||
|
||||
/** The serialVersionUID */
|
||||
private static final long serialVersionUID = 3888348023150822683L;
|
||||
private final Map<String, BlobStoreContext> contexts;
|
||||
private final Map<String, BlobStoreContext<?, ?>> contexts;
|
||||
private final ServiceToStoredTweetStatuses blobStoreContextToContainerResult;
|
||||
|
||||
@Resource
|
||||
protected Logger logger = Logger.NULL;
|
||||
|
||||
@Inject
|
||||
public AddTweetsController(Map<String, BlobStoreContext> contexts,
|
||||
public AddTweetsController(Map<String, BlobStoreContext<?, ?>> contexts,
|
||||
ServiceToStoredTweetStatuses blobStoreContextToContainerResult) {
|
||||
this.contexts = contexts;
|
||||
this.blobStoreContextToContainerResult = blobStoreContextToContainerResult;
|
||||
|
|
|
@ -60,7 +60,7 @@ public class EnqueueStoresController extends HttpServlet {
|
|||
protected Logger logger = Logger.NULL;
|
||||
|
||||
@Inject
|
||||
public EnqueueStoresController(Map<String, BlobStoreContext> contexts,
|
||||
public EnqueueStoresController(Map<String, BlobStoreContext<?, ?>> contexts,
|
||||
Queue taskQueue) {
|
||||
contextNames = contexts.keySet();
|
||||
this.taskQueue = taskQueue;
|
||||
|
|
|
@ -73,7 +73,7 @@ public class StoreTweetsController extends HttpServlet {
|
|||
/** The serialVersionUID */
|
||||
private static final long serialVersionUID = 7215420527854203714L;
|
||||
|
||||
private final Map<String, BlobStoreContext> contexts;
|
||||
private final Map<String, BlobStoreContext<?, ?>> contexts;
|
||||
private final Twitter client;
|
||||
private final String container;
|
||||
|
||||
|
@ -82,7 +82,7 @@ public class StoreTweetsController extends HttpServlet {
|
|||
|
||||
@Inject
|
||||
@VisibleForTesting
|
||||
public StoreTweetsController(Map<String, BlobStoreContext> contexts,
|
||||
public StoreTweetsController(Map<String, BlobStoreContext<?, ?>> contexts,
|
||||
@Named(TweetStoreConstants.PROPERTY_TWEETSTORE_CONTAINER) String container, Twitter client) {
|
||||
this.container = container;
|
||||
this.contexts = contexts;
|
||||
|
@ -91,7 +91,7 @@ public class StoreTweetsController extends HttpServlet {
|
|||
|
||||
@VisibleForTesting
|
||||
public void addMyTweets(String contextName, Iterable<Status> responseList) {
|
||||
BlobStoreContext context = checkNotNull(contexts.get(contextName), "no context for " + contextName + " in "
|
||||
BlobStoreContext<?, ?> context = checkNotNull(contexts.get(contextName), "no context for " + contextName + " in "
|
||||
+ contexts.keySet());
|
||||
BlobMap map = context.createBlobMap(container);
|
||||
for (Status status : responseList) {
|
||||
|
|
|
@ -39,11 +39,11 @@ import com.google.common.collect.Iterables;
|
|||
@Singleton
|
||||
public class ServiceToStoredTweetStatuses implements Function<String, Iterable<StoredTweetStatus>> {
|
||||
|
||||
private final Map<String, BlobStoreContext> contexts;
|
||||
private final Map<String, BlobStoreContext<?, ?>> contexts;
|
||||
private final String container;
|
||||
|
||||
@Inject
|
||||
public ServiceToStoredTweetStatuses(Map<String, BlobStoreContext> contexts,
|
||||
public ServiceToStoredTweetStatuses(Map<String, BlobStoreContext<?, ?>> contexts,
|
||||
@Named(TweetStoreConstants.PROPERTY_TWEETSTORE_CONTAINER) String container) {
|
||||
this.contexts = contexts;
|
||||
this.container = container;
|
||||
|
@ -53,7 +53,7 @@ public class ServiceToStoredTweetStatuses implements Function<String, Iterable<S
|
|||
protected Logger logger = Logger.NULL;
|
||||
|
||||
public Iterable<StoredTweetStatus> apply(String service) {
|
||||
BlobStoreContext context = contexts.get(service);
|
||||
BlobStoreContext<?, ?> context = contexts.get(service);
|
||||
String host = context.getProviderSpecificContext().getEndpoint().getHost();
|
||||
try {
|
||||
BlobMap blobMap = context.createBlobMap(container);
|
||||
|
|
|
@ -26,7 +26,8 @@ import java.util.Map;
|
|||
import java.util.concurrent.ExecutionException;
|
||||
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.blobstore.TransientApiMetadata;
|
||||
import org.jclouds.blobstore.domain.Blob;
|
||||
import org.jclouds.demo.tweetstore.domain.StoredTweetStatus;
|
||||
import org.jclouds.demo.tweetstore.functions.ServiceToStoredTweetStatuses;
|
||||
|
@ -45,12 +46,12 @@ import com.google.common.collect.ImmutableSet;
|
|||
@Test(groups = "unit")
|
||||
public class AddTweetsControllerTest {
|
||||
|
||||
Map<String, BlobStoreContext> createServices(String container) throws InterruptedException,
|
||||
Map<String, BlobStoreContext<?, ?>> createServices(String container) throws InterruptedException,
|
||||
ExecutionException {
|
||||
Map<String, BlobStoreContext> services = Maps.newHashMap();
|
||||
Map<String, BlobStoreContext<?, ?>> services = Maps.newHashMap();
|
||||
TransientApiMetadata transientApiMetadata = TransientApiMetadata.builder().build();
|
||||
for (String name : new String[] { "1", "2" }) {
|
||||
BlobStoreContext context = new BlobStoreContextFactory().createContext("transient",
|
||||
"dummy", "dummy");
|
||||
BlobStoreContext<?, ?> context = BlobStoreContextBuilder.newBuilder(transientApiMetadata).build();
|
||||
context.getAsyncBlobStore().createContainerInLocation(null, container).get();
|
||||
Blob blob = context.getAsyncBlobStore().blobBuilder("1").build();
|
||||
blob.getMetadata().getUserMetadata().put(TweetStoreConstants.SENDER_NAME, "frank");
|
||||
|
@ -63,7 +64,7 @@ public class AddTweetsControllerTest {
|
|||
|
||||
public void testStoreTweets() throws IOException, InterruptedException, ExecutionException {
|
||||
String container = "container";
|
||||
Map<String, BlobStoreContext> contexts = createServices(container);
|
||||
Map<String, BlobStoreContext<?, ?>> contexts = createServices(container);
|
||||
|
||||
ServiceToStoredTweetStatuses function = new ServiceToStoredTweetStatuses(contexts, container);
|
||||
AddTweetsController controller = new AddTweetsController(contexts, function);
|
||||
|
|
|
@ -19,15 +19,16 @@
|
|||
package org.jclouds.demo.tweetstore.controller;
|
||||
|
||||
import static com.google.appengine.api.taskqueue.TaskOptions.Builder.withUrl;
|
||||
import static org.easymock.EasyMock.createMock;
|
||||
import static org.easymock.EasyMock.expect;
|
||||
import static org.easymock.classextension.EasyMock.createMock;
|
||||
import static org.easymock.classextension.EasyMock.replay;
|
||||
import static org.easymock.classextension.EasyMock.verify;
|
||||
import static org.easymock.EasyMock.replay;
|
||||
import static org.easymock.EasyMock.verify;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.blobstore.TransientApiMetadata;
|
||||
import org.testng.annotations.Test;
|
||||
|
||||
import com.google.appengine.api.taskqueue.Queue;
|
||||
|
@ -42,15 +43,16 @@ import com.google.common.collect.ImmutableMap;
|
|||
@Test(groups = "unit")
|
||||
public class EnqueueStoresControllerTest {
|
||||
|
||||
Map<String, BlobStoreContext> createBlobStores() {
|
||||
Map<String, BlobStoreContext> contexts = ImmutableMap.of(
|
||||
"test1", new BlobStoreContextFactory().createContext("transient", "dummy", "dummy"),
|
||||
"test2", new BlobStoreContextFactory().createContext("transient", "dummy", "dummy"));
|
||||
Map<String, BlobStoreContext<?, ?>> createBlobStores() {
|
||||
TransientApiMetadata transientApiMetadata = TransientApiMetadata.builder().build();
|
||||
Map<String, BlobStoreContext<?, ?>> contexts = ImmutableMap.<String, BlobStoreContext<?, ?>>of(
|
||||
"test1", BlobStoreContextBuilder.newBuilder(transientApiMetadata).build(),
|
||||
"test2", BlobStoreContextBuilder.newBuilder(transientApiMetadata).build());
|
||||
return contexts;
|
||||
}
|
||||
|
||||
public void testEnqueueStores() {
|
||||
Map<String, BlobStoreContext> stores = createBlobStores();
|
||||
Map<String, BlobStoreContext<?, ?>> stores = createBlobStores();
|
||||
Queue taskQueue = createMock(Queue.class);
|
||||
EnqueueStoresController function = new EnqueueStoresController(stores, taskQueue);
|
||||
|
||||
|
|
|
@ -18,10 +18,10 @@
|
|||
*/
|
||||
package org.jclouds.demo.tweetstore.controller;
|
||||
|
||||
import static org.easymock.EasyMock.createMock;
|
||||
import static org.easymock.EasyMock.expect;
|
||||
import static org.easymock.classextension.EasyMock.createMock;
|
||||
import static org.easymock.classextension.EasyMock.replay;
|
||||
import static org.easymock.classextension.EasyMock.verify;
|
||||
import static org.easymock.EasyMock.replay;
|
||||
import static org.easymock.EasyMock.verify;
|
||||
import static org.jclouds.util.Strings2.toStringAndClose;
|
||||
import static org.testng.Assert.assertEquals;
|
||||
|
||||
|
@ -32,7 +32,8 @@ import java.util.concurrent.ExecutionException;
|
|||
|
||||
import org.jclouds.blobstore.BlobMap;
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.blobstore.TransientApiMetadata;
|
||||
import org.jclouds.blobstore.domain.Blob;
|
||||
import org.jclouds.demo.tweetstore.reference.TweetStoreConstants;
|
||||
import org.testng.annotations.Test;
|
||||
|
@ -56,18 +57,19 @@ public class StoreTweetsControllerTest {
|
|||
return createMock(Twitter.class);
|
||||
}
|
||||
|
||||
Map<String, BlobStoreContext> createBlobStores() throws InterruptedException, ExecutionException {
|
||||
Map<String, BlobStoreContext> contexts = ImmutableMap.<String, BlobStoreContext> of("test1",
|
||||
new BlobStoreContextFactory().createContext("transient", "dummy", "dummy"), "test2",
|
||||
new BlobStoreContextFactory().createContext("transient", "dummy", "dummy"));
|
||||
for (BlobStoreContext blobstore : contexts.values()) {
|
||||
Map<String, BlobStoreContext<?, ?>> createBlobStores() throws InterruptedException, ExecutionException {
|
||||
TransientApiMetadata transientApiMetadata = TransientApiMetadata.builder().build();
|
||||
Map<String, BlobStoreContext<?, ?>> contexts = ImmutableMap.<String, BlobStoreContext<?, ?>>of(
|
||||
"test1", BlobStoreContextBuilder.newBuilder(transientApiMetadata).build(),
|
||||
"test2", BlobStoreContextBuilder.newBuilder(transientApiMetadata).build());
|
||||
for (BlobStoreContext<?, ?> blobstore : contexts.values()) {
|
||||
blobstore.getAsyncBlobStore().createContainerInLocation(null, "favo").get();
|
||||
}
|
||||
return contexts;
|
||||
}
|
||||
|
||||
public void testStoreTweets() throws IOException, InterruptedException, ExecutionException {
|
||||
Map<String, BlobStoreContext> stores = createBlobStores();
|
||||
Map<String, BlobStoreContext<?, ?>> stores = createBlobStores();
|
||||
StoreTweetsController function = new StoreTweetsController(stores, "favo", createTwitter());
|
||||
|
||||
User frank = createMock(User.class);
|
||||
|
@ -99,7 +101,7 @@ public class StoreTweetsControllerTest {
|
|||
verify(jimmy);
|
||||
verify(jimmyStatus);
|
||||
|
||||
for (Entry<String, BlobStoreContext> entry : stores.entrySet()) {
|
||||
for (Entry<String, BlobStoreContext<?, ?>> entry : stores.entrySet()) {
|
||||
BlobMap map = entry.getValue().createBlobMap("favo");
|
||||
Blob frankBlob = map.get("1");
|
||||
assertEquals(frankBlob.getMetadata().getName(), "1");
|
||||
|
|
|
@ -25,7 +25,8 @@ import java.util.concurrent.ExecutionException;
|
|||
|
||||
import org.jclouds.blobstore.BlobMap;
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.blobstore.TransientApiMetadata;
|
||||
import org.jclouds.blobstore.domain.Blob;
|
||||
import org.jclouds.demo.tweetstore.domain.StoredTweetStatus;
|
||||
import org.jclouds.demo.tweetstore.reference.TweetStoreConstants;
|
||||
|
@ -40,8 +41,8 @@ import org.testng.annotations.Test;
|
|||
public class KeyToStoredTweetStatusTest {
|
||||
|
||||
BlobMap createMap() throws InterruptedException, ExecutionException {
|
||||
BlobStoreContext context = new BlobStoreContextFactory().createContext("transient", "dummy",
|
||||
"dummy");
|
||||
BlobStoreContext<?, ?> context =
|
||||
BlobStoreContextBuilder.newBuilder(TransientApiMetadata.builder().build()).build();
|
||||
context.getBlobStore().createContainerInLocation(null, "test1");
|
||||
return context.createBlobMap("test1");
|
||||
}
|
||||
|
|
|
@ -25,7 +25,8 @@ import java.util.Map;
|
|||
import java.util.concurrent.ExecutionException;
|
||||
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.blobstore.TransientApiMetadata;
|
||||
import org.jclouds.blobstore.domain.Blob;
|
||||
import org.jclouds.demo.tweetstore.domain.StoredTweetStatus;
|
||||
import org.jclouds.demo.tweetstore.reference.TweetStoreConstants;
|
||||
|
@ -42,12 +43,12 @@ import com.google.common.collect.Iterables;
|
|||
@Test(groups = "unit")
|
||||
public class ServiceToStoredTweetStatusesTest {
|
||||
|
||||
Map<String, BlobStoreContext> createServices(String container) throws InterruptedException,
|
||||
Map<String, BlobStoreContext<?, ?>> createServices(String container) throws InterruptedException,
|
||||
ExecutionException {
|
||||
Map<String, BlobStoreContext> services = Maps.newHashMap();
|
||||
Map<String, BlobStoreContext<?, ?>> services = Maps.newHashMap();
|
||||
TransientApiMetadata transientApiMetadata = TransientApiMetadata.builder().build();
|
||||
for (String name : new String[] { "1", "2" }) {
|
||||
BlobStoreContext context = new BlobStoreContextFactory().createContext("transient",
|
||||
"dummy", "dummy");
|
||||
BlobStoreContext<?, ?> context = BlobStoreContextBuilder.newBuilder(transientApiMetadata).build();
|
||||
context.getAsyncBlobStore().createContainerInLocation(null, container).get();
|
||||
Blob blob = context.getAsyncBlobStore().blobBuilder("1").build();
|
||||
blob.getMetadata().getUserMetadata().put(TweetStoreConstants.SENDER_NAME, "frank");
|
||||
|
@ -60,7 +61,7 @@ public class ServiceToStoredTweetStatusesTest {
|
|||
|
||||
public void testStoreTweets() throws IOException, InterruptedException, ExecutionException {
|
||||
String container = "container";
|
||||
Map<String, BlobStoreContext> contexts = createServices(container);
|
||||
Map<String, BlobStoreContext<?, ?>> contexts = createServices(container);
|
||||
|
||||
ServiceToStoredTweetStatuses function = new ServiceToStoredTweetStatuses(contexts, container);
|
||||
|
||||
|
|
|
@ -38,7 +38,7 @@ import java.util.concurrent.ExecutionException;
|
|||
import java.util.concurrent.TimeoutException;
|
||||
|
||||
import org.jclouds.blobstore.BlobStoreContext;
|
||||
import org.jclouds.blobstore.BlobStoreContextFactory;
|
||||
import org.jclouds.blobstore.BlobStoreContextBuilder;
|
||||
import org.jclouds.demo.tweetstore.config.SpringServletConfig;
|
||||
import org.jclouds.demo.tweetstore.controller.StoreTweetsController;
|
||||
import org.jclouds.logging.log4j.config.Log4JLoggingModule;
|
||||
|
@ -73,7 +73,7 @@ public class TweetStoreLiveTest {
|
|||
|
||||
GoogleDevServer server;
|
||||
private URL url;
|
||||
private Map<String, BlobStoreContext> contexts;
|
||||
private Map<String, BlobStoreContext<?, ?>> contexts;
|
||||
private String container;
|
||||
|
||||
private static final Iterable<String> blobstores =
|
||||
|
@ -95,13 +95,13 @@ public class TweetStoreLiveTest {
|
|||
// example of an ad-hoc client configuration
|
||||
addConfigurationForTwitter(props);
|
||||
|
||||
final BlobStoreContextFactory factory = new BlobStoreContextFactory();
|
||||
// for testing, capture logs.
|
||||
final Set<Module> wiring = ImmutableSet.<Module> of(new Log4JLoggingModule());
|
||||
this.contexts = Maps.newConcurrentMap();
|
||||
|
||||
for (String provider : blobstores) {
|
||||
contexts.put(provider, factory.createContext(provider, wiring, props));
|
||||
contexts.put(provider, BlobStoreContextBuilder.newBuilder(provider)
|
||||
.modules(wiring).overrides(props).build());
|
||||
}
|
||||
|
||||
Configuration conf = new ConfigurationBuilder()
|
||||
|
@ -116,7 +116,7 @@ public class TweetStoreLiveTest {
|
|||
ResponseList<Status> statuses = client.getMentions();
|
||||
|
||||
boolean deleted = false;
|
||||
for (BlobStoreContext context : contexts.values()) {
|
||||
for (BlobStoreContext<?, ?> context : contexts.values()) {
|
||||
if (context.getBlobStore().containerExists(container)) {
|
||||
System.err.printf("deleting container %s at %s%n", container, context.getProviderSpecificContext()
|
||||
.getEndpoint());
|
||||
|
@ -128,7 +128,7 @@ public class TweetStoreLiveTest {
|
|||
System.err.println("sleeping 60 seconds to allow containers to clear");
|
||||
Thread.sleep(60000);
|
||||
}
|
||||
for (BlobStoreContext context : contexts.values()) {
|
||||
for (BlobStoreContext<?, ?> context : contexts.values()) {
|
||||
System.err.printf("creating container %s at %s%n", container, context.getProviderSpecificContext()
|
||||
.getEndpoint());
|
||||
context.getBlobStore().createContainerInLocation(null, container);
|
||||
|
@ -138,7 +138,7 @@ public class TweetStoreLiveTest {
|
|||
Thread.sleep(5000);
|
||||
}
|
||||
|
||||
for (Entry<String, BlobStoreContext> entry : contexts.entrySet()) {
|
||||
for (Entry<String, BlobStoreContext<?, ?>> entry : contexts.entrySet()) {
|
||||
System.err.printf("filling container %s at %s%n", container, entry.getKey());
|
||||
controller.addMyTweets(entry.getKey(), statuses);
|
||||
}
|
||||
|
@ -205,7 +205,7 @@ public class TweetStoreLiveTest {
|
|||
|
||||
System.err.println("sleeping 20 seconds to allow for eventual consistency delay");
|
||||
Thread.sleep(20000);
|
||||
for (BlobStoreContext context : contexts.values()) {
|
||||
for (BlobStoreContext<?, ?> context : contexts.values()) {
|
||||
assert context.createInputStreamMap(container).size() > 0 : context.getProviderSpecificContext().getEndpoint();
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue