From de82496aae307d71b49524da2fb024fad73ad41e Mon Sep 17 00:00:00 2001
From: Andrew Gaul <gaul@maginatics.com>
Date: Sun, 4 Nov 2012 18:11:12 -0800
Subject: [PATCH] Ensure simple boolean expressions via Checkstyle

---
 .../java/org/jclouds/s3/filters/RequestAuthorizeSignature.java  | 2 +-
 .../main/java/org/jclouds/virtualbox/functions/NodeCreator.java | 2 +-
 resources/checkstyle.xml                                        | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignature.java b/apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignature.java
index 0fce627fb3..f47afe965f 100644
--- a/apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignature.java
+++ b/apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignature.java
@@ -242,7 +242,7 @@ public class RequestAuthorizeSignature implements HttpRequestFilter, RequestSign
          char separator = '?';
          for (String paramName : Ordering.natural().sortedCopy(params.keySet())) {
             // Skip any parameters that aren't part of the canonical signed string
-            if (SIGNED_PARAMETERS.contains(paramName) == false)
+            if (!SIGNED_PARAMETERS.contains(paramName))
                continue;
             toSign.append(separator).append(paramName);
             String paramValue = get(params.get(paramName), 0);
diff --git a/labs/virtualbox/src/main/java/org/jclouds/virtualbox/functions/NodeCreator.java b/labs/virtualbox/src/main/java/org/jclouds/virtualbox/functions/NodeCreator.java
index cc4de802ac..69d0510032 100644
--- a/labs/virtualbox/src/main/java/org/jclouds/virtualbox/functions/NodeCreator.java
+++ b/labs/virtualbox/src/main/java/org/jclouds/virtualbox/functions/NodeCreator.java
@@ -160,7 +160,7 @@ public class NodeCreator implements Function<NodeSpec, NodeAndInitialCredentials
        machineUtils.runScriptOnNode(partialNodeMetadata, new DeleteGShadowLock(), RunScriptOptions.NONE);
 
       if(optionalNatIfaceCard.isPresent())
-         checkState(networkUtils.enableNetworkInterface(partialNodeMetadata, optionalNatIfaceCard.get()) == true, 
+         checkState(networkUtils.enableNetworkInterface(partialNodeMetadata, optionalNatIfaceCard.get()),
          "cannot enable Nat Interface");
       
       LoginCredentials credentials = partialNodeMetadata.getCredentials();
diff --git a/resources/checkstyle.xml b/resources/checkstyle.xml
index 363dd7e91b..149aaeb9f9 100644
--- a/resources/checkstyle.xml
+++ b/resources/checkstyle.xml
@@ -13,6 +13,7 @@
         </module>
         <module name="ModifierOrder"/>
         <module name="MultipleVariableDeclarations"/>
+        <module name="SimplifyBooleanExpression"/>
         <module name="UnusedImports"/>
     </module>
     <module name="RegexpMultiline">