mirror of https://github.com/apache/jclouds.git
removed redundant error logging
(was done by caller and also in propagate method; have removed from caller; might be better to remove from propagate, and leave at discretion of caller, because some places the "error" might be benign, and shouldn't log error at all, or not at >=WARN, but rather just leave at discretion of caller)
This commit is contained in:
parent
f55e4a5d3e
commit
4d11d4ef05
|
@ -229,8 +229,7 @@ public class SshjSshClient implements SshClient {
|
|||
logger.warn(from, "<< (%s) error closing connection", toString());
|
||||
}
|
||||
if (i + 1 == sshRetries) {
|
||||
logger.error(from, "<< " + errorMessage + ": out of retries %d", sshRetries);
|
||||
throw propagate(from, errorMessage);
|
||||
throw propagate(from, errorMessage+" (out of retries - max "+sshRetries+")");
|
||||
} else if (shouldRetry(from) ||
|
||||
(Throwables2.getFirstThrowableOfType(from, IllegalStateException.class) != null)) {
|
||||
logger.warn(from, "<< " + errorMessage + ": " + from.getMessage());
|
||||
|
@ -239,8 +238,7 @@ public class SshjSshClient implements SshClient {
|
|||
connect();
|
||||
continue;
|
||||
} else {
|
||||
logger.error(from, "<< " + errorMessage + ": exception not retryable");
|
||||
throw propagate(from, errorMessage);
|
||||
throw propagate(from, errorMessage+" (not retryable)");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue