Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed redundant error logging 

(was done by caller and also in propagate method; have removed from caller;
might be better to remove from propagate, and leave at discretion of caller,
because some places the "error" might be benign, and shouldn't log error at all,
or not at >=WARN, but rather just leave at discretion of caller)
This commit is contained in:
Alex Heneveld 2011-11-30 16:03:23 +00:00
parent f55e4a5d3e
commit 4d11d4ef05
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/sshj/src/main/java/org/jclouds/sshj/SshjSshClient.java
View File

@ -229,8 +229,7 @@ public class SshjSshClient implements SshClient {
logger.warn(from, "<< (%s) error closing connection", toString()); logger.warn(from, "<< (%s) error closing connection", toString());
} }
if (i + 1 == sshRetries) { if (i + 1 == sshRetries) {
logger.error(from, "<< " + errorMessage + ": out of retries %d", sshRetries); throw propagate(from, errorMessage+" (out of retries - max "+sshRetries+")");
throw propagate(from, errorMessage);
} else if (shouldRetry(from) || } else if (shouldRetry(from) ||
(Throwables2.getFirstThrowableOfType(from, IllegalStateException.class) != null)) { (Throwables2.getFirstThrowableOfType(from, IllegalStateException.class) != null)) {
logger.warn(from, "<< " + errorMessage + ": " + from.getMessage()); logger.warn(from, "<< " + errorMessage + ": " + from.getMessage());
@ -239,8 +238,7 @@ public class SshjSshClient implements SshClient {
connect(); connect();
continue; continue;
} else { } else {
logger.error(from, "<< " + errorMessage + ": exception not retryable"); throw propagate(from, errorMessage+" (not retryable)");
throw propagate(from, errorMessage);
} }
} }
} }