Address and suppress FindBugs warnings

This commit is contained in:
Andrew Gaul 2015-03-30 20:20:14 -07:00
parent e581552583
commit 4f566d3b6e
4 changed files with 2 additions and 3 deletions

View File

@ -133,7 +133,7 @@ public class ServerInfoToNodeMetadata implements Function<ServerInfo, NodeMetada
} catch (UncheckedExecutionException e) {
logger.warn(e, "error finding drive %s: %s", input.getDriveUuid(), e.getMessage());
}
return new VolumeBuilder().durable(true).type(Volume.Type.NAS).build();
return builder.durable(true).type(Volume.Type.NAS).build();
}
}

View File

@ -241,7 +241,6 @@ public class FilesystemStorageStrategyImpl implements LocalStorageStrategy {
BlobBuilder builder = blobBuilders.get();
builder.name(key);
File file = getFileForBlobKey(container, key);
Path path = file.toPath();
ByteSource byteSource;
if (getDirectoryBlobSuffix(key) != null) {

View File

@ -31,7 +31,6 @@ public class ByteArrayPayload extends BasePayload<byte[]> {
super(content);
getContentMetadata().setContentLength(Long.valueOf(checkNotNull(content, "content").length));
getContentMetadata().setContentMD5(md5);
checkArgument(content.length >= 0, "length cannot me negative");
}
/**

View File

@ -967,6 +967,7 @@
EqualsOperandShouldHaveClassCompatibleWithThis,
FindBadCast2,
FindHEmismatch,
FindMaskedFields,
FindNullDeref,
FindReturnRef,
FindUnsatisfiedObligation,