Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes issue with AzureBlobStore blockid incorrectly using base64url encoding

This commit is contained in:
twickline 2024-08-02 13:35:56 -07:00 committed by Andrew Gaul
parent ddfb2ea77f
commit 6ef293dfd3
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobStore.java
View File

@ -440,9 +440,10 @@ public class AzureBlobStore extends BaseBlobStore {
return sync.putBlockList(mpu.containerName(), azureBlob, blocks.build());
}
static String makeBlockId(int partNumber) {
return BaseEncoding.base64Url().encode(Ints.toByteArray(partNumber));
}
static String makeBlockId(int partNumber) {
// Azure expects a base64-encoded string ONLY. It does not support base64url encoding.
return BaseEncoding.base64().encode(Ints.toByteArray(partNumber));
}
@Override
public MultipartPart uploadMultipartPart(MultipartUpload mpu, int partNumber, Payload payload) {

2
providers/azureblob/src/test/java/org/jclouds/azureblob/blobstore/AzureBlobStoreTest.java
View File

@ -28,7 +28,7 @@ import java.util.regex.Pattern;
@Test(groups = "unit", testName = "AzureBlobStore")
public class AzureBlobStoreTest {
private static final Pattern VALIDATION_PATTERN = Pattern.compile("[a-zA-Z0-9\\-_=]*");
private static final Pattern VALIDATION_PATTERN = Pattern.compile("^[a-zA-Z0-9+/=]*$");
public void testMakeBlockId() {
// how can i achieve something like a junit5 parametrized test in testng?