Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removed create configuration API call - not useful

This commit is contained in:
andreisavu 2012-01-11 02:06:18 +02:00
parent 00e7657a09
commit 77ebfe8f1e
3 changed files with 2 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/GlobalConfigurationAsyncClient.java
View File

@ -69,19 +69,4 @@ public interface GlobalConfigurationAsyncClient extends ConfigurationAsyncClient
@ExceptionParser(ReturnNullOnNotFoundOr404.class)
ListenableFuture<ConfigurationEntry> updateConfigurationEntry(
@QueryParam("name") String name, @QueryParam("value") String value);
/**
* @see GlobalConfigurationClient#createConfigurationEntry
*/
@GET
@QueryParams(keys = "command", values = "createConfiguration")
@SelectJson("configuration")
@Consumes(MediaType.APPLICATION_JSON)
@ExceptionParser(ReturnNullOnNotFoundOr404.class)
ListenableFuture<ConfigurationEntry> createConfigurationEntry(@QueryParam("category")String category,
@QueryParam("component") String component, @QueryParam("instance") String instance,
@QueryParam("name") String name, @QueryParam("description") String description,
@QueryParam("value") String value);
}

21
apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/GlobalConfigurationClient.java
View File

@ -58,25 +58,4 @@ public interface GlobalConfigurationClient extends ConfigurationClient {
* the updated configuration value
*/
ConfigurationEntry updateConfigurationEntry(String name, String value);
/**
* Create a new configuration value
*
* @param category
* the component category
* @param component
* the component of the configuration
* @param instance
* the instance of the configuration
* @param name
* the name of the configuration
* @param description
* the description of the configuration
* @param value
* the value of the configuration
* @return
*/
ConfigurationEntry createConfigurationEntry(String category, String component,
String instance, String name, String description, String value );
}

13
apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/GlobalConfigurationClientLiveTest.java
View File

@ -32,7 +32,6 @@ import java.util.Set;
import static com.google.common.collect.Iterables.getOnlyElement;
import static org.jclouds.cloudstack.options.ListConfigurationEntriesOptions.Builder.name;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.fail;
/**
* Tests behavior of {@code GlobalConfigurationClient}
@ -80,19 +79,9 @@ public class GlobalConfigurationClientLiveTest extends BaseCloudStackClientLiveT
.updateConfigurationEntry("expunge.delay", "" + expungeDelay);
}
@Test(enabled = false)
public void testCreateConfigurationEntry() {
assert globalAdminEnabled;
ConfigurationEntry result = globalAdminClient.getConfigurationClient()
.createConfigurationEntry("Advanced", "component",
"instance", prefix + "-jclouds", "description", "jclouds");
checkConfigurationEntry(result);
}
private void checkConfigurationEntry(ConfigurationEntry entry) {
assertEquals(entry, getEntryByName(globalAdminClient.getConfigurationClient()
.listConfigurationEntries(), entry.getName()));
.listConfigurationEntries(name(entry.getName())), entry.getName()));
assert entry.getCategory() != null : entry;
assert entry.getDescription() != null : entry;
assert entry.getName() != null : entry;