From 7c3683e060bdad410b375109afa68884d3a2c251 Mon Sep 17 00:00:00 2001 From: Matt Stephenson Date: Thu, 21 Mar 2013 15:18:15 -0700 Subject: [PATCH] Fix missing final keyword for private member variables in cloudloadbalancers api. --- .../v1/domain/AccountUsage.java | 10 +++---- .../v1/domain/HistoricalUsage.java | 6 ++-- .../v1/domain/LoadBalancerInfo.java | 6 ++-- .../v1/domain/LoadBalancerStats.java | 12 ++++---- .../v1/domain/LoadBalancerUsage.java | 28 +++++++++---------- .../v1/domain/Metadata.java | 4 +-- .../v1/domain/Protocol.java | 4 +-- .../v1/domain/UpdateLoadBalancer.java | 12 ++++---- .../v1/domain/UpdateNode.java | 6 ++-- .../v1/domain/VirtualIP.java | 4 +-- .../v1/domain/VirtualIPWithId.java | 4 +-- 11 files changed, 48 insertions(+), 48 deletions(-) diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/AccountUsage.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/AccountUsage.java index 2c65f2bdef..3760786e5d 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/AccountUsage.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/AccountUsage.java @@ -30,11 +30,11 @@ import com.google.common.base.Optional; * @author Everett Toews */ public final class AccountUsage { - private int numPublicVIPs; - private int numServiceNetVIPs; - private int numLoadBalancers; - private Date startTime; - private Optional endTime; + private final int numPublicVIPs; + private final int numServiceNetVIPs; + private final int numLoadBalancers; + private final Date startTime; + private final Optional endTime; @ConstructorProperties({ "numPublicVips", "numServicenetVips", "numLoadBalancers", "startTime", "endTime" }) protected AccountUsage(int numPublicVIPs, int numServiceNetVIPs, int numLoadBalancers, Date startTime, Date endTime) { diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/HistoricalUsage.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/HistoricalUsage.java index 92eaa9f85a..926a14ed59 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/HistoricalUsage.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/HistoricalUsage.java @@ -30,9 +30,9 @@ import com.google.common.collect.Iterables; * @author Everett Toews */ public final class HistoricalUsage { - private int accountId; - private Map> accountUsage; - private Iterable loadBalancerUsages; + private final int accountId; + private final Map> accountUsage; + private final Iterable loadBalancerUsages; @ConstructorProperties({ "accountId", "accountUsage", "loadBalancerUsages" }) protected HistoricalUsage(int accountId, Map> accountUsage, diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerInfo.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerInfo.java index 8016a5bbff..609965c6d5 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerInfo.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerInfo.java @@ -28,9 +28,9 @@ import com.google.common.base.Objects; * @author Everett Toews */ public final class LoadBalancerInfo { - private int loadBalancerId; - private String loadBalancerName; - private Iterable loadBalancerUsageRecords; + private final int loadBalancerId; + private final String loadBalancerName; + private final Iterable loadBalancerUsageRecords; @ConstructorProperties({ "loadBalancerId", "loadBalancerName", "loadBalancerUsageRecords" }) protected LoadBalancerInfo(int id, String name, Iterable loadBalancerUsageRecords) { diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerStats.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerStats.java index 645520679f..ec59d03dd8 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerStats.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerStats.java @@ -26,12 +26,12 @@ import com.google.common.base.Objects; * @author Everett Toews */ public final class LoadBalancerStats { - private int connectTimeOut; - private int connectError; - private int connectFailure; - private int dataTimedOut; - private int keepAliveTimedOut; - private int maxConn; + private final int connectTimeOut; + private final int connectError; + private final int connectFailure; + private final int dataTimedOut; + private final int keepAliveTimedOut; + private final int maxConn; @ConstructorProperties({ "connectTimeOut", "connectError", "connectFailure", "dataTimedOut", "keepAliveTimedOut", "maxConn" }) diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerUsage.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerUsage.java index 8ea867992b..a7538b89f8 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerUsage.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/LoadBalancerUsage.java @@ -32,20 +32,20 @@ import com.google.common.base.Optional; * @author Everett Toews */ public final class LoadBalancerUsage { - private int id; - private float averageNumConnections; - private float averageNumConnectionsSsl; - private int incomingTransferInBytes; - private int outgoingTransferInBytes; - private int incomingTransferSslInBytes; - private int outgoingTransferSslInBytes; - private int numVIPs; - private int numPolls; - private Date startTime; - private Date endTime; - private VirtualIP.Type vipType; - private String sslMode; - private Optional eventType; + private final int id; + private final float averageNumConnections; + private final float averageNumConnectionsSsl; + private final int incomingTransferInBytes; + private final int outgoingTransferInBytes; + private final int incomingTransferSslInBytes; + private final int outgoingTransferSslInBytes; + private final int numVIPs; + private final int numPolls; + private final Date startTime; + private final Date endTime; + private final VirtualIP.Type vipType; + private final String sslMode; + private final Optional eventType; @ConstructorProperties({ "id", "averageNumConnections", "averageNumConnectionsSsl", "incomingTransfer", "outgoingTransfer", "incomingTransferSsl", "outgoingTransferSsl", "numVips", "numPolls", "startTime", diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Metadata.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Metadata.java index ce7acf3719..39fde46d77 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Metadata.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Metadata.java @@ -32,8 +32,8 @@ import com.google.common.collect.Sets; * @author Everett Toews */ public class Metadata extends ForwardingMap { - private Map metadata = Maps.newHashMap(); - private Map keyToId = Maps.newHashMap(); + private final Map metadata = Maps.newHashMap(); + private final Map keyToId = Maps.newHashMap(); public Metadata(Metadata metadata) { super(); diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Protocol.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Protocol.java index ea216cafce..dc2df9f017 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Protocol.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/Protocol.java @@ -28,8 +28,8 @@ import com.google.common.base.Objects; * @author Everett Toews */ public final class Protocol { - private String name; - private int port; + private final String name; + private final int port; @ConstructorProperties({ "name", "port" }) protected Protocol(String name, int port) { diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateLoadBalancer.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateLoadBalancer.java index fe285c63d0..bfee9c1a8b 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateLoadBalancer.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateLoadBalancer.java @@ -30,12 +30,12 @@ import com.google.common.base.Objects.ToStringHelper; * @author Everett Toews */ public class UpdateLoadBalancer { - private String name; - private String protocol; - private Integer port; - private Algorithm algorithm; - private Integer timeout; - private Boolean halfClosed; + private final String name; + private final String protocol; + private final Integer port; + private final Algorithm algorithm; + private final Integer timeout; + private final Boolean halfClosed; protected UpdateLoadBalancer(String name, String protocol, Integer port, Algorithm algorithm, Integer timeout, Boolean halfClosed) { diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateNode.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateNode.java index 65c435c6ee..3b1fbf1aa1 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateNode.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/UpdateNode.java @@ -31,9 +31,9 @@ import com.google.common.base.Objects.ToStringHelper; * @author Everett Toews */ public class UpdateNode { - private Condition condition; - private Type type; - private Integer weight; + private final Condition condition; + private final Type type; + private final Integer weight; protected UpdateNode(Condition condition, Type type, Integer weight) { this.condition = condition; diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIP.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIP.java index 8fa1fa9bd5..482274a6a2 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIP.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIP.java @@ -32,8 +32,8 @@ import com.google.common.base.Objects.ToStringHelper; */ public class VirtualIP { - private Type type; - private IPVersion ipVersion; + private final Type type; + private final IPVersion ipVersion; /** * Use this method to easily create virtual IPs. Only public IPv6 virtual IPs can be created. diff --git a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIPWithId.java b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIPWithId.java index b003b75c30..742829252a 100644 --- a/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIPWithId.java +++ b/apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/domain/VirtualIPWithId.java @@ -30,8 +30,8 @@ import com.google.common.base.Objects.ToStringHelper; */ public class VirtualIPWithId extends VirtualIP { - private int id; - private String address; + private final int id; + private final String address; public VirtualIPWithId(Type type, IPVersion ipVersion, int id, String address) { super(type, ipVersion);