Merge pull request #1482 from rackspace/1.6.x

Fix missing final keyword for private member variables in cloudloadbalancers api.
This commit is contained in:
Everett Toews 2013-04-02 14:36:44 -07:00
commit 789fc2c79e
11 changed files with 48 additions and 48 deletions

View File

@ -30,11 +30,11 @@ import com.google.common.base.Optional;
* @author Everett Toews * @author Everett Toews
*/ */
public final class AccountUsage { public final class AccountUsage {
private int numPublicVIPs; private final int numPublicVIPs;
private int numServiceNetVIPs; private final int numServiceNetVIPs;
private int numLoadBalancers; private final int numLoadBalancers;
private Date startTime; private final Date startTime;
private Optional<Date> endTime; private final Optional<Date> endTime;
@ConstructorProperties({ "numPublicVips", "numServicenetVips", "numLoadBalancers", "startTime", "endTime" }) @ConstructorProperties({ "numPublicVips", "numServicenetVips", "numLoadBalancers", "startTime", "endTime" })
protected AccountUsage(int numPublicVIPs, int numServiceNetVIPs, int numLoadBalancers, Date startTime, Date endTime) { protected AccountUsage(int numPublicVIPs, int numServiceNetVIPs, int numLoadBalancers, Date startTime, Date endTime) {

View File

@ -30,9 +30,9 @@ import com.google.common.collect.Iterables;
* @author Everett Toews * @author Everett Toews
*/ */
public final class HistoricalUsage { public final class HistoricalUsage {
private int accountId; private final int accountId;
private Map<String, Iterable<AccountUsage>> accountUsage; private final Map<String, Iterable<AccountUsage>> accountUsage;
private Iterable<LoadBalancerInfo> loadBalancerUsages; private final Iterable<LoadBalancerInfo> loadBalancerUsages;
@ConstructorProperties({ "accountId", "accountUsage", "loadBalancerUsages" }) @ConstructorProperties({ "accountId", "accountUsage", "loadBalancerUsages" })
protected HistoricalUsage(int accountId, Map<String, Iterable<AccountUsage>> accountUsage, protected HistoricalUsage(int accountId, Map<String, Iterable<AccountUsage>> accountUsage,

View File

@ -28,9 +28,9 @@ import com.google.common.base.Objects;
* @author Everett Toews * @author Everett Toews
*/ */
public final class LoadBalancerInfo { public final class LoadBalancerInfo {
private int loadBalancerId; private final int loadBalancerId;
private String loadBalancerName; private final String loadBalancerName;
private Iterable<LoadBalancerUsage> loadBalancerUsageRecords; private final Iterable<LoadBalancerUsage> loadBalancerUsageRecords;
@ConstructorProperties({ "loadBalancerId", "loadBalancerName", "loadBalancerUsageRecords" }) @ConstructorProperties({ "loadBalancerId", "loadBalancerName", "loadBalancerUsageRecords" })
protected LoadBalancerInfo(int id, String name, Iterable<LoadBalancerUsage> loadBalancerUsageRecords) { protected LoadBalancerInfo(int id, String name, Iterable<LoadBalancerUsage> loadBalancerUsageRecords) {

View File

@ -26,12 +26,12 @@ import com.google.common.base.Objects;
* @author Everett Toews * @author Everett Toews
*/ */
public final class LoadBalancerStats { public final class LoadBalancerStats {
private int connectTimeOut; private final int connectTimeOut;
private int connectError; private final int connectError;
private int connectFailure; private final int connectFailure;
private int dataTimedOut; private final int dataTimedOut;
private int keepAliveTimedOut; private final int keepAliveTimedOut;
private int maxConn; private final int maxConn;
@ConstructorProperties({ "connectTimeOut", "connectError", "connectFailure", "dataTimedOut", "keepAliveTimedOut", @ConstructorProperties({ "connectTimeOut", "connectError", "connectFailure", "dataTimedOut", "keepAliveTimedOut",
"maxConn" }) "maxConn" })

View File

@ -32,20 +32,20 @@ import com.google.common.base.Optional;
* @author Everett Toews * @author Everett Toews
*/ */
public final class LoadBalancerUsage { public final class LoadBalancerUsage {
private int id; private final int id;
private float averageNumConnections; private final float averageNumConnections;
private float averageNumConnectionsSsl; private final float averageNumConnectionsSsl;
private int incomingTransferInBytes; private final int incomingTransferInBytes;
private int outgoingTransferInBytes; private final int outgoingTransferInBytes;
private int incomingTransferSslInBytes; private final int incomingTransferSslInBytes;
private int outgoingTransferSslInBytes; private final int outgoingTransferSslInBytes;
private int numVIPs; private final int numVIPs;
private int numPolls; private final int numPolls;
private Date startTime; private final Date startTime;
private Date endTime; private final Date endTime;
private VirtualIP.Type vipType; private final VirtualIP.Type vipType;
private String sslMode; private final String sslMode;
private Optional<String> eventType; private final Optional<String> eventType;
@ConstructorProperties({ "id", "averageNumConnections", "averageNumConnectionsSsl", "incomingTransfer", @ConstructorProperties({ "id", "averageNumConnections", "averageNumConnectionsSsl", "incomingTransfer",
"outgoingTransfer", "incomingTransferSsl", "outgoingTransferSsl", "numVips", "numPolls", "startTime", "outgoingTransfer", "incomingTransferSsl", "outgoingTransferSsl", "numVips", "numPolls", "startTime",

View File

@ -32,8 +32,8 @@ import com.google.common.collect.Sets;
* @author Everett Toews * @author Everett Toews
*/ */
public class Metadata extends ForwardingMap<String, String> { public class Metadata extends ForwardingMap<String, String> {
private Map<String, String> metadata = Maps.newHashMap(); private final Map<String, String> metadata = Maps.newHashMap();
private Map<String, Integer> keyToId = Maps.newHashMap(); private final Map<String, Integer> keyToId = Maps.newHashMap();
public Metadata(Metadata metadata) { public Metadata(Metadata metadata) {
super(); super();

View File

@ -28,8 +28,8 @@ import com.google.common.base.Objects;
* @author Everett Toews * @author Everett Toews
*/ */
public final class Protocol { public final class Protocol {
private String name; private final String name;
private int port; private final int port;
@ConstructorProperties({ "name", "port" }) @ConstructorProperties({ "name", "port" })
protected Protocol(String name, int port) { protected Protocol(String name, int port) {

View File

@ -30,12 +30,12 @@ import com.google.common.base.Objects.ToStringHelper;
* @author Everett Toews * @author Everett Toews
*/ */
public class UpdateLoadBalancer { public class UpdateLoadBalancer {
private String name; private final String name;
private String protocol; private final String protocol;
private Integer port; private final Integer port;
private Algorithm algorithm; private final Algorithm algorithm;
private Integer timeout; private final Integer timeout;
private Boolean halfClosed; private final Boolean halfClosed;
protected UpdateLoadBalancer(String name, String protocol, Integer port, Algorithm algorithm, Integer timeout, protected UpdateLoadBalancer(String name, String protocol, Integer port, Algorithm algorithm, Integer timeout,
Boolean halfClosed) { Boolean halfClosed) {

View File

@ -31,9 +31,9 @@ import com.google.common.base.Objects.ToStringHelper;
* @author Everett Toews * @author Everett Toews
*/ */
public class UpdateNode { public class UpdateNode {
private Condition condition; private final Condition condition;
private Type type; private final Type type;
private Integer weight; private final Integer weight;
protected UpdateNode(Condition condition, Type type, Integer weight) { protected UpdateNode(Condition condition, Type type, Integer weight) {
this.condition = condition; this.condition = condition;

View File

@ -32,8 +32,8 @@ import com.google.common.base.Objects.ToStringHelper;
*/ */
public class VirtualIP { public class VirtualIP {
private Type type; private final Type type;
private IPVersion ipVersion; private final IPVersion ipVersion;
/** /**
* Use this method to easily create virtual IPs. Only public IPv6 virtual IPs can be created. * Use this method to easily create virtual IPs. Only public IPv6 virtual IPs can be created.

View File

@ -30,8 +30,8 @@ import com.google.common.base.Objects.ToStringHelper;
*/ */
public class VirtualIPWithId extends VirtualIP { public class VirtualIPWithId extends VirtualIP {
private int id; private final int id;
private String address; private final String address;
public VirtualIPWithId(Type type, IPVersion ipVersion, int id, String address) { public VirtualIPWithId(Type type, IPVersion ipVersion, int id, String address) {
super(type, ipVersion); super(type, ipVersion);