Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #751 from richardcloudsoft/issue-1033 

DescribeSnapshotsResponseHandler bug parsing tags
This commit is contained in:
Adrian Cole 2012-07-25 10:13:28 -07:00
parent 17172a7d17 6c86b89d83
commit 899034097e
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
apis/ec2/src/main/java/org/jclouds/ec2/xml/DescribeSnapshotsResponseHandler.java
View File

@ -37,6 +37,7 @@ public class DescribeSnapshotsResponseHandler extends ParseSax.HandlerWithResult
private Set<Snapshot> snapshots = Sets.newLinkedHashSet(); private Set<Snapshot> snapshots = Sets.newLinkedHashSet();
private final SnapshotHandler snapshotHandler; private final SnapshotHandler snapshotHandler;
private int itemDepth = 0;
@Inject @Inject
public DescribeSnapshotsResponseHandler(SnapshotHandler snapshotHandler) { public DescribeSnapshotsResponseHandler(SnapshotHandler snapshotHandler) {
@ -50,13 +51,16 @@ public class DescribeSnapshotsResponseHandler extends ParseSax.HandlerWithResult
@Override @Override
public void startElement(String uri, String localName, String qName, Attributes attributes) public void startElement(String uri, String localName, String qName, Attributes attributes)
throws SAXException { throws SAXException {
itemDepth++;
snapshotHandler.startElement(uri, localName, qName, attributes); snapshotHandler.startElement(uri, localName, qName, attributes);
} }
@Override @Override
public void endElement(String uri, String localName, String qName) throws SAXException { public void endElement(String uri, String localName, String qName) throws SAXException {
snapshotHandler.endElement(uri, localName, qName); snapshotHandler.endElement(uri, localName, qName);
if (qName.equals("item")) { itemDepth--;
if (qName.equals("item") && itemDepth == 2) {
this.snapshots.add(snapshotHandler.getResult()); this.snapshots.add(snapshotHandler.getResult());
} }
} }

6
apis/ec2/src/test/resources/describe_snapshots.xml
View File

@ -9,6 +9,12 @@
<ownerId>218213537122</ownerId> <ownerId>218213537122</ownerId>
<volumeSize>10</volumeSize> <volumeSize>10</volumeSize>
<description>Daily Backup</description> <description>Daily Backup</description>
<tagSet>
<item>
<key>Name</key>
<value>example_name_tag</value>
</item>
</tagSet>
</item> </item>
</snapshotSet> </snapshotSet>
</DescribeSnapshotsResponse> </DescribeSnapshotsResponse>