diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineFallbacks.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineFallbacks.java index 573bca016b..4cdbad118b 100644 --- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineFallbacks.java +++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineFallbacks.java @@ -37,7 +37,7 @@ public final class GoogleComputeEngineFallbacks { } public static final class EmptyListPageOnNotFoundOr404 implements Fallback { @Override public ListPage createOrPropagate(Throwable t) throws Exception { - return valOnNotFoundOr404(ListPage.create(null, null, null), t); + return valOnNotFoundOr404(ListPage.create(null, null), t); } } } diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java index 0205df1b50..8d6610497f 100644 --- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java +++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java @@ -25,34 +25,26 @@ import org.jclouds.javax.annotation.Nullable; import com.google.common.collect.ForwardingList; -/** - * The collection returned from any listFirstPage() method. - */ +/** An immutable list that includes a token, if there is another page available. */ public final class ListPage extends ForwardingList { private final List items; private final String nextPageToken; - private final List prefixes; - public static ListPage create(List items, String nextPageToken, List prefixes) { - return new ListPage(items, nextPageToken, prefixes); + public static ListPage create(List items, String nextPageToken) { + return new ListPage(items, nextPageToken); } - @ConstructorProperties({ "items", "nextPageToken", "prefixes" }) - ListPage(List items, String nextPageToken, List prefixes) { + @ConstructorProperties({ "items", "nextPageToken" }) + ListPage(List items, String nextPageToken) { this.items = copyOf(items); this.nextPageToken = nextPageToken; - this.prefixes = copyOf(prefixes); } @Nullable public String nextPageToken() { return nextPageToken; } - public List prefixes() { - return prefixes; - } - @Override protected List delegate() { return items; } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java index 139e610f1d..bebe70065d 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java @@ -27,6 +27,8 @@ import org.jclouds.googlecomputeengine.options.HttpHealthCheckCreationOptions; import org.jclouds.googlecomputeengine.options.ListOptions; import org.testng.annotations.Test; +import com.google.common.collect.Iterables; + public class HttpHealthCheckApiLiveTest extends BaseGoogleComputeEngineApiLiveTest { private static final String HTTP_HEALTH_CHECK_NAME = "http-health-check-api-live-test"; @@ -69,7 +71,7 @@ public class HttpHealthCheckApiLiveTest extends BaseGoogleComputeEngineApiLiveTe public void testListHttpHealthCheck() { ListPage httpHealthCheck = api().list(new ListOptions.Builder() .filter("name eq " + HTTP_HEALTH_CHECK_NAME)); - assertEquals(httpHealthCheck.size(), 1); + assertEquals(Iterables.size(httpHealthCheck), 1); } @Test(groups = "live", dependsOnMethods = "testGetHttpHealthCheck") diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java index 83ef30adce..0e1a2f88a9 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java @@ -53,8 +53,7 @@ public class RegionOperationApiExpectTest extends BaseGoogleComputeEngineApiExpe private ListPage expectedList() { return ListPage.create( // ImmutableList.of(new ParseRegionOperationTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java index 52f2e825e5..124d062669 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java @@ -40,6 +40,7 @@ import org.testng.annotations.AfterClass; import org.testng.annotations.Test; import com.google.common.base.Predicate; +import com.google.common.collect.Iterables; public class TargetPoolApiLiveTest extends BaseGoogleComputeEngineApiLiveTest { @@ -205,10 +206,9 @@ public class TargetPoolApiLiveTest extends BaseGoogleComputeEngineApiLiveTest { @Test(groups = "live", dependsOnMethods = "testInsertTargetPool") public void testListTargetPool() { - ListPage targetPool = api().list(new ListOptions.Builder() .filter("name eq " + BACKUP_TARGETPOOL_NAME)); - assertEquals(targetPool.size(), 1); + assertEquals(Iterables.size(targetPool), 1); } @Test(groups = "live", dependsOnMethods = {"testInsertTargetPool2"}) diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java index 7608a71e88..4be46c314c 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java @@ -100,8 +100,7 @@ public class ZoneOperationApiExpectTest extends BaseGoogleComputeEngineApiExpect private static ListPage expectedList() { return ListPage.create( // ImmutableList.of(new ParseZoneOperationTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java index b71726f8a6..b269d7b7a6 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java @@ -52,8 +52,7 @@ public class ParseAddressListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseDiskTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java index af03d68eba..e7f04883ab 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java @@ -52,8 +52,7 @@ public class ParseDiskTypeListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseForwardingRuleTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java index 15365454fa..3ebd1a31c3 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java @@ -39,8 +39,7 @@ public class ParseGlobalOperationListTest extends BaseGoogleComputeEngineParseTe public ListPage expected() { return ListPage.create( // ImmutableList.of(new ParseGlobalOperationTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java index bb5cc3922e..3cd4722837 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java @@ -70,8 +70,7 @@ public class ParseHttpHealthCheckListTest extends BaseGoogleComputeEngineParseTe ); return ListPage.create( // ImmutableList.of(healthCheck1, healthCheck2, healthCheck3), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java index 9c400403dc..dadc1f0949 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java @@ -38,8 +38,7 @@ public class ParseImageListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseImageTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java index 2cc4697326..49ebe26d41 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java @@ -39,8 +39,7 @@ public class ParseInstanceListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseInstanceTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java index 74d7fde405..25ed1f28f2 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java @@ -80,8 +80,7 @@ public class ParseMachineTypeListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseNetworkTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java index b5e0bfff0f..d7c9497289 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java @@ -61,8 +61,7 @@ public class ParseRegionListTest extends BaseGoogleComputeEngineParseTest expected() { return ListPage.create( // ImmutableList.of(new ParseTargetPoolTest().expected()), // items - null, // nextPageToken - null // prefixes + null // nextPageToken ); } } diff --git a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java index 90902c8367..5fd45d3b0d 100644 --- a/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java +++ b/providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java @@ -57,8 +57,7 @@ public class ParseZoneListTest extends BaseGoogleComputeEngineParseTest