From b95f36952d7ee8358ec06b8d28a4d68ca4dbe437 Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Sat, 14 Jul 2012 18:46:29 -0700 Subject: [PATCH] Fix infinite loops, found by FindBugs --- .../java/org/jclouds/cache/RetryingCacheLoaderDecorator.java | 2 +- .../director/v1_5/domain/query/QueryResultNetworkRecord.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/jclouds/cache/RetryingCacheLoaderDecorator.java b/core/src/main/java/org/jclouds/cache/RetryingCacheLoaderDecorator.java index 46a925c242..42cf665503 100644 --- a/core/src/main/java/org/jclouds/cache/RetryingCacheLoaderDecorator.java +++ b/core/src/main/java/org/jclouds/cache/RetryingCacheLoaderDecorator.java @@ -158,7 +158,7 @@ public class RetryingCacheLoaderDecorator { @Override protected Objects.ToStringHelper string() { - return string().add("retryableThrowable", retryableThrowable).add("periodMs", periodMs).add("maxPeriodMs", + return Objects.toStringHelper(this).add("retryableThrowable", retryableThrowable).add("periodMs", periodMs).add("maxPeriodMs", maxPeriodMs).add("maxTries", maxTries); } } diff --git a/labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultNetworkRecord.java b/labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultNetworkRecord.java index b6f9a415bc..5f6bd1d4bd 100644 --- a/labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultNetworkRecord.java +++ b/labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/query/QueryResultNetworkRecord.java @@ -264,7 +264,7 @@ public class QueryResultNetworkRecord extends QueryResultRecordType { @Override public ToStringHelper string() { - return string().add("name", name).add("ipScopeId", ipScopeId).add("gateway", gateway).add("netmask", netmask).add("dns1", dns1).add("dns2", dns2).add("dnsSuffix", dnsSuffix).add("isBusy", + return Objects.toStringHelper(this).add("name", name).add("ipScopeId", ipScopeId).add("gateway", gateway).add("netmask", netmask).add("dns1", dns1).add("dns2", dns2).add("dnsSuffix", dnsSuffix).add("isBusy", isBusy); }