diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/ResourceRecordAsyncApi.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/ResourceRecordAsyncApi.java index 2fee1d8524..d8fab3688e 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/ResourceRecordAsyncApi.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/ResourceRecordAsyncApi.java @@ -35,7 +35,7 @@ import org.jclouds.ultradns.ws.binders.ZoneAndResourceRecordToXML; import org.jclouds.ultradns.ws.domain.ResourceRecord; import org.jclouds.ultradns.ws.domain.ResourceRecordMetadata; import org.jclouds.ultradns.ws.filters.SOAPWrapWithPasswordAuth; -import org.jclouds.ultradns.ws.xml.IDHandler; +import org.jclouds.ultradns.ws.xml.TextHandler; import org.jclouds.ultradns.ws.xml.ResourceRecordListHandler; import com.google.common.collect.FluentIterable; @@ -56,7 +56,7 @@ public interface ResourceRecordAsyncApi { */ @Named("createResourceRecord") @POST - @XMLResponseParser(IDHandler.Guid.class) + @XMLResponseParser(TextHandler.Guid.class) @MapBinder(ZoneAndResourceRecordToXML.class) ListenableFuture create(@PayloadParam("resourceRecord") ResourceRecord toCreate) throws ResourceAlreadyExistsException; diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/RoundRobinPoolAsyncApi.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/RoundRobinPoolAsyncApi.java index e7087f525d..ab27999f81 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/RoundRobinPoolAsyncApi.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/RoundRobinPoolAsyncApi.java @@ -33,7 +33,7 @@ import org.jclouds.ultradns.ws.UltraDNSWSExceptions.ResourceAlreadyExistsExcepti import org.jclouds.ultradns.ws.domain.ResourceRecord; import org.jclouds.ultradns.ws.domain.RoundRobinPool; import org.jclouds.ultradns.ws.filters.SOAPWrapWithPasswordAuth; -import org.jclouds.ultradns.ws.xml.IDHandler; +import org.jclouds.ultradns.ws.xml.TextHandler; import org.jclouds.ultradns.ws.xml.ResourceRecordListHandler; import org.jclouds.ultradns.ws.xml.RoundRobinPoolListHandler; @@ -74,7 +74,7 @@ public interface RoundRobinPoolAsyncApi { */ @Named("addRRLBPool") @POST - @XMLResponseParser(IDHandler.RRPool.class) + @XMLResponseParser(TextHandler.RRPoolID.class) @Payload("{zoneName}{hostName}{description}1") ListenableFuture createAPoolForHostname(@PayloadParam("description") String name, @PayloadParam("hostName") String hostname) throws ResourceAlreadyExistsException; @@ -84,7 +84,7 @@ public interface RoundRobinPoolAsyncApi { */ @Named("addRecordToRRPool") @POST - @XMLResponseParser(IDHandler.Guid.class) + @XMLResponseParser(TextHandler.Guid.class) @Payload("") ListenableFuture addARecordWithAddressAndTTL(@PayloadParam("lbPoolID") String lbPoolID, @PayloadParam("address") String ipv4Address, @PayloadParam("ttl") int ttl) @@ -114,7 +114,7 @@ public interface RoundRobinPoolAsyncApi { */ @Named("addRRLBPool") @POST - @XMLResponseParser(IDHandler.RRPool.class) + @XMLResponseParser(TextHandler.RRPoolID.class) @Payload("{zoneName}{hostName}{description}28") ListenableFuture createAAAAPoolForHostname(@PayloadParam("description") String name, @PayloadParam("hostName") String hostname) throws ResourceAlreadyExistsException; @@ -124,7 +124,7 @@ public interface RoundRobinPoolAsyncApi { */ @Named("addRecordToRRPool") @POST - @XMLResponseParser(IDHandler.Guid.class) + @XMLResponseParser(TextHandler.Guid.class) @Payload("") ListenableFuture addAAAARecordWithAddressAndTTL(@PayloadParam("lbPoolID") String lbPoolID, @PayloadParam("address") String ipv6Address, @PayloadParam("ttl") int ttl) diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TaskAsyncApi.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TaskAsyncApi.java index 654c9ef1be..919c37e472 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TaskAsyncApi.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TaskAsyncApi.java @@ -31,7 +31,7 @@ import org.jclouds.rest.annotations.VirtualHost; import org.jclouds.rest.annotations.XMLResponseParser; import org.jclouds.ultradns.ws.domain.Task; import org.jclouds.ultradns.ws.filters.SOAPWrapWithPasswordAuth; -import org.jclouds.ultradns.ws.xml.IDHandler; +import org.jclouds.ultradns.ws.xml.TextHandler; import org.jclouds.ultradns.ws.xml.TaskHandler; import org.jclouds.ultradns.ws.xml.TaskListHandler; @@ -52,7 +52,7 @@ public interface TaskAsyncApi { */ @Named("runTest") @POST - @XMLResponseParser(IDHandler.Guid.class) + @XMLResponseParser(TextHandler.Guid.class) @Payload("{value}") ListenableFuture runTest(@PayloadParam("value") String value); diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TrafficControllerPoolAsyncApi.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TrafficControllerPoolAsyncApi.java index fc76f1b5c2..ce3425f3a1 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TrafficControllerPoolAsyncApi.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/features/TrafficControllerPoolAsyncApi.java @@ -35,8 +35,8 @@ import org.jclouds.ultradns.ws.domain.PoolRecordSpec; import org.jclouds.ultradns.ws.domain.TrafficControllerPool; import org.jclouds.ultradns.ws.domain.TrafficControllerPoolRecord; import org.jclouds.ultradns.ws.filters.SOAPWrapWithPasswordAuth; -import org.jclouds.ultradns.ws.xml.IDHandler; import org.jclouds.ultradns.ws.xml.PoolRecordSpecHandler; +import org.jclouds.ultradns.ws.xml.TextHandler; import org.jclouds.ultradns.ws.xml.TrafficControllerPoolListHandler; import org.jclouds.ultradns.ws.xml.TrafficControllerPoolRecordListHandler; @@ -58,7 +58,7 @@ public interface TrafficControllerPoolAsyncApi { */ @Named("addTCLBPool") @POST - @XMLResponseParser(IDHandler.TCPool.class) + @XMLResponseParser(TextHandler.TCPoolID.class) @Payload("{zoneName}{hostName}{description}1EnabledEnabled0") ListenableFuture createPoolForHostname(@PayloadParam("description") String name, @PayloadParam("hostName") String hostname) throws ResourceAlreadyExistsException; @@ -96,7 +96,7 @@ public interface TrafficControllerPoolAsyncApi { */ @Named("addPoolRecord") @POST - @XMLResponseParser(IDHandler.PoolRecord.class) + @XMLResponseParser(TextHandler.PoolRecordID.class) @Payload("{poolID}{pointsTo}{ttl}") ListenableFuture addRecordToPoolWithTTL(@PayloadParam("pointsTo") String pointsTo, @PayloadParam("poolID") String lbPoolID, @PayloadParam("ttl") int ttl) throws ResourceAlreadyExistsException; diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/IDHandler.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/TextHandler.java similarity index 68% rename from providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/IDHandler.java rename to providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/TextHandler.java index 541bb07baf..ce59512213 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/IDHandler.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/xml/TextHandler.java @@ -28,54 +28,54 @@ import org.jclouds.http.functions.ParseSax; * * @author Adrian Cole */ -public abstract class IDHandler extends ParseSax.HandlerForGeneratedRequestWithResult { +public abstract class TextHandler extends ParseSax.HandlerForGeneratedRequestWithResult { - public static class Guid extends IDHandler { + public static class Guid extends TextHandler { public Guid() { super("guid"); } } - public static class RRPool extends IDHandler { - public RRPool() { + public static class RRPoolID extends TextHandler { + public RRPoolID() { super("RRPoolID"); } } - public static class TCPool extends IDHandler { - public TCPool() { + public static class TCPoolID extends TextHandler { + public TCPoolID() { super("TCPoolID"); } } - public static class PoolRecord extends IDHandler { - public PoolRecord() { + public static class PoolRecordID extends TextHandler { + public PoolRecordID() { super("poolRecordID"); } } - private String idElement; + private String textElement; private StringBuilder currentText = new StringBuilder(); - private String id = null; + private String text = null; - private IDHandler(String idElement) { - this.idElement = checkNotNull(idElement, "idElement"); + private TextHandler(String textElement) { + this.textElement = checkNotNull(textElement, "textElement"); } @Override public String getResult() { try { - return checkNotNull(id, "%s not present in the response", idElement); + return checkNotNull(text, "%s not present in the response", textElement); } finally { - id = null; + text = null; } } @Override public void endElement(String uri, String name, String qName) { - if (equalsOrSuffix(qName, idElement)) { - id = currentOrNull(currentText); + if (equalsOrSuffix(qName, textElement)) { + text = currentOrNull(currentText); } currentText = new StringBuilder(); } diff --git a/providers/ultradns-ws/src/test/java/org/jclouds/ultradns/ws/parse/RunTestResponseTest.java b/providers/ultradns-ws/src/test/java/org/jclouds/ultradns/ws/parse/RunTestResponseTest.java index f818089f62..70b6edbee0 100644 --- a/providers/ultradns-ws/src/test/java/org/jclouds/ultradns/ws/parse/RunTestResponseTest.java +++ b/providers/ultradns-ws/src/test/java/org/jclouds/ultradns/ws/parse/RunTestResponseTest.java @@ -23,7 +23,7 @@ import static org.testng.Assert.assertEquals; import java.io.InputStream; import org.jclouds.http.functions.BaseHandlerTest; -import org.jclouds.ultradns.ws.xml.IDHandler; +import org.jclouds.ultradns.ws.xml.TextHandler; import org.testng.annotations.Test; /** @@ -35,7 +35,7 @@ public class RunTestResponseTest extends BaseHandlerTest { public void test() { InputStream is = getClass().getResourceAsStream("/taskid.xml"); - IDHandler.Guid handler = injector.getInstance(IDHandler.Guid.class); + TextHandler.Guid handler = injector.getInstance(TextHandler.Guid.class); assertEquals(factory.create(handler).parse(is), "8d7a1725-4f4a-4b70-affa-f01dcce1526e"); } }