Fixed live test + added missing expect test for logout

apis/cloudstack/src/main/java/org/jclouds/cloudstack/functions/LoginWithPasswordCredentials.java

@@ -18,17 +18,15 @@
  */
 package org.jclouds.cloudstack.functions;
 
-import java.io.File;
+import com.google.common.base.Function;
-
-import javax.inject.Inject;
-import javax.inject.Singleton;
-
 import org.jclouds.cloudstack.domain.LoginResponse;
 import org.jclouds.cloudstack.features.SessionClient;
 import org.jclouds.crypto.CryptoStreams;
 import org.jclouds.domain.Credentials;
 
-import com.google.common.base.Function;
+import javax.inject.Inject;
+import javax.inject.Singleton;
+import java.io.File;
 
 @Singleton
 public class LoginWithPasswordCredentials implements Function<Credentials, LoginResponse> {
@@ -42,7 +40,8 @@ public class LoginWithPasswordCredentials implements Function<Credentials, Login
    @Override
    public LoginResponse apply(Credentials input) {
       String username = input.identity;
-      String domain = "ROOT";
+      String domain = "";  // empty = ROOT domain
+
       // domain may be present
       if (username.indexOf('/') != -1) {
          File domainUsername = new File(username);

apis/cloudstack/src/main/java/org/jclouds/cloudstack/util/ApiKeyPairs.java

@@ -27,7 +27,6 @@ import org.jclouds.cloudstack.domain.ApiKeyPair;
 import org.jclouds.cloudstack.domain.User;
 import org.jclouds.compute.ComputeServiceContext;
 import org.jclouds.compute.ComputeServiceContextFactory;
-import org.jclouds.crypto.CryptoStreams;
 import org.jclouds.rest.RestContextFactory;
 
 import java.util.Properties;
@@ -45,10 +44,14 @@ public class ApiKeyPairs {
    /**
     * Retrieve the API key pair for a given CloudStack user
     *
-    * @param endpoint CloudStack API endpoint (e.g. http://72.52.126.25/client/api/)
+    * @param endpoint
-    * @param username User account name
+    *          CloudStack API endpoint (e.g. http://72.52.126.25/client/api/)
-    * @param password User password
+    * @param username
-    * @param domain   Domain name. If empty defaults to ROOT
+    *          User account name
+    * @param password
+    *          User password
+    * @param domain
+    *          Domain name. If empty defaults to ROOT
     * @return
     */
    public static ApiKeyPair getApiKeyPairForUser(String endpoint, String username, String password, String domain) {
@@ -60,6 +63,7 @@ public class ApiKeyPairs {
          CloudStackClient client = CloudStackClient.class.cast(context.getProviderSpecificContext().getApi());
          Set<Account> listOfAccounts = client.getAccountClient().listAccounts();
 
+         domain = (domain.equals("") || domain.equals("/")) ? "ROOT" : domain;
          for (Account account : listOfAccounts) {
             for (User user : account.getUsers()) {
                if (user.getName().equals(username) && user.getDomain().equals(domain)) {
@@ -91,7 +95,7 @@ public class ApiKeyPairs {
       overrides.put(PROVIDER + ".endpoint", checkNotNull(endpoint, "endpoint"));
       overrides.put(PROVIDER + ".identity",
          String.format("%s/%s", checkNotNull(domain, "domain"), checkNotNull(username, "username")));
-      overrides.put(PROVIDER + ".credential", CryptoStreams.md5Hex(checkNotNull(password, "password")));
+      overrides.put(PROVIDER + ".credential", checkNotNull(password, "password"));
 
       return overrides;
    }

apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/SessionClientExpectTest.java

@@ -18,13 +18,7 @@
  */
 package org.jclouds.cloudstack.features;
 
-import static org.jclouds.crypto.CryptoStreams.md5Hex;
+import com.google.common.collect.ImmutableMultimap;
-import static org.testng.Assert.assertEquals;
-
-import java.io.IOException;
-import java.net.URI;
-import java.net.URLEncoder;
-
 import org.jclouds.cloudstack.CloudStackContext;
 import org.jclouds.cloudstack.domain.Account;
 import org.jclouds.cloudstack.domain.LoginResponse;
@@ -32,7 +26,12 @@ import org.jclouds.http.HttpRequest;
 import org.jclouds.http.HttpResponse;
 import org.testng.annotations.Test;
 
-import com.google.common.collect.ImmutableMultimap;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URLEncoder;
+
+import static org.jclouds.crypto.CryptoStreams.md5Hex;
+import static org.testng.Assert.assertEquals;
 
 /**
  * Tests behavior of {@code SessionClient}
@@ -44,42 +43,54 @@ public class SessionClientExpectTest extends BaseCloudStackRestClientExpectTest<
 
    @SuppressWarnings("deprecation")
    public void testLoginWhenResponseIs2xxIncludesJSessionId() throws IOException {
-       String domain = "Partners/jCloud";
+      String domain = "Partners/jCloud";
-       String user = "jcloud";
+      String user = "jcloud";
-       String password = "jcl0ud";
+      String password = "jcl0ud";
-       String md5password = md5Hex(password);
+      String md5password = md5Hex(password);
 
       HttpRequest request = HttpRequest.builder()
          .method("GET")
          .endpoint(
             URI.create("http://localhost:8080/client/api?response=json&command=login&" +
-               "username="+user+"&password=" + md5password+ "&domain=" + URLEncoder.encode(domain)))
+               "username=" + user + "&password=" + md5password + "&domain=" + URLEncoder.encode(domain)))
          .headers(
             ImmutableMultimap.<String, String>builder()
                .put("Accept", "application/json")
                .build())
          .build();
 
-       String jSessionId = "90DD65D13AEAA590ECCA312D150B9F6D";
+      String jSessionId = "90DD65D13AEAA590ECCA312D150B9F6D";
       SessionClient client = requestSendsResponse(request,
          HttpResponse.builder()
             .statusCode(200)
-                     .headers(
+            .headers(
-            ImmutableMultimap.<String, String>builder()
+               ImmutableMultimap.<String, String>builder()
-               .put("Set-Cookie", "JSESSIONID="+jSessionId+"; Path=/client")
+                  .put("Set-Cookie", "JSESSIONID=" + jSessionId + "; Path=/client")
-               .build())
+                  .build())
             .payload(payloadFromResource("/loginresponse.json"))
             .build());
 
       assertEquals(client.loginUserInDomainWithHashOfPassword(user, domain, md5password).toString(),
-
+         LoginResponse.builder().timeout(1800).lastName("Kiran").registered(false).username("jcloud").firstName("Vijay")
-      LoginResponse.builder().timeout(1800).lastName("Kiran").registered(false).username("jcloud").firstName("Vijay")
+            .domainId(11).accountType(Account.Type.DOMAIN_ADMIN).userId(19).sessionKey(
-               .domainId(11).accountType(Account.Type.DOMAIN_ADMIN).userId(19).sessionKey(
+            "uYT4/MNiglgAKiZRQkvV8QP8gn0=").jSessionId(jSessionId).accountName("jcloud").build().toString());
-                        "uYT4/MNiglgAKiZRQkvV8QP8gn0=").jSessionId(jSessionId).accountName("jcloud").build().toString());
    }
 
-   //TODO: logout.
+   public void testLogout() throws IOException {
+      HttpRequest request = HttpRequest.builder()
+         .method("GET")
+         .endpoint(
+            URI.create("http://localhost:8080/client/api?response=json&command=logout&sessionkey=dummy-session-key"))
+         .build();
 
+      SessionClient client = requestSendsResponse(request,
+         HttpResponse.builder()
+            .statusCode(200)
+            .payload(payloadFromResource("/logoutresponse.json"))
+            .build());
+
+      client.logoutUser("dummy-session-key");
+   }
 
    @Override
    protected SessionClient clientFrom(CloudStackContext context) {

apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/SessionClientLiveTest.java

@@ -19,6 +19,7 @@
 package org.jclouds.cloudstack.features;
 
 import org.jclouds.cloudstack.domain.Account;
+import org.jclouds.cloudstack.domain.LoginResponse;
 import org.jclouds.cloudstack.domain.User;
 import org.jclouds.cloudstack.util.ApiKeyPairs;
 import org.jclouds.crypto.CryptoStreams;
@@ -27,6 +28,7 @@ import org.testng.annotations.Test;
 import static org.jclouds.cloudstack.features.GlobalAccountClientLiveTest.createTestAccount;
 import static org.jclouds.cloudstack.features.GlobalUserClientLiveTest.createTestUser;
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
 
 /**
  * Tests behavior of {@code SessionClient}
@@ -50,10 +52,12 @@ public class SessionClientLiveTest extends BaseCloudStackClientLiveTest {
          String expectedUsername = prefix + "-user";
          assertEquals(testUser.getName(), expectedUsername);
 
+         checkLoginAsTheNewUser(expectedUsername);
+
          assertEquals(
             globalAdminClient.getUserClient().registerUserKeys(testUser.getId()),
-            ApiKeyPairs.getApiKeyPairForUser(System.getProperty("test.cloudstack.endpoint"),
+            ApiKeyPairs.getApiKeyPairForUser(
-               prefix + "-user", CryptoStreams.md5Hex("password"), "/")
+               System.getProperty("test.cloudstack.endpoint"), prefix + "-user", "password", "")
          );
 
       } finally {
@@ -63,4 +67,15 @@ public class SessionClientLiveTest extends BaseCloudStackClientLiveTest {
             globalAdminClient.getAccountClient().deleteAccount(testAccount.getId());
       }
    }
+
+   private void checkLoginAsTheNewUser(String expectedUsername) {
+      LoginResponse response = globalAdminClient.getSessionClient()
+         .loginUserInDomainWithHashOfPassword(expectedUsername, "", CryptoStreams.md5Hex("password"));
+
+      assertNotNull(response);
+      assertNotNull(response.getSessionKey());
+      assertNotNull(response.getJSessionId());
+
+      client.getSessionClient().logoutUser(response.getSessionKey());
+   }
 }

apis/cloudstack/src/test/resources/logoutresponse.json

@@ -0,0 +1 @@
+{ "logoutresponse" : { "description" : "success" } }