Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed function only used once and only accessing a single if branch

This commit is contained in:
Adrian Cole 2013-01-12 13:47:07 -08:00
parent 60ab6d8e26
commit cca73d8a69
2 changed files with 10 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
core/src/main/java/org/jclouds/util/ClassLoadingUtils.java
View File

@ -1,51 +0,0 @@
/**
* Licensed to jclouds, Inc. (jclouds) under one or more
* contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. jclouds licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.jclouds.util;
import java.net.URL;
import com.google.common.io.Resources;
public class ClassLoadingUtils {
public ClassLoadingUtils() {
//Utility Class
}
/**
* Returns the url of a resource.
* 1. The context class is being used.
* 2. The thread context class loader is being used.
* If both approach fail, returns null.
*
* @param contextClass
* @param resourceName
* @return
*/
public static URL loadResource(Class<?> contextClass, String resourceName) {
URL url = null;
if (contextClass != null) {
url = Resources.getResource(contextClass, resourceName);
}
if (url == null && Thread.currentThread().getContextClassLoader() != null) {
url = Thread.currentThread().getContextClassLoader().getResource(resourceName);
}
return url;
}
}

18
scriptbuilder/src/main/java/org/jclouds/scriptbuilder/functionloader/BasicFunctionLoader.java
View File

@ -18,14 +18,17 @@
*/ */
package org.jclouds.scriptbuilder.functionloader; package org.jclouds.scriptbuilder.functionloader;
import com.google.common.base.Charsets; import static com.google.common.base.Charsets.UTF_8;
import com.google.common.io.Resources; import static com.google.common.io.Resources.getResource;
import org.jclouds.scriptbuilder.domain.OsFamily; import static java.lang.String.format;
import org.jclouds.scriptbuilder.domain.ShellToken; import static org.jclouds.scriptbuilder.domain.ShellToken.SH;
import org.jclouds.util.ClassLoadingUtils;
import java.io.IOException; import java.io.IOException;
import org.jclouds.scriptbuilder.domain.OsFamily;
import com.google.common.io.Resources;
/** /**
* A {@link FunctionLoader} implementation which loads the target function from the classpath. * A {@link FunctionLoader} implementation which loads the target function from the classpath.
*/ */
@ -45,9 +48,8 @@ public enum BasicFunctionLoader implements FunctionLoader {
@Override @Override
public String loadFunction(String function, OsFamily family) throws FunctionNotFoundException { public String loadFunction(String function, OsFamily family) throws FunctionNotFoundException {
try { try {
return Resources.toString(ClassLoadingUtils.loadResource( return Resources.toString(
BasicFunctionLoader.class, String.format("/functions/%s.%s", function, ShellToken.SH.to(family))), getResource(BasicFunctionLoader.class, format("/functions/%s.%s", function, SH.to(family))), UTF_8);
Charsets.UTF_8);
} catch (IOException e) { } catch (IOException e) {
throw new FunctionNotFoundException(function, family, e); throw new FunctionNotFoundException(function, family, e);
} }