diff --git a/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATAsyncClient.java b/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATAsyncClient.java index 35ff47ae10..425fb9ca28 100644 --- a/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATAsyncClient.java +++ b/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATAsyncClient.java @@ -73,16 +73,15 @@ public interface NATAsyncClient { ListenableFuture getIPForwardingRule(@QueryParam("id") long id); /** - * @see NATClient#createIPForwardingRuleForVirtualMachine + * @see NATClient#createIPForwardingRule */ @GET @QueryParams(keys = "command", values = "createIpForwardingRule") @Unwrap @Consumes(MediaType.APPLICATION_JSON) - ListenableFuture createIPForwardingRuleForVirtualMachine( - @QueryParam("virtualmachineid") long virtualMachineId, @QueryParam("ipaddressid") long IPAddressId, - @QueryParam("protocol") String protocol, @QueryParam("startport") int startPort, - CreateIPForwardingRuleOptions... options); + ListenableFuture createIPForwardingRule(@QueryParam("ipaddressid") long IPAddressId, + @QueryParam("protocol") String protocol, @QueryParam("startport") int startPort, + CreateIPForwardingRuleOptions... options); /** * @see NATClient#enableStaticNATForVirtualMachine @@ -92,7 +91,7 @@ public interface NATAsyncClient { @Unwrap @Consumes(MediaType.APPLICATION_JSON) ListenableFuture enableStaticNATForVirtualMachine( - @QueryParam("virtualmachineid") long virtualMachineId, @QueryParam("ipaddressid") long IPAddressId); + @QueryParam("virtualmachineid") long virtualMachineId, @QueryParam("ipaddressid") long IPAddressId); /** * @see NATClient#deleteIPForwardingRule diff --git a/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATClient.java b/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATClient.java index d077d8ae82..bd2d29512f 100644 --- a/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATClient.java +++ b/sandbox-apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/NATClient.java @@ -59,9 +59,6 @@ public interface NATClient { /** * Creates an ip forwarding rule * - * @param virtualMachineId - * the virtual machine this rule applies to. - * * @param IPAddressId * the public IP address id of the forwarding rule, already associated via associateIp * @param protocol @@ -70,8 +67,8 @@ public interface NATClient { * the start port for the rule * @return response used to track creation */ - AsyncCreateResponse createIPForwardingRuleForVirtualMachine(long virtualMachineId, long IPAddressId, - String protocol, int startPort, CreateIPForwardingRuleOptions... options); + AsyncCreateResponse createIPForwardingRule(long IPAddressId, String protocol, int startPort, + CreateIPForwardingRuleOptions... options); /** * Deletes an ip forwarding rule diff --git a/sandbox-apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATAsyncClientTest.java b/sandbox-apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATAsyncClientTest.java index e1222075fc..f873405afc 100644 --- a/sandbox-apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATAsyncClientTest.java +++ b/sandbox-apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/NATAsyncClientTest.java @@ -49,7 +49,7 @@ public class NATAsyncClientTest extends BaseCloudStackAsyncClientTest= 0); for (IPForwardingRule rule : response) { IPForwardingRule newDetails = getOnlyElement(client.getNATClient().listIPForwardingRules( - ListIPForwardingRulesOptions.Builder.id(rule.getId()))); + ListIPForwardingRulesOptions.Builder.id(rule.getId()))); assertEquals(rule.getId(), newDetails.getId()); checkRule(rule); }