Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #939 from andrewgaul/checkstyle-empty-statement 

Enforce no empty statements via Checkstyle
This commit is contained in:
Adrian Cole 2012-11-01 19:49:34 -07:00
parent ddbb41130d 88d53b8792
commit d4c01e6c2e
9 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apis/cloudloadbalancers/src/main/java/org/jclouds/cloudloadbalancers/functions/UnwrapLoadBalancers.java
View File

@ -58,7 +58,6 @@ public class UnwrapLoadBalancers implements Function<HttpResponse, Set<LoadBalan
Map<String, Set<LB>> map = json.apply(arg0);
if (map.size() == 0)
return ImmutableSet.<LoadBalancer> of();
;
return ImmutableSet.copyOf(Iterables.transform(Iterables.get(map.values(), 0), convertLB));
}

6
apis/sqs/src/main/java/org/jclouds/sqs/xml/BatchResponseHandler.java
View File

@ -54,9 +54,9 @@ public class BatchResponseHandler<V> extends ParseSax.HandlerForGeneratedRequest
protected BatchResponseHandler(String resultElement, HandlerForGeneratedRequestWithResult<Map.Entry<String, V>> resultHandler,
BatchErrorHandler errorHandler) {
this.resultElement = checkNotNull(resultElement, "resultElement");;
this.resultHandler = checkNotNull(resultHandler, "resultHandler");;
this.errorHandler = checkNotNull(errorHandler, "errorHandler");;
this.resultElement = checkNotNull(resultElement, "resultElement");
this.resultHandler = checkNotNull(resultHandler, "resultHandler");
this.errorHandler = checkNotNull(errorHandler, "errorHandler");
}
@Override

4
core/src/main/java/org/jclouds/http/functions/ParseFirstJsonValueNamed.java
View File

@ -72,8 +72,8 @@ public class ParseFirstJsonValueNamed<T> implements Function<HttpResponse, T> {
AtomicReference<String> name = new AtomicReference<String>();
JsonToken token = reader.peek();
for (; token != JsonToken.END_DOCUMENT && nnn(this.name, reader, token, name); token = skipAndPeek(token,
reader))
;
reader)) {
}
if (name.get() == null) {
logger.trace("did not object named %s in json from response %s", this.name, arg0);
return nothing();

4
labs/azure-management/src/main/java/org/jclouds/azure/management/domain/Operation.java
View File

@ -107,7 +107,7 @@ public class Operation {
* @see Operation#getHttpStatusCode()
*/
public Builder httpStatusCode(Integer httpStatusCode) {
this.httpStatusCode = Optional.fromNullable(httpStatusCode);;
this.httpStatusCode = Optional.fromNullable(httpStatusCode);
return this;
}
@ -139,7 +139,7 @@ public class Operation {
this.id = checkNotNull(id, "id");
this.rawStatus = checkNotNull(rawStatus, "rawStatus for %s", id);
this.status = checkNotNull(status, "status for %s", id);
this.httpStatusCode = checkNotNull(httpStatusCode, "httpStatusCode for %s", id);;
this.httpStatusCode = checkNotNull(httpStatusCode, "httpStatusCode for %s", id);
this.error = checkNotNull(error, "error for %s", id);
}

2
labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/Vdc.java
View File

@ -124,7 +124,7 @@ public class Vdc extends Entity {
* @see Vdc#getAvailableNetworks()
*/
public B network(Reference availableNetwork) {
this.availableNetworks.add(checkNotNull(availableNetwork, "availableNetwork"));;
this.availableNetworks.add(checkNotNull(availableNetwork, "availableNetwork"));
return self();
}

2
labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/dmtf/RasdItem.java
View File

@ -127,7 +127,7 @@ public class RasdItem extends ResourceAllocationSettingData {
super(builder);
this.type = builder.type;
this.href = builder.href;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;
}
protected RasdItem() {

2
labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/OperatingSystemSection.java
View File

@ -142,7 +142,7 @@ public class OperatingSystemSection extends org.jclouds.dmtf.ovf.OperatingSystem
this.osType = builder.osType;
this.href = builder.href;
this.type = builder.type;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;
}
protected OperatingSystemSection() {

2
labs/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/domain/section/VirtualHardwareSection.java
View File

@ -132,7 +132,7 @@ public class VirtualHardwareSection extends org.jclouds.dmtf.ovf.VirtualHardware
super(builder);
this.type = builder.type;
this.href = builder.href;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;;
this.links = builder.links != null && builder.links.isEmpty() ? null : builder.links;
}
protected VirtualHardwareSection() {

1
resources/checkstyle.xml
View File

@ -5,6 +5,7 @@
<property name="severity" value="warning"/>
<module name="NewlineAtEndOfFile"/>
<module name="TreeWalker">
<module name="EmptyStatement"/>
<module name="LineLength">
<property name="ignorePattern" value="^import\s.*;$"/>
<property name="max" value="120"/>