Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid injecting on final fields 

This can cause thread visibility issues.  Found via error-prone.
This commit is contained in:
Andrew Gaul 2017-08-28 21:07:30 -07:00
parent e08acc6ed6
commit df43b36487
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java
View File

@ -51,7 +51,7 @@ public class RetryOnRenew implements HttpRetryHandler {
@VisibleForTesting
@Inject(optional = true)
@Named(Constants.PROPERTY_MAX_RETRIES)
static final int NUM_RETRIES = 5;
static int NUM_RETRIES = 5;
private final LoadingCache<Credentials, Access> authenticationResponseCache;

2
compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java
View File

@ -49,7 +49,7 @@ public final class ComputeServiceConstants {
@Singleton
public static class NamingConvention {
@Inject(optional = true)
public final Supplier<String> randomSuffix = new Supplier<String>() {
public Supplier<String> randomSuffix = new Supplier<String>() {
final SecureRandom random = new SecureRandom();
@Override

2
project/pom.xml
View File

@ -808,7 +808,7 @@
<compilerArg>-Xep:AssertFalse:ERROR</compilerArg>
<compilerArg>-Xep:AssistedInjectAndInjectOnConstructors:ERROR</compilerArg>
<compilerArg>-Xep:CollectionIncompatibleType:ERROR</compilerArg>
<compilerArg>-Xep:GuiceInjectOnFinalField:OFF</compilerArg> <!-- noisy -->
<compilerArg>-Xep:GuiceInjectOnFinalField:ERROR</compilerArg>
<compilerArg>-Xep:MissingFail:ERROR</compilerArg>
<compilerArg>-Xep:NullablePrimitive:ERROR</compilerArg>
<compilerArg>-Xep:OverridesGuiceInjectableMethod:OFF</compilerArg> <!-- internal error with 2.0.5 -->