Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

JCLOUDS-835: Atomically put filesystem blobs 

Write to a temporary file and rename to the desired destination to
better match object store semantics.
This commit is contained in:
Andrew Gaul 2015-11-20 14:37:43 -08:00
parent 4ce357ba69
commit f706d9c13a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
View File

@ -43,6 +43,7 @@ import java.util.Collection;
import java.util.Date;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import javax.annotation.Resource;
import javax.inject.Inject;
@ -450,13 +451,14 @@ public class FilesystemStorageStrategyImpl implements LocalStorageStrategy {
return putDirectoryBlob(containerName, blob);
}
File outputFile = getFileForBlobKey(containerName, blobKey);
// TODO: should we use a known suffix to filter these out during list?
File tmpFile = getFileForBlobKey(containerName, blobKey + "-" + UUID.randomUUID());
Path outputPath = outputFile.toPath();
HashingInputStream his = null;
try {
Files.createParentDirs(outputFile);
Files.createParentDirs(tmpFile);
his = new HashingInputStream(Hashing.md5(), payload.openStream());
delete(outputFile);
Files.asByteSink(outputFile).writeFrom(his);
Files.asByteSink(tmpFile).writeFrom(his);
HashCode actualHashCode = his.hash();
HashCode expectedHashCode = payload.getContentMetadata().getContentMD5AsHashCode();
if (expectedHashCode != null && !actualHashCode.equals(expectedHashCode)) {
@ -465,6 +467,8 @@ public class FilesystemStorageStrategyImpl implements LocalStorageStrategy {
}
payload.getContentMetadata().setContentMD5(actualHashCode);
tmpFile.renameTo(outputFile);
UserDefinedFileAttributeView view = getUserDefinedFileAttributeView(outputPath);
if (view != null) {
try {
@ -477,11 +481,11 @@ public class FilesystemStorageStrategyImpl implements LocalStorageStrategy {
setBlobAccess(containerName, blobKey, BlobAccess.PRIVATE);
return base16().lowerCase().encode(actualHashCode.asBytes());
} catch (IOException ex) {
if (outputFile != null) {
if (tmpFile != null) {
try {
delete(outputFile);
delete(tmpFile);
} catch (IOException e) {
logger.debug("Could not delete %s: %s", outputFile, e);
logger.debug("Could not delete %s: %s", tmpFile, e);
}
}
throw ex;