Commit Graph

29 Commits

Author SHA1 Message Date
Chris Custine d3234b7299 Backport https://github.com/jclouds/jclouds/pull/472 2014-08-18 19:13:27 -06:00
Andrew Gaul 322ea1cbb3 Allow Javadoc to reference imports
These style errors continue to creep in due to IDE misconfiguration so
we might as well stop checking for it.
2014-07-26 11:03:58 -07:00
Andrew Gaul 4c74b49754 JCLOUDS-546: Enforce no Javadoc @author annotation 2014-06-07 21:44:58 -07:00
Andrew Gaul 67c2b5f6b9 Enable whitespace around Checkstyle rule 2014-05-08 18:31:47 -07:00
Andrew Gaul 2d88f5164e Enforce that all commas have trailing whitespace 2014-05-08 18:28:08 -07:00
Andrew Gaul 0398276be3 Remove redundant imports
Also enforce no new ones via Checkstyle
2013-12-12 18:23:43 -08:00
Andrew Gaul 828d8790c2 Enforce no unused imports via Checkstyle
Removed with:

mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
2013-12-11 17:27:43 -08:00
Andrew Gaul 17ce72794c Enable RedundantModifier for Checkstyle 2013-10-31 10:23:30 -07:00
Ignasi Barrera 335f5943f4 JCLOUDS-149: Reuse checkstyle configuration 2013-07-02 18:02:03 +02:00
Andrew Phillips 8aeed868f4 Move license header after opening <?xml... in Checkstyle config 2013-05-24 17:08:52 -04:00
adriancole f1b8ca1ff2 JCLOUDS-31. manually adjusted license header on checkstyle and terremark xml files 2013-05-16 21:30:32 -07:00
Andrew Bayer 7923009eb5 JCLOUDS-37. Fix RAT violations in incubator-jclouds, master branch 2013-05-13 19:17:50 -07:00
Andrew Gaul fff2fa6e05 Address Checkstyle violations
This commit requires temporarily disabling some checks.
2013-04-17 16:21:21 -07:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul b9e4543cdb Enforce no use of star imports via Checkstyle 2012-11-13 20:51:59 -08:00
Andrew Gaul d7380114a6 Enforce use of Atomics.newReference via Checkstyle
Avoids duplicating types.
2012-11-12 11:56:48 -08:00
Andrew Gaul 42a3f4a3f9 Enforce use of StringBuilder via Checkstyle
Callers usually do not intend to use a synchronized StringBuffer.
EasyMock requires use of StringBuffer in some situations.
2012-11-12 08:24:36 -08:00
Andrew Gaul 3ad36d25d5 Enforce no unnecessary parentheses via Checkstyle 2012-11-10 13:22:12 -08:00
Andrew Gaul a601f63a9a Disable Checkstyle line length checks
While we would like to enforce this, we have too many violations to do
this in the near-term.
2012-11-10 13:07:02 -08:00
Andrew Gaul de82496aae Ensure simple boolean expressions via Checkstyle 2012-11-05 11:41:16 -08:00
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul 9d643b569a Enforce a single variable declaration per line 2012-11-04 17:37:16 -08:00
Andrew Gaul 41154d552c Enforce no illegal throws via Checkstyle
Also remove a stray unused import.
2012-11-04 15:48:44 -08:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul 44f6318759 Add Checkstyle configuration for line length
Enforces line length of 120 characters, which fails due to many
violations.
2012-10-26 10:11:42 -07:00