107741f786
JCLOUDS-1629: Upgrade to Guice 7.0.0
...
This also changes from javax to jakarta annotations.
2024-02-26 15:27:29 +09:00
b5e4e1d0fd
JCLOUDS-1627: Upgrade to Jakarta packages
...
This resolves an issue with newer Guice versions.
2024-02-23 18:04:48 +09:00
552eb95c44
Fix Files name collision
...
Regression from b282b5cbfe
2022-11-21 07:49:18 +09:00
b282b5cbfe
vuln-fix: Temporary File Information Disclosure
...
This fixes temporary file information disclosure vulnerability due to the use
of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by
using the `Files.createTempFile()` method which sets the correct posix permissions.
Weakness: CWE-377: Insecure Temporary File
Severity: Medium
CVSSS: 5.5
Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation )
Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18
Co-authored-by: Moderne <team@moderne.io>
2022-11-20 21:31:45 +09:00
62767a1461
JCLOUDS-1333: JCLOUDS-1334: JCLOUDS-1470: Require Java 8 and Guava 22
...
This allows compatibility with Guava 29. Also unwind some older
workarounds.
2020-06-25 08:11:30 +09:00
46a9f574e2
Fix some orphaned format strings
...
These lack values to format with. Found via error-prone 2.3.0.
2018-04-19 08:43:46 -07:00
46759f8bda
Fix a few Coverity defects
2017-11-05 20:12:47 -08:00
a493e2ca2f
JCLOUDS-1225: Address Guava 18 Objects changes
...
Fixed with:
find -name \*.java | xargs sed -i 's/Objects.[Tt]oStringHelper/More&/g'
find -name \*.java | xargs sed -i 's/Objects.firstNonNull/More&/g'
find -name \*.java | xargs sed -i 's/^\(import com.google.common.base.\)\(Objects.*\)/\1More\2\n\1\2/g'
find -name \*.java | xargs java -jar google-java-format-1.3-all-deps.jar -i --fix-imports-only --skip-sorting-imports
2017-08-22 17:12:53 -07:00
edbb2c0e6f
Log information according to the auth precedence
2016-10-19 10:45:50 +02:00
7dc73ee0bf
Do not try to connect to ssh if already connected
2016-08-12 00:39:28 +02:00
cdbf856900
Address error-prone AssertFalse warnings
2016-04-27 18:54:09 -07:00
66cda12b50
Avoid eager evaluation of Preconditions messages
...
Found via error-prone.
2016-04-24 23:28:55 -07:00
8859eaeb68
JCLOUDS-921 prioritise key over password in SessionConnection
2015-06-11 13:48:25 +02:00
f646b84c9e
Use ssh agent if privatekey and password are not set
2015-06-11 12:37:06 +02:00
7f38520314
JCLOUDS-884: Only try netcat over ssh-agent as an agentproxy
...
See http://markmail.org/thread/oto47qk2kzcdtebb
2015-04-09 09:48:40 -04:00
3980cd791b
Revert "JCLOUDS-653: Address Guava 18 deprecations"
...
This reverts commit 95cfc0d950
2014-10-24 10:45:58 -07:00
74fb8f0183
Add whitespace after semicolons
...
Also correct some bad line-wrapping.
2014-08-26 11:06:00 -07:00
95cfc0d950
JCLOUDS-653: Address Guava 18 deprecations
...
Mostly renaming Objects.toStringHelper to MoreObjects.toStringHelper.
2014-08-08 11:12:21 -07:00
1fb286809e
JCLOUDS-549: Fix NPE in LoginCredentials.toString
...
- also deprecates LoginCredentails.get(Password|PrivateKey)
- use getOptionalPassword and getOptionalPrivateKey instead
2014-07-18 14:09:18 +01:00
fb60d76704
JCLOUDS-622: Remove most vestiges of InputSupplier
...
Guava 16 deprecated InputSupplier and a future release will remove it.
2014-07-16 16:07:59 -07:00
9cdd53b0b7
JCLOUDS-546: Remove Javadoc @author annotations
...
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
bae4377dca
Prefer File.delete over File.deleteOnExit
...
The former has deterministic behavior and avoids resource leaks.
2014-05-23 16:17:10 -07:00
67c2b5f6b9
Enable whitespace around Checkstyle rule
2014-05-08 18:31:47 -07:00
aef9fc8d83
JCLOUDS-561: Properly populate the ssh agent connection in the builder methods
2014-05-08 08:52:58 +02:00
85a1a8c1dd
JCLOUDS-516: Add ssh agent support via sch agentproxy
2014-03-27 09:04:34 +01:00
c7b0f66544
Replace calls to Closeables.closeQuietly
...
Guava 16 removes this API. Replace with Closeables2.closeQuietly.
References JCLOUDS-413 and JCLOUDS-415.
2013-12-21 12:30:59 -08:00
17ce72794c
Enable RedundantModifier for Checkstyle
2013-10-31 10:23:30 -07:00
ed2f18a1af
JCLOUDS-31. updated to ASF headers via mvn com.mycila.maven-license-plugin:maven-license-plugin:format
2013-05-16 21:30:37 -07:00
fff2fa6e05
Address Checkstyle violations
...
This commit requires temporarily disabling some checks.
2013-04-17 16:21:21 -07:00
1f995879d6
Address FindBugs errors
2013-02-22 20:59:29 -08:00
3afdc3550e
add support for jsch proxy
2013-01-19 20:06:18 -08:00
dc4ca1efbd
removed deprecated methods which were easy to do
2013-01-19 08:32:45 -08:00
3ac6f475e7
unwound dependencies relating to ssh keys and crypt
2013-01-13 20:53:59 -08:00
3962b30808
updated to use standard guava Futures and ListenableFuture
2013-01-13 09:31:10 -08:00
42c7037a59
removed unused code or duplicated code; moved code only used once to where its used
2013-01-01 00:08:34 -08:00
bb953c981e
fix issue #1101 : Move to Guava 14 BaseEncoding and Hashing
2012-12-31 14:48:31 -08:00
878ec1bcab
undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false
2012-11-18 09:23:44 -08:00
3d191253ec
Enforce use of Collection helpers via Checkstyle
...
This ensures that we do not repeat the type name. Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
981b0d047f
Remove commons-io dependency from jsch
...
FilterInputStream suffices since we only override close and we can get
away with using java.io.ByteArrayOutputStream.
2012-11-03 10:29:48 -07:00
93d69ece2b
Enforce newline at end of file via Checkstyle
...
Also address all warnings, via:
find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
2b8b72758f
Prefer Files.toString over FileInputStream
2012-10-10 21:33:22 -07:00
985cccff9a
Prefer valueOf over explicit object creation
...
This allows use of cached values. Patched with:
find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
a40983a39d
Prefer InputSupplier helpers
...
These ensure that inputs are closed properly.
Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
05fd64af44
cleaned up http builders and expect tests
2012-07-15 01:50:38 -07:00
8c36f2c0d8
Issue #1016 : fix jsch hanging
2012-07-11 14:49:26 +01:00
95c35487f0
Issue 1004: changes default SocketOpen impl
...
Sets it to InetSocketAddressConnect, instead of SocketOpenUnsupported.
Removes overriding the impl from Jsch and Sshj's client modules.
2012-07-05 16:00:29 +01:00
381851b8ab
Remove IPSocket class, replace with Guava's HostAndPort class.
2012-04-25 17:52:01 -07:00
728f9612e0
moved logback.xml up to compute module
2012-03-21 13:05:03 -07:00
755485537b
allow execChannel to survive sshclient.disconnect, and not be bound by sessionTimeout
2012-03-10 13:25:12 -08:00
06ab36ae76
execChannel shouldn't allocate PTY
2012-03-10 10:15:44 -08:00
Andrew Gaul
Andrew Gaul
Jonathan Leitschuh
Ignasi Barrera
Huy TA
Andrew Phillips
Adrian Cole
Aled Sage
Pasi Niemi
Andrew Gaul
Adrian Cole
Adrian Cole
Matt Stephenson