Apache
/
jclouds
mirror of https://github.com/apache/jclouds.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,734 Commits 22 Branches 130 Tags 97 MiB
Commit Graph

1127 Commits

Author SHA1 Message Date
Adrian Cole 3afdcb66b3 Issue 981:Quiet down jclouds.compute logger 2012-06-16 18:27:29 -04:00
Adrian Cole 30ba717969 Issue 977:ec2 zones are not mapping to endpoints 2012-06-15 23:36:17 -04:00
Adrian Cole a928746528 Issue 976:update to support eucalyptus 3 2012-06-15 23:35:18 -04:00
Adrian Cole d29fbba783 Issue 980: timestamp on ec2 requests are in the future 2012-06-15 23:35:17 -04:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00
Adrian Cole 69d7e1d585 cloudbridge exposes a slightly different xml format for RunningInstances 2012-06-15 23:31:39 -04:00
Adrian Cole 8a34254c8e in CloudBridge terminatedInstances go away quickly unveiling the need to address instanceId not found 2012-06-15 23:31:33 -04:00
Adrian Cole 71869a6bb3 Merge pull request #674 from aledsage/ec2-Windows-ImageOsParsing 
EC2ImageParser checks platform==windows for OsFamily
 2012-06-14 20:46:20 -07:00
Aled Sage a8b3eb4c2c EC2ImageParser checks platform==windows for OsFamily 2012-06-14 20:52:46 +01:00
Andrew Gaul 736554d049 Correct spelling errors 2012-06-14 10:03:39 -04:00
Ioannis Canellos 4704e29941 Fixed openstack and openstack-keystone OSGi headers. 2012-06-13 13:05:42 +03:00
Adrian Cole 1fdfe5761f attempting to operate against or retrieve pieces of a resource that doesn't exist should result in a ResourceNotFoundException, not null 2012-06-08 11:05:52 -07:00
Adrian Cole 70fa2b6c6d style 2012-06-08 11:05:09 -07:00
Andrei Savu 16afe38477 Fix guice cache binding issue for live tests 2012-06-08 10:56:20 -07:00
Adrian Cole 72493161ab Issue 965:transition openstack-nova from v1_1 package to v2_0 2012-06-08 10:35:58 -07:00
Adam Lowe 18faff54b3 openstack-keystone: adding TypeAdaptorFactory to take care of unwrapping objects containing an array of "values" in place of a normal json array 2012-06-08 11:23:41 +01:00
Adam Lowe 9718634570 openstack-keystone: reducing ServiceClient to simply listTenants() 2012-06-08 10:30:35 +01:00
Adrian Cole 46b4a6c8da Issue 963:add transitional api for keystone-authenticated swift 2012-06-07 22:06:18 -07:00
Adrian Cole f3950d6ae7 Merge branch 'cloudstack-qa' of https://github.com/andreisavu/jclouds 
* 'cloudstack-qa' of https://github.com/andreisavu/jclouds:
  Fixed typo DELETEING to DELETING
  A few more skips & small fixes
  I think I got AdvancedNetworkOptionsConverter figured out.
  A bunch of work to get things actually working with CS3.x api.
  Skip a few more tests & accept accounts with no keys attached
  Fixed template status, network selection and domain live tests
  Reduced the number of failing tests from 48 to 23
 2012-06-07 17:34:11 -07:00
Adrian Cole 9cff013bb8 Merge pull request #665 from grkvlt/ec2-get-console-output 
Issue 960: Add EC2 GetConsoleOutput API call
 2012-06-07 17:26:53 -07:00
Andrei Savu 9b644fcceb Fixed typo DELETEING to DELETING 2012-06-07 23:47:29 +03:00
Andrei Savu 1a9ea265cd Merge branch 'master' of github.com:jclouds/jclouds into cloudstack-qa 2012-06-07 22:55:00 +03:00
Andrei Savu bc22b99dee A few more skips & small fixes 2012-06-07 22:54:19 +03:00
Adrian Cole 12e57eec53 made admin features optional and url based on adminURL for identity service in catalog 2012-06-07 10:24:58 -07:00
Andrew Bayer 1261a4c9b0 I think I got AdvancedNetworkOptionsConverter figured out. 
Also made sure not to try to remove FirewallRules unless there's a
public IP in the first place.
 2012-06-07 12:46:01 +03:00
Andrew Bayer e6eaa2e192 A bunch of work to get things actually working with CS3.x api. 
Note that AdvancedNetworkOptionsConverter is still...strange. I'm
really not sure what it should be doing.
 2012-06-07 12:45:08 +03:00
Andrei Savu 2be3fa34be Skip a few more tests & accept accounts with no keys attached 2012-06-07 12:44:18 +03:00
Andrei Savu a83aa71087 Merge branch 'master' of github.com:jclouds/jclouds into cloudstack-qa 2012-06-07 11:25:44 +03:00
Adrian Cole d00e360d65 Issue 815: refactored the 3 major features of keystone into separate clients. removed cyclic dependency needed to support keystone controlling keystones in other regions 2012-06-06 23:14:23 -07:00
Andrew Donald Kennedy 7fd1c65575 Issue 960: Add EC2 GetConsoleOutput API call 2012-06-07 03:45:44 +01:00
Adrian Cole 6cfa5877f3 incorrectly added file 2012-06-06 16:35:34 -07:00
Adrian Cole b58060599b Issue 815: repackaged keystone classes into their own api 2012-06-06 14:57:50 -07:00
Andrei Savu 134797844a Fixed template status, network selection and domain live tests 2012-06-06 23:37:05 +03:00
Andrei Savu 03867b97b2 Reduced the number of failing tests from 48 to 23 
* ID equality test fixes. Changed from == to .equals
* throw ResourceNotFoundException for all server responses
with code 431 that contain "does not exist"
* skip tests rather than failing when running the suite
as a regular or domain admin user. It's not possible to
have global admin access on public clouds
 2012-06-06 16:53:57 +03:00
Adrian Cole bcd3d50ad6 Issue 956:add getImage by id to ComputeService 2012-06-04 16:54:49 -07:00
Adrian Cole ef31f5114d added rawState to RunningInstance 2012-06-04 16:54:30 -07:00
Adrian Cole 92d1f1b471 moved to explicitly adding clojure projects 2012-06-03 17:28:56 -07:00
Adrian Cole 5a3f6011a2 removed junit test dependency 2012-06-03 17:26:57 -07:00
Ioannis Canellos b078adc3ce Removed fragments and dynamic imports. Added centralized control of the maven-bundle-plugin. 2012-06-03 19:41:54 +03:00
Adrian Cole b0014ec70b Issue 950:cloudstack Template.status is an opaque string 2012-06-01 19:24:23 -07:00
vijaykiran 6d74805dd9 Issue-953 Make sure that port is set when modifying headers 2012-06-01 23:02:56 +02:00
Adrian Cole 96773b8a1b Issue 952:add status field to image 2012-05-30 21:22:10 -07:00
hhrasna ef17ef23ea EC2 image architecture can be null. Don't throw NPE if architecture is null. 2012-05-30 20:45:20 -03:00
Adrian Cole 07c2c24721 Issue 949:Introduce: ComputeMetadataIncludingStatus; Deprecate NodeState -> NodeMetadata.Status 2012-05-29 20:41:10 -07:00
Adrian Cole cd08ce98cc addressed nullables 2012-05-26 09:31:41 -07:00
Adrian Cole 84de4b30db fixed CloudWatch.putMetricData 2012-05-26 09:31:22 -07:00
Jeremy Whitlock c7d09a5951 Follow up to 9f1ca865e8 that addresses Pull Request 651 feedback. 
* Removed all validation from the builders
* All objects build with builders have @Nullable for getters
* Removed PutMetricData object
* CloudWatch.putMetricData added as a helper to allow publishing more than 10
  metrics at a time
 2012-05-26 00:37:41 -06:00
Jeremy Whitlock 9f1ca865e8 Implement PutMetricData for CloudWatch. 
* Added support to create custom metrics in CloudWatch
* Fixed bug in Datapoint parsing that caused Sample(Count) to be null
 2012-05-25 13:39:14 -06:00
Adrian Cole 17079743f1 cloudservers test fixes 2012-05-21 20:19:58 -06:00
Adrian Cole d480639214 Merge pull request #647 from abayer/master 
Fixing a few more %d
 2012-05-21 14:24:58 -07:00
Andrew Bayer 5748277fe3 Fixing a few more %d format errors. 2012-05-21 14:14:49 -07:00
Adrian Cole 67d8f9a0f4 image extension related classes under extensions package 2012-05-21 12:39:32 -06:00
Adrian Cole c9f4143133 unraveled injector a bit 2012-05-21 12:12:07 -06:00
Adrian Cole 7082b9a70d cloudstack logging working 2012-05-21 11:55:40 -06:00
Andrew Bayer 792ad9dcb9 Initial CloudStack 3.0 compatibility work. 2012-05-21 10:48:39 -07:00
Adrian Cole d0947bbda0 fixed NPE 2012-05-21 02:45:34 -06:00
Adrian Cole 5c647df129 Issue 938:TemplateBuilderSpec 2012-05-21 02:45:25 -06:00
Adrian Cole 0c4b196604 fixed tests 2012-05-21 01:03:30 -06:00
Adrian Cole 94404841ca allow use of tenantId when specified numeric 2012-05-20 14:39:32 -07:00
Adrian Cole 991fe011b3 openstack-nova works with tags now 2012-05-18 19:57:01 -07:00
Adrian Cole 8e7bec1c91 cloudservers works with tags now 2012-05-18 19:56:44 -07:00
Adrian Cole a53cece32d Issue 445: moved incidental test into its own class until we can convert it to an expect test 2012-05-18 17:49:59 -07:00
Andrew Bayer 4a1e7e0005 Refactoring hashcodes/equals. 2012-05-18 11:41:39 -07:00
Aled Sage 2637a4b6e9 Issue 647: DateCodec impl delegates to DateService 2012-05-17 11:25:13 +01:00
Aled Sage cd9c830c5a Issue 647: store Expires as Date; added ContentMetadataCodec for converting to/from HTTP headers 2012-05-17 11:24:50 +01:00
Aled Sage 9aedf7b6f6 Issue 647: added "Expires" header for ContentMetadata 2012-05-17 11:24:45 +01:00
Adrian Cole 96e272a91d Issue 925: added default ctors so that gson can work w/o using sun.misc.Unsafe 2012-05-16 14:51:16 -07:00
Andrew Gaul dbb56e64da Remove quirky isSame method 
Use safer InputSupplier instead.
 2012-05-15 11:37:22 -07:00
Andrew Gaul f55231d607 Tolerate oversized ranges in getBlob 2012-05-14 15:16:32 -07:00
Adrian Cole c223f73762 Merge pull request #635 from andrewgaul/filesystem-transient-copyblob 
Hamonize filesystem and transient copyBlob
 2012-05-14 14:42:04 -07:00
Adrian Cole d144d94f60 Merge pull request #634 from andrewgaul/filesystem-transient-loadblob 
Harmonize filesystem and transient loadBlob
 2012-05-14 14:09:14 -07:00
Andrew Gaul 9b6cf5ea21 Hamonize filesystem and transient copyBlob 2012-05-14 13:36:21 -07:00
Andrew Gaul 1199c54f67 Harmonize filesystem and transient loadBlob 
Move getBlob into FilesystemStorageStrategyImpl, similar to
TransientStorageStrategy.
 2012-05-14 13:06:19 -07:00
Adrian Cole 3668ca497e Merge pull request #633 from andrewgaul/filesystem-transient-getblob 
Harmonize filesystem and transient getBlob
 2012-05-14 12:47:14 -07:00
Andrew Gaul a30aad05ed Harmonize filesystem and transient getBlob 
This commit also simplifies HTTP range logic calculations, sets the
correct Content-Length, and avoids an unneeded copy.
 2012-05-14 11:02:03 -07:00
Adrian Cole 8e27b180aa Merge pull request #632 from andrewgaul/static-block 
Throw exceptions in static blocks
 2012-05-14 10:22:47 -07:00
Andrew Gaul d45404a338 Throw exceptions in static blocks 
This reports any errors instead of silently ignoring them.
 2012-05-14 09:37:20 -07:00
Adam Lowe cc016d5dc8 Adjusting MapBinder to take Map<String,Object> so BindToJsonPayload can bind objects annotated with PayloadParam correctly 2012-05-14 13:09:22 +01:00
Adam Lowe 95399121bd openstack-nova: Adding Volume Types extension 2012-05-13 08:55:29 +01:00
Adam Lowe 987f2f93c6 openstack-nova: Adding Quota and Quota Class extensions 2012-05-13 08:55:29 +01:00
Adam Lowe 7f101267e6 openstack-nova: Adding Flavor Extra Specs extension 2012-05-13 08:55:28 +01:00
Adam Lowe d5b2968a54 openstack-nova: Adding HostAggregates extension 2012-05-13 08:55:28 +01:00
Adam Lowe 5228a14fbb openstack-nova: Adding actions to HostAdministration extension 2012-05-13 08:55:28 +01:00
Adam Lowe f790607ffb openstack-nova: Adding field from Flavor Extra Data extension 2012-05-13 08:55:27 +01:00
Andrew Gaul 191a4e7341 Identity should be tenameName:accessKey 
tenantId is something else.  Tested against hpcloud.
 2012-05-11 15:34:41 -07:00
Adrian Cole e461db5952 fixed test expectation glitch 2012-05-10 19:47:21 -07:00
Adrian Cole 3d67f26811 fixed test expectation glitch 2012-05-10 19:40:46 -07:00
Adrian Cole bd15314609 fixed test expectation glitch 2012-05-10 19:39:22 -07:00
Adrian Cole 8abd56b1c7 fixed test expectation glitch 2012-05-10 19:35:10 -07:00
Adrian Cole 5340e947d3 while image can be null in templateBuilder, image will never be null in a template 2012-05-10 17:19:29 -07:00
Adrian Cole 59f2b6d171 Merge pull request #625 from aledsage/Issue-888-GroupNamingConvention 
Issue 888 group naming convention
 2012-05-10 16:45:39 -07:00
Adrian Cole a6cc00e078 Merge pull request #603 from dralves/image-extension-all 
image extension working on hpcloud, virtualbox and aws-ec2, cloudservers...
 2012-05-10 16:43:27 -07:00
David Ribeiro Alves f71e1d5780 fixed a transient status bug in openstack-nova (working on hpcloud) 2012-05-10 19:31:50 +01:00
David Ribeiro Alves fe7d426e2e fixed a cloudservers bug 2012-05-10 18:27:49 +01:00
Aled Sage 94ac48070d Issue 888: use GroupNamingConvention for keyName/securityGroup; don't include region in name 2012-05-10 16:47:37 +01:00
Adrian Cole 8163b6ee64 Merge pull request #623 from jcscoobyrs/master 
Issue 922: Add missing javadoc to CloudWatch.listMetrics(MetricClient, ListMetricsOption).
 2012-05-10 01:33:32 -07:00
David Ribeiro Alves f63c5a44c6 corrected formating issues and added headers 2012-05-10 09:07:12 +01:00
David Ribeiro Alves 129d827355 implemented ec2 expect tests 2012-05-10 08:42:45 +01:00
David Ribeiro Alves fc159d1686 cloudservers imageextension expect tests are passing 2012-05-10 07:33:53 +01:00
David Ribeiro Alves c7469bbf4a cloudservers and ec2 imageextension expect tests on the way 2012-05-10 06:54:13 +01:00
Jeremy Whitlock 934b8388e6 Issue 922: Add missing javadoc to CloudWatch.listMetrics(MetricClient, ListMetricsOption). 
* Follow-up to b820b326b4
 2012-05-09 20:43:33 -06:00
Adrian Cole c7f949d1c1 Merge pull request #622 from jcscoobyrs/master 
Issue 922: Create CloudWatch.listMetrics(MetricClient, ListMetricsOptions) API.
 2012-05-09 18:29:35 -07:00
Jeremy Whitlock b820b326b4 Issue 922: Create CloudWatch.listMetrics(MetricClient, ListMetricsOptions) API. 2012-05-09 19:26:45 -06:00
Adrian Cole f0a8870b80 Issue 919: ensure filters work on multi-zone openstack-nova 2012-05-09 18:22:34 -07:00
David Ribeiro Alves 176647110a added expect test 2012-05-10 01:33:31 +01:00
Adrian Cole 9a4e5fd7d8 Merge pull request #619 from aplowe/openstack-nova 
openstack-nova: fixing NPE in CreateServerOptions.string()
 2012-05-09 08:42:15 -07:00
Andrew Donald Kennedy cffeeb0eab Not everyone lives in US-CA 2012-05-09 16:34:33 +01:00
Adam Lowe 2c82ab2832 openstack-nova: fixing NPE in toString() 2012-05-09 16:21:26 +01:00
Andrew Phillips 29e7e7e85e Revert "Merge pull request #617 from andrewgaul/filesystem-transient-remove-copy" 
This reverts commit 0fe120d659, reversing
changes made to 5033b98252.
 2012-05-08 23:37:19 -07:00
Andrew Gaul d13e8aec4a Remove unused copy method 
Also make second copy method private access.
 2012-05-08 21:08:03 -07:00
Mathieu Guillaume d8472b799a openstack-nova: fix camelCase for userData in NovaTemplateOptions 2012-05-08 17:15:32 -07:00
Mathieu Guillaume ab22b0606b openstack-nova: add support for user-data 2012-05-08 17:15:31 -07:00
Adam Lowe a45d079b8c openstack-nova: adding EXTENDED_STATUS to ExtensionNamespaces 2012-05-08 17:03:25 -07:00
Adam Lowe 1797b27ed4 Adding OptionalTypeAdaptorFactory to handle the parsing of Optional values 2012-05-08 17:03:18 -07:00
Andrew Gaul 4ac7629f44 Delegate blob storage to TransientStorageStrategy 
This further minimizes the drift between the filesystem and transient
blobstores.  We also now require that users keep the BlobStoreContext
open instead of using ConcurrentMap singletons.  Finally we remove the
"stub" container.
 2012-05-08 14:11:32 -07:00
Adrian Cole 743773aeef formatting 2012-05-08 10:14:14 -07:00
Adrian Cole 39e6f84f4b Merge pull request #612 from andrewgaul/transient-storage-strategy 
Introduce TransientStorageStrategy
 2012-05-07 17:14:10 -07:00
Andrew Gaul 442c51eb3c Introduce TransientStorageStrategy 
This allows code from the filesystem blobstore to be more similar to
the transient blobstore.  This commit also corrects a bug where
blobExists did not throw an exception when the container did not
exist.
 2012-05-07 16:52:31 -07:00
Adrian Cole 015a89cdcd Merge pull request #611 from andrewgaul/reduce-filesystem-transient-diff 
Reduce filesystem and transient differences
 2012-05-07 16:29:33 -07:00
Andrew Gaul 3a0c15b345 Reduce filesystem and transient differences 
These providers have a similar lineage but many gratuitous
differences.  This commit reduces the diff between them and is a
prerequisite for upcoming changes to make them more similar to each
other and real providers.  Some future commit might unify these in
some smarter way, e.g., having a TransientStrategy to match
FilesystemStrategy.
 2012-05-07 15:55:05 -07:00
Andrew Gaul 7cbfd42736 Do not check for equality on overwrites 
Firstly, this check never triggered because Payload.equals always
returns false for File objects.  Secondly, this would not reduce IO
even if it worked since the common case is not overwriting a file with
the same contents.  Lastly, simplify a cast.
 2012-05-07 13:35:02 -07:00
Adam Lowe 653d5ccc4b openstack-nova: Adjusting names of ServerWithSecurityGroups related calls 2012-05-04 18:26:45 +01:00
Adam Lowe 33b4a2d253 openstack-nova: Wiring AdminActions extension into compute service to implement suspend and resume 2012-05-04 18:22:40 +01:00
Adam Lowe 7678c6e776 openstack-nova: Adding Admin Actions client to allow extra actions to be performed on servers 2012-05-04 18:22:40 +01:00
Adam Lowe e95e6df805 openstack-nova: Adjusting Resource and it's descendants to new builder pattern 2012-05-04 18:22:26 +01:00
Adam Lowe 06d3ef02ba openstack-nova: Adding CREATESERVEREXT extension (renamed ServerWithSecurityGroupsClient to be clear about what's on offer) 2012-05-04 16:45:04 +01:00
Adam Lowe 42df3d339c openstack-nova: Adding Virtual Interface extension 2012-05-04 16:45:04 +01:00
Adam Lowe e5b45beb4c openstack-nova: ensuring we use the smallest available flavor when creating servers in live tests (else devstack fails, badly) 2012-05-04 16:45:04 +01:00
Adrian Cole e830af8cd9 Merge pull request #605 from andrewgaul/filesystem-test-close-streams 
Close streams in filesystem tests
 2012-05-03 16:28:41 -07:00
Andrew Gaul 0903d8522a Close streams in filesystem tests 
Windows cannot delete open files and this may have caused test
failures.  References #912.
 2012-05-03 09:22:53 -07:00
Adam Lowe 9ca544306e openstack-nova-ec2: adding NovaEC2KeyPairClient with importKeyPair improving expect tests 2012-05-03 12:49:09 +01:00
Adam Lowe 136e1eeff3 openstack-nova-ec2: adding NovaEC2KeyPairClient with importKeyPair expect and live tests 2012-05-03 12:38:57 +01:00
Adam Lowe 05521685cd openstack-nova-ec2: adding NovaEC2KeyPairClient with importKeyPair method and wiring it into rest context 2012-05-03 12:38:30 +01:00
Adam Lowe 204194ad61 openstack-nova-ec2: configuring tests to use logback (so I can view the jclouds-wire log) 2012-05-03 12:35:32 +01:00
Adam Lowe 850cdc2fc8 Moving EncodedRSAPublicKeyToBase64 (and corresponding unit test) up into EC2 so both openstack-nova-ec2 and aws-ec2 can share the same class 2012-05-03 12:31:39 +01:00
David Ribeiro Alves 082158ac3f image extension working on hpcloud, virtualbox and aws-ec2, cloudservers implemented but has issues 2012-05-03 03:55:40 +01:00
Adrian Cole 19390ea87d Merge pull request #602 from andrewgaul/propagate-or-null 
Eliminate Throwables2.propagateOrNull
 2012-05-02 15:21:30 -07:00
Adrian Cole 079b39a235 Merge pull request #601 from andrewgaul/throwables-propagate 
Improve use of Throwables.propagate
 2012-05-02 15:08:32 -07:00
Andrew Gaul 74440a7a87 Eliminate Throwables2.propagateOrNull 
Throwables.propagate always propagates the Throwable; there is no need
to return null.
 2012-05-02 13:51:36 -07:00
Andrew Gaul 646f8d8b13 Improve use of Throwables.propagate 
Throwing the return value removes some unneeded asserts and return
statements.  Also remove some useless and misspelled propogate
wrappers.
 2012-05-02 11:05:22 -07:00
Adam Lowe 7c317b80e8 openstack-nova-ec2: work-around for dates encoded as '-' when they should be null (the should not be present in the response!) 2012-05-02 17:34:00 +01:00
Andrew Phillips 42d57c5d15 Fix a test compilation error in Atmos caused by 755d51ad27 2012-05-02 08:04:40 -07:00
Andrew Gaul 755d51ad27 Remove unused transient blobstore methods 
Also make some helpers private.  Generally, make the transient
blobstore more similar to others.
 2012-05-01 22:37:01 -07:00
Adrian Cole 2d8f5ec807 modernized cloudwatch 2012-05-01 10:11:01 -07:00
Jeremy Whitlock 13d80f7d3a Follow up to f06d273 that addresses pull request comments. 
* Adds region to the listMetrics and getMetricStatisticsV2
* Fixed hashCode implementations
* Fixed typo in Datapoint.equals()
 2012-04-30 23:46:30 -06:00
Jeremy Whitlock f06d273764 Follow up to e58d91e that addresses pull request comments. 2012-04-30 22:00:25 -06:00
Jeremy Whitlock e58d91e78d Extended support to apis/cloudwatch for getting metrics. 
* Updated to allow supplying any dimension to describe the metric
* Updated to allow supplying more than one statistic to retrieve
 2012-04-27 18:43:08 -06:00
Jeremy Whitlock 82533729da Add support to apis/cloudwatch for listing stored metrics. 
* Also adds some useful constants for CloudWatch dimensions, metric names and namespaces
 2012-04-26 19:14:30 -06:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Richard Downer 18a65bf1a7 Move WindowsClientLiveTest from ec2 to aws-ec2 as it depends on AWS's published AMIs and naming conventions 2012-04-25 20:18:13 +03:00