8ed0e28e68
Spelling corrections
2012-07-26 22:39:35 -07:00
92f9cc4c0c
Merge pull request #756 from andrewgaul/reorder-strategy
...
Shuffle strategy methods into consistent order
2012-07-26 17:04:39 -07:00
f5548f3a94
Shuffle strategy methods into consistent order
...
Group by container, blob, and miscellaneous methods. Within these
groups, sort by by exists, getter, setter, and remove. Code movement
only; no functional changes.
2012-07-26 13:52:23 -07:00
ead8748199
Avoid unneeded branch in LocalAsyncBlobStore
2012-07-26 13:44:14 -07:00
6b8a2a73d4
Add missing @Override in TransientStorageStrategy
2012-07-23 13:31:21 -07:00
562f8277d3
Introduce LocalAsyncBlobStore
...
This commit unifies the filesystem and transient blobstores.
2012-07-23 09:20:41 -07:00
756e46333f
Miscellaneous local blobstore cleanups
...
There are no more functional differences between the filesystem and
transient blobstores. This is the last commit before introducing a
unified LocalAsyncBlobStore class.
2012-07-23 08:06:36 -07:00
b890765e9e
Merge pull request #738 from andrewgaul/local-blobstore-move-helper-method
...
Move helper method to TransientStorageStrategy
2012-07-23 07:37:30 -07:00
d5f9bb3172
Merge pull request #739 from andrewgaul/prefer-valueof
...
Prefer valueOf over explicit object creation
2012-07-22 22:00:09 -07:00
985cccff9a
Prefer valueOf over explicit object creation
...
This allows use of cached values. Patched with:
find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
22da88d2ae
Move helper method to TransientStorageStrategy
...
Also move etag generation since we cannot reuse Payloads in the
general case.
2012-07-22 20:02:59 -07:00
0bc5c69a4f
Move copy(MutableBlobMetadata) to BlobStoreUtils
2012-07-22 17:37:18 -07:00
870ed0cdb3
Shuffle blobstore parameters to match superclass
...
Also remove unused injected parameter.
2012-07-19 07:17:02 -07:00
70fa74df1a
Merge pull request #731 from andrewgaul/input-supplier
...
Prefer InputSupplier helpers
2012-07-19 04:34:25 -07:00
a40983a39d
Prefer InputSupplier helpers
...
These ensure that inputs are closed properly.
Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
a2d5a48f3f
Inject TransientStorageStrategy
...
Remove some unneeded checkNotNull as Guice does not inject null
parameters.
2012-07-18 16:02:07 -07:00
8a9265f015
Tie up odds and ends from LocalStorageStrategy
...
Use LocalStorageStrategy instead of TransientStorageStrategy and
handle IOExceptions. Aso use dummy location in filesystem blobstore.
2012-07-18 09:45:23 -07:00
c30c2c4809
Introduce LocalStorageStrategy
...
This commit will allow eventual unification of the filesystem and
transient blobstores. No functional changes -- rename
FilesystemStorageStrategy to LocalStorageStrategy and implement it in
FilesystemStorageStrategyImpl and TransientStorageStrategy.
2012-07-17 23:11:10 -07:00
007eba6d7c
Merge pull request #723 from andrewgaul/filesystem-transient-input-supplier
...
Ensure we close streams via InputSupplier methods
2012-07-17 15:23:47 -07:00
bd5bf0dad2
Ensure we close streams via InputSupplier methods
2012-07-17 11:46:10 -07:00
d89153ed1f
Reduce filesystem and transient differences
2012-07-17 09:50:47 -07:00
02203afb07
Harmonize filesystem and transient putBlob
2012-07-16 22:02:00 -07:00
05fd64af44
cleaned up http builders and expect tests
2012-07-15 01:50:38 -07:00
74b404eab8
Issue 1008:aws-s3 could not get location for region eu-west-1 error
2012-07-07 17:28:44 -07:00
932b738026
Eliminate unlikely transient blobstore TOCTOU bug
2012-06-19 15:20:39 -07:00
227dbf777a
Correct spelled from delimeter to delimiter
2012-06-14 10:05:13 -04:00
ffe783d92b
Issue 936: fixes async multi-part upload of small blob
...
Previously, the upload did not start...
2012-05-21 15:39:27 +01:00
cd9c830c5a
Issue 647: store Expires as Date; added ContentMetadataCodec for converting to/from HTTP headers
2012-05-17 11:24:50 +01:00
9aedf7b6f6
Issue 647: added "Expires" header for ContentMetadata
2012-05-17 11:24:45 +01:00
1b2eb74604
Issue 656: failing test, demonstrating failures when non-default aws-s3 location is specified
2012-05-14 23:18:30 -07:00
f55231d607
Tolerate oversized ranges in getBlob
2012-05-14 15:16:32 -07:00
a30aad05ed
Harmonize filesystem and transient getBlob
...
This commit also simplifies HTTP range logic calculations, sets the
correct Content-Length, and avoids an unneeded copy.
2012-05-14 11:02:03 -07:00
29e7e7e85e
Revert "Merge pull request #617 from andrewgaul/filesystem-transient-remove-copy"
...
This reverts commit 0fe120d6595033b98252
2012-05-08 23:37:19 -07:00
d13e8aec4a
Remove unused copy method
...
Also make second copy method private access.
2012-05-08 21:08:03 -07:00
5033b98252
NPE guard
2012-05-08 17:50:07 -07:00
4ac7629f44
Delegate blob storage to TransientStorageStrategy
...
This further minimizes the drift between the filesystem and transient
blobstores. We also now require that users keep the BlobStoreContext
open instead of using ConcurrentMap singletons. Finally we remove the
"stub" container.
2012-05-08 14:11:32 -07:00
442c51eb3c
Introduce TransientStorageStrategy
...
This allows code from the filesystem blobstore to be more similar to
the transient blobstore. This commit also corrects a bug where
blobExists did not throw an exception when the container did not
exist.
2012-05-07 16:52:31 -07:00
3a0c15b345
Reduce filesystem and transient differences
...
These providers have a similar lineage but many gratuitous
differences. This commit reduces the diff between them and is a
prerequisite for upcoming changes to make them more similar to each
other and real providers. Some future commit might unify these in
some smarter way, e.g., having a TransientStrategy to match
FilesystemStrategy.
2012-05-07 15:55:05 -07:00
19390ea87d
Merge pull request #602 from andrewgaul/propagate-or-null
...
Eliminate Throwables2.propagateOrNull
2012-05-02 15:21:30 -07:00
74440a7a87
Eliminate Throwables2.propagateOrNull
...
Throwables.propagate always propagates the Throwable; there is no need
to return null.
2012-05-02 13:51:36 -07:00
646f8d8b13
Improve use of Throwables.propagate
...
Throwing the return value removes some unneeded asserts and return
statements. Also remove some useless and misspelled propogate
wrappers.
2012-05-02 11:05:22 -07:00
755d51ad27
Remove unused transient blobstore methods
...
Also make some helpers private. Generally, make the transient
blobstore more similar to others.
2012-05-01 22:37:01 -07:00
09e8ff1d8e
Merge pull request #597 from andrewgaul/simplify-transient-blobstore
...
Simplify transient blobstore logic
2012-05-01 18:48:39 -07:00
253fd1f608
Simplify transient blobstore logic
...
Many more simplifications remain.
2012-05-01 14:17:00 -07:00
519a3ac193
Recurse in subdirectories before deleting blobs
...
This ensures that we have at most one PageSet of Futures awaiting
completion.
2012-05-01 11:18:24 -07:00
8ab9904481
added tests
2012-05-01 08:22:56 -07:00
c7dc1213f0
Do not set member until we completely validate it
2012-04-30 15:09:37 -07:00
e4514240e0
Optimize clearContainer for large folders
...
Previously we built up a list of all blobs then executed removeBlob on
all of them simultaneously. For sufficiently large folders this would
cause an OutOfMemoryError. There are cleaner ways to write this but
this approach mimimizes the patch. I will continue working on this in
subsequent commits, including optimizing for deep subdirectories.
This commit also fixes a bug in the transient blobstore where deleting
elements while reading a directory resulted in NoSuchElementException.
2012-04-28 17:11:13 -07:00
ba7ba36d20
switched to buildView
2012-04-24 12:26:37 -07:00
df7d2acbb4
wrapper -> view
2012-04-23 19:14:36 -07:00
Andrew Gaul
Adrian Cole
Aled Sage
Andrew Phillips