Commit Graph

44 Commits

Author SHA1 Message Date
Adrian Cole 6e554298ab ensure extra metadata from provider doesn't trip metadata tests 2013-01-01 17:18:55 -08:00
Adrian Cole 42c7037a59 removed unused code or duplicated code; moved code only used once to where its used 2013-01-01 00:08:34 -08:00
Adrian Cole 9745e9dc2f fixed covariance and warnings on ApiMetadata subclasses 2012-12-31 19:40:49 -08:00
Adrian Cole bb953c981e fix issue #1101: Move to Guava 14 BaseEncoding and Hashing 2012-12-31 14:48:31 -08:00
Adrian Cole cddd35bc51 removed unnecessary generic types and made RestAnnotationProcessor immutable 2012-12-30 23:18:59 -08:00
Adrian Cole 2523ab54ac removed use of static fields to share type mapping info 2012-12-30 17:22:03 -08:00
Adrian Cole 13d8b9c402 replaced @Timeout w/explicit properties 2012-12-30 12:31:43 -08:00
Adrian Cole ba156b7552 Merge pull request #1100 from andrewgaul/close-payload
Close Payload directly
2012-12-27 18:26:05 -08:00
Andrew Gaul 614e262ce0 Close Payload directly 2012-12-27 17:35:25 -08:00
Adrian Cole 9b1872c6ff removed custom code that duplicates functionality of guava fallbacks 2012-12-27 16:54:31 -08:00
Adrian Cole 20c3426fc8 replaced jersey w/Uris & UriTemplates; removed complexity in url encoding and edge cases like matrix params 2012-12-24 14:32:59 -08:00
Adrian Cole 847b1c7352 Merge pull request #1090 from jclouds/no-matrix
removed explicit matrix param support as their use is edge case in rest
2012-12-23 09:28:45 -08:00
Adrian Cole 3be1089538 removed explicit matrix param support as their use is edge case in rest 2012-12-22 17:45:31 -08:00
Ignasi Barrera 3abaa91cd4 Add Network Service Type functionality.
Until Abiquo 2.2, all the NICs of the virtual machines were attached to
the same physical Network Interface in the target physical machine,
since only one NIC per Virtual Machine was 'enabled'.

Starting from Abiquo 2.3, managed hosts can assign different 'Network Service Types'
to their Network Interfaces. The goal is to define what type of network is attached to each
NIC and have more control about how public and external VLANs are managed.
2012-12-19 10:16:09 +01:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul 42a3f4a3f9 Enforce use of StringBuilder via Checkstyle
Callers usually do not intend to use a synchronized StringBuffer.
EasyMock requires use of StringBuffer in some situations.
2012-11-12 08:24:36 -08:00
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul 9d643b569a Enforce a single variable declaration per line 2012-11-04 17:37:16 -08:00
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Ignasi Barrera f39c1add89 Removed all unnecessary interfaces from strategies
Removed all interfaces from the strategy classes that only have one
implementation.
2012-10-31 19:00:32 +01:00
Ignasi Barrera 5ba08d8448 Cleanup unnecessary strategies
Removed all over engineering introduced by strategies that did
not perform anything else than a simple api call.
2012-10-31 18:46:16 +01:00
Ignasi Barrera 98787ecc00 Override setupContext and tearDownContext to avoid ordering issues when running live tests 2012-10-30 17:13:09 +01:00
Susana Acedo 6b257340eb Added live tests in the Abiquo provider
This commit adds a few more relevant live tests to be executed by any
user, covering the virtual machine deployment and their lifecycle.
2012-10-30 11:21:18 +01:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul e9edce7bae Merge pull request #925 from aledsage/upgrade-dependencies
Version upgrades
2012-10-29 11:08:27 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Ignasi Barrera 7bd6b016ab Added unit tests for the timeunit field and fixed javadoc 2012-10-24 19:40:32 +02:00
Ignasi Barrera 25bd57379d Use the TimeUnit parameter in async monitor 2012-10-24 18:16:06 +02:00
Ignasi Barrera 875563d0f1 Formatted code following jclouds guidelines
This commit formats all the Abiquo provider following the jclouds
formatting guidelines. It uses the Eclipse default formatting
configuration and a 3 spaces indentation and a line wrap fo 120
characters.
2012-10-22 20:28:56 +02:00
Ignasi Barrera e9502ab81e Applied fixes suggested in last review
Renamed VirtualMachineTemplateWithZone to
VirtualMachineTemplateInVirtualDatacenter and encoded the id using a
slash instead of the hyphen.
2012-10-21 22:46:14 +02:00
Ignasi Barrera 26f801058d Improved ComputeService and delegate virtual datacenter election to TemplateBuilder
Made a few changes to adapt the Abiquo compute service
implementation to the most common use cases:

* Do not attempt to create a VDC. Regualr users may not have
  permissions to create VDCs, so don't try to create them. A
  VDC compatible with teh template being deployed must exist.
* Configure nodes with one public ip by default, and if no
  public ip is available, assign one from the default private
  VLAN for the selected virtual datacenter.

Also fixed some concept mappings between Abiquo and jclouds:

Virtual datacenter (zone) election should be performed by the
TemplateBuilder and not by the ComputeServiceAdapter. This commit
refactors the current adapter to implement the right behavior.

The two main concepts in this refactor are about locations. Now,
physical datacenters will be scoped to Region locations, and virtual
datacenters to Zones.

Images in Abiquo are scoped to Regions (each physical datacenter has a
set of available images), and hardware profiles will be used to scope
images to a particular virtual datacenter. Since a virtual datacenter in
Abiquo is just a container that provides compute resources in a specific
virtualization technology, each image will have one hardware profile
scoped to each compatible virtual datacenter (zone).

This way, the virtual datacenter election will be made using the
TemplateBuilder, by selecting the desired hardware profile.
2012-10-20 21:25:51 +02:00
Ignasi Barrera dd7a129388 Removed duplicate tests
Having a deep look at this class noticed that most of the tests were
duplicating tests in the AsyncMonitorTest class. All the functionallity
provided by the awaitCompletion and monitor methods is already tested
(and properly tested using mocks) in that class, so those methods have
been removed.

The BaseMonitoringService class just delegates to the AsyncMonitor one,
adding a bit of logic to validate input parameters, so the
BaseMonitoringServiceTest class now only tests the logic it is
responsible for.
2012-10-09 15:37:27 +02:00
Ignasi Barrera a71032df95 Refactored unit tests to avoid recurrent timeouts.
When using TestNG timeout option to control test execution, random
timeout failures appeared. The tests have been refactored to manually
control the timeout.
2012-10-09 15:19:14 +02:00
Andrew Gaul 07ca6ab27b Remove unneeded UnsupportedEncodingExceptions
Enabled by use of Charsets.  Remaining calls due to URLEncoder.encode
and decode.
2012-10-07 17:16:02 -07:00
Ignasi Barrera 8939700db4 Added pricing api 2012-09-27 11:39:17 +02:00
Ignasi Barrera 319d8ffc63 Removed SNAPSHOT dependencies
Removed SNAPSHOT dependencies and licensed all abiquo dependencies under
the ASL 2.0 license.
2012-09-25 11:50:07 +02:00
Ignasi Barrera 2f6e25e4e1 Removed jenkins profile 2012-09-25 11:50:07 +02:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole 2543c0abd7 disabled broken tests in abiquo 2012-09-16 16:21:34 -07:00
Ignasi Barrera e43f16ff5d Pom fixes and cleanup, properties convention and other fixes commented in the pull-request 2012-09-07 12:56:46 +02:00
Ignasi Barrera 063e7e7168 Added Abiquo support in labs 2012-09-05 18:30:33 +02:00