Commit Graph

575 Commits

Author SHA1 Message Date
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a00a2c389 Merge pull request #924 from andrewgaul/copyright-notice
Address minor copyright notice typos
2012-10-29 16:50:01 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Andrew Gaul e7dde3aff5 Address minor copyright notice typos 2012-10-28 23:27:56 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 90f42d01ce Remove InputSuppliers.of(byte[])
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2012-10-17 11:35:45 -07:00
Andrew Gaul 07ca6ab27b Remove unneeded UnsupportedEncodingExceptions
Enabled by use of Charsets.  Remaining calls due to URLEncoder.encode
and decode.
2012-10-07 17:16:02 -07:00
Ioannis Canellos 76beeee55b Merge pull request #873 from iocanel/master
Added name property to Context.
2012-10-06 00:26:07 -07:00
Ioannis Canellos b784cdd4af Added name property to Context. 2012-10-04 13:40:02 +03:00
Andrew Gaul ceb203c10a Improve use of InputSupplier helpers 2012-10-02 18:18:51 -07:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole 7a3318d1ca wrong test name 2012-09-15 14:05:24 -07:00
Andrea Turli 9ea3d3c6bf issue 830: added systemadmin package; more tests fixed 2012-09-04 21:39:34 +02:00
Andrea Turli b0466cad84 issue 830: fixed VAppTemplateApiLiveTest.deleteVAppTemplate 2012-08-27 16:10:48 +02:00
Andrea Turli 88ac4201a6 review addressed 2012-08-25 00:47:26 +02:00
Andrea Turli e5e3a3a2f8 issue 830: keypair 2012-08-25 00:30:28 +02:00
Adrian Cole 7db0519d0b decrufted metadataapi 2012-08-24 00:38:18 -07:00
Andrea Turli 4e8149bfe8 issue 830: more LiveTests fixed on query, vapp, vapptemplate and vdc features 2012-08-23 16:56:08 +02:00
Andrea Turli a0411cfed0 issue 830: fixed CatalogApiLiveTest 2012-08-23 11:50:12 +02:00
Andrea Turli 22629824aa issue 830: fixed networkConfiguration() private method 2012-08-22 18:27:30 +02:00
Andrea Turli 963edd906b issue 830: fixed tests on VAppApiLiveTest 2012-08-21 19:04:30 +02:00
Andrea Turli 77ae46fef3 issue 830: added VAppTemplateURNToHref conversion to get(String reference) 2012-08-20 16:29:12 +02:00
Adrian Cole aff96befbe refactored Metadata to implement Immutable Map<String, String>; addGroupToOrg GroupApi, MediaApi to use urn 2012-08-19 21:48:04 -07:00
Adrian Cole e016367280 case issue 2012-08-19 20:02:02 -07:00
Adrian Cole 169006b3ed Issue 830: refactored MediaClient to not require href arg; refactored VmApi, VAppApi, VAppTemplateApi to use urn 2012-08-19 19:50:51 -07:00
Adrian Cole cd0aa72ae1 Issue 830: renamed Api methods to be in accordance with vCloud relationship links 2012-08-19 16:46:02 -07:00
Adrian Cole cb844928c0 Issue 830: refactored VdcApi,AdminVdcApi to use urn 2012-08-19 16:08:16 -07:00
Adrian Cole 206af90b77 Issue 830: refactored Org, Network, Task, User apis to support URN; removed 'id' from Reference type 2012-08-19 15:23:20 -07:00
Adrian Cole 9e69626413 Issue 830: Cleaned up CatalogApi and AdminCatalogApi; added logic to use URNs as opposed to Hrefs 2012-08-19 02:34:25 -07:00
Adrian Cole 7fe724db43 Issue 830: add resolveEntity 2012-08-18 22:15:51 -07:00
Adrian Cole 027b3d0d33 removed log4j dep 2012-08-15 22:29:36 -07:00
Andrea Turli e92b370d51 added VAppNetworksLiveTest 2012-08-13 23:12:59 +02:00
Andrea Turli 14ab852907 adrian`s comments addressed 2012-08-09 19:41:30 +02:00
Andrea Turli efbaa257e5 added compose and recompose vapp live test 2012-08-09 17:35:18 +02:00
Andrea Turli 9454aeb257 issue 830: fixing vAppTemplateApi*Test, vAppApiLiveTest and vmApiLiveTest 2012-08-06 19:41:30 +02:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 5bd9e3ad9f Issue 1028:vCloud Director 1.5: require x-vcloud-authorization header on vcloud api 2012-07-23 19:28:58 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 6d13652338 Issue 1022:Move naming convention to Api from Client or Services:: vcloud-director 2012-07-15 01:50:51 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Andrew Gaul b95f36952d Fix infinite loops, found by FindBugs 2012-07-14 18:46:58 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00