Commit Graph

780 Commits

Author SHA1 Message Date
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Adrian Cole 55025c0764 Merge pull request #954 from andrewgaul/specific-asserts
Prefer specific asserts where possible
2012-11-04 17:24:47 -08:00
Adrian Cole f1333801dd Merge pull request #953 from aledsage/Setting-RunScriptOnNode.Factory
Setting RunScriptOnNode.factory
2012-11-04 17:12:18 -08:00
Adrian Cole f4333157b9 make tests that decode credentials use valid base64 encoded strings 2012-11-04 15:37:49 -08:00
Andrew Gaul bfa3458b97 Prefer specific asserts where possible 2012-11-04 14:40:24 -08:00
Aled Sage 43d6155341 Set EC2 windows-template image id for testing
- Identify the windows-template AMI using id rather than name-matching
2012-11-04 22:29:52 +00:00
Adrian Cole 7bc40e7fd5 Merge pull request #949 from andrewgaul/assert-fail
Prefer Assert.fail over assert
2012-11-04 08:45:03 -08:00
Andrew Gaul 0e35b3f623 Implement Comparable in GoGrid ErrorResponse
Gson collects errors in a TreeMap which requires a well-behaved
Comparable method.  This addresses a Java 7 GoGrid failure seen in
GridServerClientExpectTest.testGetServerCredentialsWhenNotFoundThrowsResourceNotFoundExceptionWithNiceMessage:

java.lang.ClassCastException: org.jclouds.gogrid.domain.internal.ErrorResponse cannot be cast to java.lang.Comparable
2012-11-03 17:08:43 -07:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a00a2c389 Merge pull request #924 from andrewgaul/copyright-notice
Address minor copyright notice typos
2012-10-29 16:50:01 -07:00
Adrian Cole afa3018dd0 Merge pull request #918 from andrewgaul/hpcloud-clearcontainer
Work around failed CDN metadata lookups with HPCS
2012-10-29 16:48:04 -07:00
Andrew Gaul 3c7b9652f4 Work around failed CDN metadata lookups with HPCS
Previously BlobStore.list and thus BlobStore.clearContainer serialized
on synchronous and failed CDN lookups.  This effectively prevents
clearing any large container.  We cache a negative entry to work
around this.  When HP improves their CDN support we should remove this
workaround.
2012-10-29 15:31:03 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Andrew Gaul e7dde3aff5 Address minor copyright notice typos 2012-10-28 23:27:56 -07:00
Andrew Gaul caccd9cf4c Prefer Files.copy to copy streams 2012-10-24 17:44:05 -07:00
Andrew Gaul bd3ed72396 Fix bad indent 2012-10-23 11:33:38 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 2b5173f617 Remove X-Auth-Token from HP temporary signing
HP Cloud does not use X-Auth-Token for temporary signed URLs and
leaking this allows clients arbitrary privileges until token timeout.
2012-10-15 11:58:49 -07:00
Andrew Gaul a5c56e7aa7 Support HP Cloud temporary signed URL
HP modified the Swift signing mechanism to include the tenant id.
Note that this functionality requires using API access key
credentials.  Live tests need some sorting out since we only support
password credential tests today.
2012-10-10 16:20:31 -07:00
Adrian Cole ffa9cd3bb0 corrected guice bindings for swift-based blob signatures and backfilled expect tests 2012-10-10 12:03:23 +02:00
Adrian Cole a02c79c7f4 Merge pull request #887 from andreisavu/issue-973
Issue 973. Performance problems with Synaptic's Atmos service
2012-10-08 12:50:42 -07:00
Adrian Cole 14ad17108f Issue 671: NPE on aws-ec2 w/vpc security groups 2012-10-08 15:39:51 -04:00
Andrei Savu 03dc864115 Issue 973. Performance problems with Synaptic's Atmos service and writing new blobs 2012-10-08 16:26:40 +03:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Andrew Gaul 8a0900d6ca Prefer fail over assertTrue(false) where possible 2012-10-06 19:25:54 -07:00
Adrian Cole 049106afbf Merge pull request #877 from andrewgaul/hpcloud-credentials
Clarify the HP Cloud credential type
2012-10-04 16:46:28 -07:00
Andrew Gaul c1b65e28d4 Clarify the HP Cloud credential type
While users can override this by setting
KeystoneProperties.CREDENTIAL_TYPE to
CredentialTypes.API_ACCESS_KEY_CREDENTIALS, unit tests expect
CredentialTypes.PASSWORD_CREDENTIALS.
2012-10-04 16:37:12 -07:00
Adrian Cole 298856bab0 Merge pull request #876 from andrewgaul/log4j-line-wrapping
Fix confusing line wrapping
2012-10-04 16:36:04 -07:00
Andrew Gaul 222bddb5fa Fix confusing line wrapping 2012-10-04 16:07:48 -07:00
Andrew Gaul ceb203c10a Improve use of InputSupplier helpers 2012-10-02 18:18:51 -07:00
Adrian Cole 4bc0ffbdd7 corrected api metadata and backfilled expect tests for hpcloud rackspace and trystack nova implementations 2012-09-29 18:41:29 -07:00
Adrian Cole a77a80f030 Issue 1092: fix hostname when path-based buckets are used in non-default location 2012-09-25 21:22:17 -07:00
Everett Toews ffc0d681d5 Increased container count for cloudfiles tests. 2012-09-20 02:32:21 +00:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole 5860d2500b fixed pom typo in sqs 2012-09-17 00:06:35 -07:00
Adrian Cole 3d2504e1e4 updated cloudsigma tests 2012-09-16 23:40:10 -07:00
Adrian Cole 54ec689019 stable openstack 2012-09-16 22:38:22 -07:00
Adrian Cole d766f8d4e3 stable ec2 2012-09-16 22:37:13 -07:00
Adrian Cole 696f24280a glesys now a provider 2012-09-16 21:31:12 -07:00
Adrian Cole 6f5ebf3e90 Issue 1085:deprecate getRegion from EC2 domain objects 2012-09-16 12:55:48 -07:00
Adrian Cole b5f60f1e70 pagination and consistency cleanup on openstack 2012-09-16 00:19:30 -07:00
Adrian Cole b951276ec3 cleaned up aws apis 2012-09-15 23:47:44 -07:00
Adrian Cole 0b31622267 cleaned ec2 instance type 2012-09-15 14:05:24 -07:00
Adrian Cole c7cb9951a8 moved sqs/aws-sqs live 2012-09-14 18:15:50 -07:00
Adrian Cole 27fea13a61 Merge pull request #829 from andreisavu/tempurl
Add support for Swift TempURL Middleware
2012-09-11 14:02:17 -07:00
Adrian Cole 499e47c5b4 fixes to some softlayer tests 2012-09-10 08:04:42 -07:00