Commit Graph

1111 Commits

Author SHA1 Message Date
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole 4c72c5c803 Merge pull request #927 from iocanel/jclouds-osgi-fixes
Jclouds osgi fixes
2012-11-01 13:12:01 -07:00
Ioannis Canellos f49cca46f0 MetadataBundleListener now works with multiple providers/apis per bundle. Added a class assignable check in MetadataBundleListener. Added unit test for MetadataBundleListener. Fixed spelling and formatting of MetadataBundleListener and MetadataBundleListenerTest. 2012-10-31 11:10:20 +02:00
Adrian Cole 5da5161485 Merge pull request #909 from andrewgaul/clear-container-timeout-exception
Throw TimeoutException from awaitCompletion
2012-10-30 08:57:20 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a2905ee1e Merge pull request #926 from andrewgaul/to-string-and-close-exception-handling
Propagate exceptions from toStringAndClose
2012-10-29 16:50:37 -07:00
Andrew Gaul aad4d4dbcf Propagate exceptions from toStringAndClose
This method already declares throws IOException and callers should
handle these errors appropriately.
2012-10-29 09:37:46 -07:00
Andrew Gaul e7dde3aff5 Address minor copyright notice typos 2012-10-28 23:27:56 -07:00
Andrew Gaul 336ccfa2e6 Throw TimeoutException from awaitCompletion
This is a common error that callers should interpret correctly.  For
DeleteAllKeysInList, we integrate into its retry and backoff logic,
and for other callers, we continue to propagate RuntimeException.
2012-10-25 13:50:29 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 90f42d01ce Remove InputSuppliers.of(byte[])
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2012-10-17 11:35:45 -07:00
Adrian Cole ffa9cd3bb0 corrected guice bindings for swift-based blob signatures and backfilled expect tests 2012-10-10 12:03:23 +02:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Adrian Cole 5b213c2171 Merge pull request #883 from andrewgaul/unsupported-encoding-exception
Remove unneeded UnsupportedEncodingExceptions
2012-10-07 18:04:31 -07:00
Adrian Cole 298e764f85 fixed context builder when params in properties 2012-10-07 17:50:59 -07:00
Andrew Gaul 07ca6ab27b Remove unneeded UnsupportedEncodingExceptions
Enabled by use of Charsets.  Remaining calls due to URLEncoder.encode
and decode.
2012-10-07 17:16:02 -07:00
Andrew Gaul 8a0900d6ca Prefer fail over assertTrue(false) where possible 2012-10-06 19:25:54 -07:00
Ioannis Canellos 0dcd648599 Added javadoc description for name property. Cleaned up code in ContextBuilder 2012-10-06 10:31:23 +03:00
Ioannis Canellos 76beeee55b Merge pull request #873 from iocanel/master
Added name property to Context.
2012-10-06 00:26:07 -07:00
Everett Toews add1182960 Made the polling period between updates for servers and images configurable when using the ComputeService. 2012-10-04 20:45:20 -05:00
Adrian Cole 4e32001b84 Merge pull request #689 from andrewgaul/propagate-timeout-exception
Propagate TimeoutException when possible
2012-10-04 14:46:28 -07:00
Andrew Gaul a66c146a54 Propagate TimeoutException when possible
This allows clients to recover from transient errors.
2012-10-04 11:32:48 -07:00
Ioannis Canellos b784cdd4af Added name property to Context. 2012-10-04 13:40:02 +03:00
Andrew Gaul ceb203c10a Improve use of InputSupplier helpers 2012-10-02 18:18:51 -07:00
Adrian Cole 41e4a369e7 reveal underlying exception that causes a guice provider to fail 2012-09-29 14:03:25 -07:00
Adrian Cole 162b2f6829 added advancing iterable 2012-09-21 17:29:59 -07:00
Adrian Cole 38f8f98b16 removed static field-based state sharing when looking up delegate methods 2012-09-20 15:26:06 -07:00
Adrian Cole 0be04f7952 make it possible to extend gson type adapters 2012-09-16 23:38:35 -07:00
Adrian Cole d9c71923a6 param parsers can accept nullable params 2012-09-16 14:56:57 -07:00
Adrian Cole 85b5006084 nicer NPE when null args are specified to ReST methods 2012-09-16 12:38:00 -07:00
Adrian Cole 49877c8f06 helpers for empty collections 2012-09-15 23:43:50 -07:00
Adrian Cole c0e8470952 default region endpoint for rackspace legacy apis 2012-08-29 23:47:05 -07:00
Andrew Gaul 980f469679 Correct typo 2012-08-23 15:32:36 -07:00
Everett Toews 27dee0bfd9 Moved HttpMessage.getLowercaseHeaders() to Multimaps2.transformKeys() and
org.jclouds.functions.ToLowerCase for better reuse.

Added org.jclouds.util.Multimaps2Test for unit test.
2012-08-20 19:02:33 -05:00
Everett Toews 8d9499b3c1 Made getting a header by field-name case-insensitive to address the issue from
https://groups.google.com/forum/?fromgroups#!topic/jclouds/lEZjqhbudX4

This is the proper way to handle it as RFC 2616, "Hypertext Transfer Protocol -- HTTP/1.1", Section 4.2, "Message Headers" states,

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.
2012-08-20 15:30:50 -05:00
Adrian Cole 8c5e03a9a5 added debug when parsing fails 2012-08-19 19:51:30 -07:00
Andrew Gaul 63173fb6f3 Use Multimaps and Predicates helpers
Addresses a TODO.
2012-08-16 13:58:51 -07:00
Adrian Cole b055fb1233 Merge pull request #780 from grkvlt/openstack
Openstack Extensibility
2012-08-12 09:29:51 -07:00
Dies Koper f9e51c37d5 add FirstNetwork, in line with FirstRegion, etc., for use in FGCP provider 2012-08-11 23:22:41 -07:00
Adam Lowe 4fad770eaf openstack-nova: allowing extension of the standard extensions by providers 2012-08-12 02:48:24 +01:00
Dies Koper c684a59cb3 add predicates and template builder live tests for location scopes SYSTEM and NETWORK 2012-08-06 23:29:26 +10:00
Adrian Cole ba56e2dce4 utils and better toStrings for location classes 2012-07-29 16:30:20 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 3e2e24493e Issue 981: better toString on template 2012-07-26 11:28:38 -07:00
Andrew Gaul cd48729f65 Prefer ImmutableMap for SyncProxy maps 2012-07-26 08:44:13 -07:00
Adrian Cole 821b422b94 added SshKeyPairGenerator 2012-07-25 00:33:38 -07:00
Adrian Cole cab271d30f expect test ignored properties 2012-07-25 00:33:38 -07:00
Andrew Gaul 3648863a3c Introduce Predicates2.startsWith and endsWith 2012-07-24 22:21:34 -07:00
Adrian Cole 9d007a40b7 reset loginpassword/privatekey when explicitly set 2012-07-23 19:28:59 -07:00
Adrian Cole 6d9d638a1f Merge pull request #746 from dkoper/master
adding SYSTEM location scope required for FGCP
2012-07-23 19:19:50 -07:00
Dies Koper 966f1fc459 Add SYSTEM scope from DMTF CIMI. FGCP provider needs it. 2012-07-24 11:39:54 +10:00
Andrew Gaul 8524dd3a67 Ensure that EventBus is a singleton 2012-07-23 11:02:55 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul 27e61f73e9 Remove encodeString() and encodeString(String)
These are not used in jclouds and callers should use
String.getBytes(Charset) directly, preferably with Guava Charsets
constants.
2012-07-19 10:55:23 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 62e8c59385 Merge pull request #724 from andrewgaul/hex-cut-and-paste
Remove duplicated hexadecimal conversion code
2012-07-17 15:24:21 -07:00
Andrew Gaul d82dd32c64 Remove duplicated hexadecimal conversion code 2012-07-17 13:09:38 -07:00
Adam Lowe 20d3d0d603 expect tests: removing requirement that requests are unique (so orderedRequestsSendResponses can tee up different responses for the same request when testing functions) 2012-07-17 15:30:03 +01:00
Dies Koper f119aaa49f remove stray @Test on base class as it's causing warnings due to its public non-test methods 2012-07-17 11:50:18 +10:00
Adrian Cole a979c31d8c Merge pull request #718 from grkvlt/transform-parallel-timeout
Timeouts on FutureIterables.transformParallel
2012-07-16 16:40:45 -07:00
Adrian Cole 3154371433 Issue 1011: remove PagedIterator 2012-07-16 12:11:59 -04:00
Andrew Donald Kennedy 4463b52051 Added optional timeout to EC2 listNodes strategy and made awaitCompletion update latch in finally block 2012-07-16 16:58:37 +01:00
Adrian Cole addeb0d031 added concat to PagedIterable 2012-07-16 11:07:17 -04:00
Adrian Cole 315d5fb3ef Issue 1011: introducing PagedIterable 2012-07-15 23:34:42 -07:00
Adrian Cole 248c6dcb39 Transform to work with SaxParser 2012-07-15 22:44:07 -07:00
Adrian Cole 872046ed4c added @Transform 2012-07-15 20:10:49 -07:00
Adrian Cole b49f2e99c7 Issue 1022: naming conventions 2012-07-15 13:57:44 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
Andrew Gaul b95f36952d Fix infinite loops, found by FindBugs 2012-07-14 18:46:58 -07:00
Andrew Gaul 68b8a99c79 Log hostnames only if they differ
Also only log we have not previously encountered this mapping.
Finally use concurrent map for thread safety.
2012-07-13 15:17:53 -07:00
Adrian Cole 72ba1639b9 Issue 1022: added BaseRestApiExpectTest 2012-07-12 10:08:10 -07:00
Adrian Cole 0383a80904 Issue 1011: PaginatedIterable with marker type as Object 2012-07-09 16:08:32 -07:00
Adrian Cole 6cdad28359 Merge pull request #704 from dkoper/master
tested NPE goes away with FGCP expect test
2012-07-09 00:04:59 -07:00
Dies Koper 43f12fa627 prevent NPE when null is passed to @QueryParam annotated argument 2012-07-09 13:15:32 +10:00
Adrian Cole 7a776c0572 Issue 1007: missing interface method for iso8601 codec 2012-07-06 22:27:54 -07:00
Adrian Cole a73240f41b Issue 1007: ios8601 codec 2012-07-06 21:23:10 -07:00
Adrian Cole 25e68b328c Merge pull request #700 from aledsage/Issue-1004
Issue 1004: changes default SocketOpen impl
2012-07-06 14:38:02 -07:00
Adrian Cole 6359db8c5b Merge pull request #702 from dkoper/master
decouple use of provider's SSLContext from trustAllCerts setting
2012-07-05 22:47:38 -07:00
Dies Koper 90df3a1e51 enable provider (like FGCP) specific subclasses to reuse these static classes 2012-07-06 13:01:20 +10:00
Dies Koper 6f81d8d0d3 improvement on previous change: decouple use of provider's SSLContext from trustAllCerts setting. This will allow providers to combine their SSLContext with the value of this option 2012-07-06 12:40:48 +10:00
Adrian Cole 270b0d92f6 Merge pull request #701 from dkoper/master
adding hook to allow provider specific SSLContext for HTTPS communication
2012-07-05 19:00:46 -07:00
Dies Koper 4cbf02f0bc add hook for provider specific trusted SSLContext - in anticipation of FGCP support 2012-07-06 11:53:39 +10:00
Aled Sage 95c35487f0 Issue 1004: changes default SocketOpen impl
Sets it to InetSocketAddressConnect, instead of SocketOpenUnsupported.
Removes overriding the impl from Jsch and Sshj's client modules.
2012-07-05 16:00:29 +01:00
Adrian Cole 493de01cfa Merge pull request #694 from aplowe/openstack-nova2
Openstack & further GSON work: changed new openstack modules to use Named and ConstructorProperties
2012-07-03 07:07:07 -07:00
Adam Lowe 7ed9ebda47 Moving TypeAdapterFactories that eliminate null values in Sets, Maps and Multimaps to jclouds-core. 2012-07-03 14:46:54 +01:00
Adrian Cole 222e2cc367 Merge pull request #693 from dkoper/master
don't overwrite USER_AGENT if already there
2012-07-03 06:28:29 -07:00
Adam Lowe 3243325878 openstack: adjusting deserialization to treat {} as null if (and ONLY if) a null pointer is thrown when attempting to construct an object from the empty json object ({}) 2012-07-03 12:39:53 +01:00
Dies Koper afdf7f2c37 don't override USER_AGENT if already specified by provider 2012-07-03 16:50:36 +10:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adrian Cole 07240f3e77 removed copy/paste code relating to expiration after write 2012-07-02 15:27:31 -07:00
Adrian Cole ef9a69e7c3 added strict suppliers of scoped locations 2012-07-02 15:22:10 -07:00
Adrian Cole 763572f8ee added paginated set functionality 2012-06-24 11:48:18 -07:00
Adam Lowe 21802d467a Adjusting general strategy to accept @Named in place of @SerializedName.
Adding TypeAdapterFactory to handle deserialization based on constructor annotations (Inject/Named and/or ConstructorProperties).
2012-06-20 13:41:44 +03:00
Adrian Cole 3afdcb66b3 Issue 981:Quiet down jclouds.compute logger 2012-06-16 18:27:29 -04:00
Adrian Cole 5dd4f04ddf allowed for mock testing 2012-06-16 18:19:59 -04:00
Adrian Cole db8f869f5b Issue 979:invalid endpoint returned when region name is the same as the provider 2012-06-15 23:36:21 -04:00
Adrian Cole 30ba717969 Issue 977:ec2 zones are not mapping to endpoints 2012-06-15 23:36:17 -04:00
Andrew Gaul 736554d049 Correct spelling errors 2012-06-14 10:03:39 -04:00
Ioannis Canellos ff2c2fb3e3 Providers and APIs in OSGi can be discovered even if they are installed prior to the installation of jclouds-core. 2012-06-13 20:40:03 +03:00
Andrew Phillips c0e23d4460 Updated authors and added a small correction to the changes in ca84fcc279 for supporting beta versions in JcloudsVersion 2012-06-13 10:34:12 -04:00
Ioannis Canellos cf94e70a95 Improved discovery of api metadata inside OSGi. 2012-06-13 13:05:43 +03:00
Adrian Cole 9daee06e13 usage example 2012-06-12 09:09:44 -07:00
Ioannis Canellos 6ffe7085bc Improved the discovery of providers inside OSGi 2012-06-12 00:38:01 +03:00
Adrian Cole 73e026b314 functionloader cleanup 2012-06-08 13:00:38 -07:00
Adam Lowe 18faff54b3 openstack-keystone: adding TypeAdaptorFactory to take care of unwrapping objects containing an array of "values" in place of a normal json array 2012-06-08 11:23:41 +01:00
Adrian Cole d00e360d65 Issue 815: refactored the 3 major features of keystone into separate clients. removed cyclic dependency needed to support keystone controlling keystones in other regions 2012-06-06 23:14:23 -07:00
Adrian Cole 7203286a90 formatting 2012-06-04 11:42:08 -07:00
Adrian Cole 5a3f6011a2 removed junit test dependency 2012-06-03 17:26:57 -07:00
Adrian Cole 8159b6618f Merge pull request #659 from aplowe/openstack-nova2
Openstack Quantum: adding openstack network api
2012-06-01 15:55:07 -07:00
Adam Lowe 4008407de3 Adding support for @Path and @PathParam to delegate methods to RestAnnotationProcessor 2012-06-01 22:41:45 +01:00
vijaykiran 6d74805dd9 Issue-953 Make sure that port is set when modifying headers 2012-06-01 23:02:56 +02:00
vijaykiran e0ad035606 Set port in the request header from the endpoint 2012-06-01 11:31:07 +02:00
Adam Lowe 76531d62e0 Adding multiple varargs HttpRequestOptions support 2012-05-31 13:40:59 +01:00
Adrian Cole f8280ec56c Issue 647: normalized use of IllegalArgumentException 2012-05-22 11:31:32 -06:00
Adrian Cole ca84fcc279 support beta versions 2012-05-21 23:22:55 -06:00
Adrian Cole 5c647df129 Issue 938:TemplateBuilderSpec 2012-05-21 02:45:25 -06:00
Aled Sage fffa3eb8af Issue 647: fix handling of malformed 'Expires' header 2012-05-17 23:58:39 +01:00
Aled Sage 2637a4b6e9 Issue 647: DateCodec impl delegates to DateService 2012-05-17 11:25:13 +01:00
Aled Sage cd9c830c5a Issue 647: store Expires as Date; added ContentMetadataCodec for converting to/from HTTP headers 2012-05-17 11:24:50 +01:00
Aled Sage 9aedf7b6f6 Issue 647: added "Expires" header for ContentMetadata 2012-05-17 11:24:45 +01:00
Adrian Cole 7854d85f13 Issue 932:transition to multi-threaded google appengine 2012-05-17 00:18:08 -07:00
Adrian Cole ffb9b34cea ensure mock tests are run single-threaded 2012-05-15 12:12:21 -07:00
Adrian Cole db40facb2d Issue 930:RetryingCacheLoaderDecorator 2012-05-14 23:18:25 -07:00
Adam Lowe cc016d5dc8 Adjusting MapBinder to take Map<String,Object> so BindToJsonPayload can bind objects annotated with PayloadParam correctly 2012-05-14 13:09:22 +01:00
Adam Lowe 42b8071682 openstack-nova: Adding support for @WrapWith on methods 2012-05-14 11:41:10 +01:00
Andrew Gaul c43d89d6d8 Use Objects.equal in ContentMetadataBuilder.equals
Inspired by a discussion with @aledsage.
2012-05-11 10:10:16 -07:00
Adam Lowe f11518fa1e Adding requestLine check to ensure all HttpRequestComparisonTypes compare endpoints and methods 2012-05-10 15:21:48 +01:00
Adrian Cole 9701d80bbb Issue 919: added RegionIdFilter and ZoneIdFilter 2012-05-09 18:21:56 -07:00
Adam Lowe 1797b27ed4 Adding OptionalTypeAdaptorFactory to handle the parsing of Optional values 2012-05-08 17:03:18 -07:00
Adrian Cole 19390ea87d Merge pull request #602 from andrewgaul/propagate-or-null
Eliminate Throwables2.propagateOrNull
2012-05-02 15:21:30 -07:00
Andrew Gaul 74440a7a87 Eliminate Throwables2.propagateOrNull
Throwables.propagate always propagates the Throwable; there is no need
to return null.
2012-05-02 13:51:36 -07:00
Andrew Gaul 646f8d8b13 Improve use of Throwables.propagate
Throwing the return value removes some unneeded asserts and return
statements.  Also remove some useless and misspelled propogate
wrappers.
2012-05-02 11:05:22 -07:00
Adrian Cole af65dbbac3 Merge pull request #593 from andrewgaul/string-builder
Prefer unsynchronized StringBuilder
2012-04-30 10:46:21 -07:00
Andrew Gaul 198d19714e Prefer unsynchronized StringBuilder
A few instances remain due to EasyMock and Matcher.
2012-04-30 09:50:18 -07:00
Adam Lowe f3dc23f578 Simplifying BaseRestClientExpectTest's comparison of non-payload requests 2012-04-27 16:35:22 +01:00
Matt Stephenson 381851b8ab Remove IPSocket class, replace with Guava's HostAndPort class. 2012-04-25 17:52:01 -07:00
Adrian Cole c624c88274 better exception message on key not found 2012-04-24 12:27:16 -07:00
Adrian Cole df7d2acbb4 wrapper -> view 2012-04-23 19:14:36 -07:00
Adrian Cole 886d2cafb9 created base Context class with ProviderMetadata and Identity 2012-04-23 16:16:51 -07:00
Adrian Cole f1010e13a4 fixed aws-ec2 image parsing 2012-04-21 10:59:01 -07:00
Adrian Cole b87e1397ee functions for regions 2012-04-19 23:14:13 -07:00
Adrian Cole 66dc8787ae added javadoc 2012-04-19 11:56:14 -07:00
Adrian Cole e496faf611 Merge pull request #575 from aplowe/openstack-nova
Openstack nova: HostAdministration and SimpleTenantUsage extensions
2012-04-19 10:21:51 -07:00
Adrian Cole 83e9eb9978 Merge pull request #574 from danikov/covariant-future-iterables
bugfix for self-referential loop + test
2012-04-19 10:20:29 -07:00
Adam Lowe 7dbba2a4e1 Adjusting iso8601SecondsDateParse to replace ' ' with 'T" in the same manner as iso8601DateParse 2012-04-19 07:51:27 +01:00
Andrew Donald Kennedy 437bb83496 Do not create new users just for the tests, run them with the passed in credentials 2012-04-19 00:16:42 +01:00