Commit Graph

728 Commits

Author SHA1 Message Date
Andrew Bayer 7923009eb5 JCLOUDS-37. Fix RAT violations in incubator-jclouds, master branch 2013-05-13 19:17:50 -07:00
Andrew Gaul fff2fa6e05 Address Checkstyle violations
This commit requires temporarily disabling some checks.
2013-04-17 16:21:21 -07:00
Andrew Gaul 04fad88fd3 Remove duplicate Utils getters
Rename callers as required.
2013-04-12 16:24:37 -07:00
adriancole e98b7f91aa be more lenient with time-based tests as buildhive hosts are slow 2013-04-10 09:55:10 -07:00
adriancole 61067d3683 Deprecated remaining code related to RestContext, RestApiMetadata, and RestClientModule for ApiContext, HttpApiMetadata, HttpApiModule 2013-04-09 22:07:43 -07:00
Andrew Bayer c566418d87 Adding listNodesByIds across the board.
Adding to both ListNodesStrategy and ComputeServiceAdapter. When
possible, does a query explicitly for the specified IDs. When not,
falls back on either listDetailsOnNodesMatching (for ListNodesStrategy
implementations and in BaseComputeService) or filters listNodes output
itself (in ComputeServiceAdapter).
2013-04-08 17:21:01 -07:00
Andrew Gaul be1da2501e Remove InputSuppliers.of(String)
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2013-04-03 15:52:43 -07:00
Andrew Gaul 371db8d18f Address Xlint warnings 2013-03-13 22:23:19 -07:00
Rex Hoffman 35dd0a67aa Update compute/src/main/java/org/jclouds/net/domain/IpPermission.java
shouldn't we hash on cidrBlocks as well... breaks some set logic I'm using.
Wondering if this will be built out, or if it will be dropped?
2013-02-26 14:45:49 -08:00
Adrian Cole 1fbc47bd77 added iam instance profile args to aws-ec2 2013-02-25 17:35:02 -08:00
Andrew Gaul ff42fdfa13 Address FindBugs warnings 2013-02-24 20:17:50 -08:00
Andrew Gaul 1f995879d6 Address FindBugs errors 2013-02-22 20:59:29 -08:00
Adrian Cole d9f11821b2 fix issue #1264 parse smartos in joyent 2013-01-31 11:04:15 -08:00
David Ribeiro Alves 208d6e6014 added GCEL linux to OsFamily 2013-01-28 15:34:44 -05:00
Dies Koper 17451c3e49 Core, compute: improved poll retry timeout comments 2013-01-28 16:15:47 +11:00
Adrian Cole 982c502413 Merge pull request #1245 from carlpulley/ensure_hostname_in_hosts
Issue #1240: Updated ensure_hostname_in_hosts to use SSH_CONNECTION
2013-01-25 09:46:59 -08:00
Carl Pulley 4b64563f97 Issue #1240: replaced cut with awk 2013-01-25 11:31:18 +00:00
Carl Pulley eedd8a26db Issue #1240: Updated ensure_hostname_in_hosts to use SSH_CONNECTION with failover to hostname -i 2013-01-25 11:00:14 +00:00
Adrian Cole 77b8a8c63f Merge pull request #1241 from carlpulley/ensure_hostname_in_hosts
Issue #1240: Improved handling of /etc/hosts updates by ensure_hostname_in_hosts
2013-01-24 16:29:53 -08:00
Carl Pulley 74c0b42b87 Issue #1240: Improved handling of /etc/hosts updates by ensure_hostname_in_hosts 2013-01-24 22:49:17 +00:00
Adrian Cole 37e587ee51 changes related to centralizing construction of invokables 2013-01-19 17:17:30 -08:00
Adrian Cole 4980367991 centralize TypeToken creation 2013-01-19 11:31:55 -08:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
Adrian Cole a7e4564c8e support changing credentials at runtime 2013-01-15 22:26:24 -08:00
Adrian Cole f18d3b433f Merge pull request #1177 from jclouds/retryablepredicate-highlander
There can be only one retryable predicate; use Predicates2.retry
2013-01-13 22:07:42 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole a49a060152 There can be only one retryable predicate; use Predicates2.retry decorator 2013-01-13 20:30:34 -08:00
Adrian Cole 3962b30808 updated to use standard guava Futures and ListenableFuture 2013-01-13 09:31:10 -08:00
Adrian Cole 547f574eea got rid of custom MoreExecutors.sameThreadExecutor 2013-01-12 15:47:58 -08:00
Adrian Cole 45bb35971e replaced usage of checkNotEmpty with checkNotNull(emptyToNull 2013-01-12 15:20:11 -08:00
Adrian Cole d57197c103 cleaned up code references detected as unnecessary by UEC plugin 2013-01-12 12:31:00 -08:00
Adrian Cole 6e554298ab ensure extra metadata from provider doesn't trip metadata tests 2013-01-01 17:18:55 -08:00
Adrian Cole e42cb787f6 revived jetty test 2013-01-01 17:17:13 -08:00
Adrian Cole 79334201bf added ability to run scripts literally 2013-01-01 17:09:51 -08:00
Adrian Cole 42c7037a59 removed unused code or duplicated code; moved code only used once to where its used 2013-01-01 00:08:34 -08:00
Adrian Cole 0ee2c56668 added new hardware id predicate 2012-12-31 22:11:09 -08:00
Adrian Cole b19e4a7a0f removed TransformingSetSupplier as it is replaced with FluentIterable 2012-12-31 20:46:04 -08:00
Adrian Cole 9745e9dc2f fixed covariance and warnings on ApiMetadata subclasses 2012-12-31 19:40:49 -08:00
Adrian Cole 038e550d2d moved off deprecated FluentIterable methods 2012-12-30 13:20:09 -08:00
Adrian Cole 472f6dcc32 wave 2 of refactoring ConcurrentOpenSocketFinder and test 2012-12-03 21:52:25 -08:00
Adrian Cole 565a54164b ConcurrentOpenSocketFinder cleanup 2012-12-02 13:49:30 -08:00
Andrew Phillips 19952dec47 Refactoring ConcurrentOpenSocketFinderTest.testChecksSocketsConcurrently to try to prevent timeouts 2012-11-27 21:06:23 -05:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul b9e4543cdb Enforce no use of star imports via Checkstyle 2012-11-13 20:51:59 -08:00
Andrew Gaul d7380114a6 Enforce use of Atomics.newReference via Checkstyle
Avoids duplicating types.
2012-11-12 11:56:48 -08:00
Andrew Gaul 3ad36d25d5 Enforce no unnecessary parentheses via Checkstyle 2012-11-10 13:22:12 -08:00
Andrew Gaul cca02ae02d Improve use of Splitter.omitEmptyStrings 2012-11-07 22:30:52 -08:00
Adrian Cole c7c27e12e2 improved javadoc including where to look for alternative syntax 2012-11-07 12:02:52 -03:00
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Adrian Cole 6eb0cd197f Merge pull request #945 from nacx/scriptbuilder-install
Improved setupPublicCurl script
2012-11-05 11:30:44 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Aled Sage 3f3037c729 Support for setting RunScriptOnNode.Factory
- Set default RunScriptOnNode.Factory impl using @ImplementedBy,
  rather than hardcoding the binding
2012-11-04 22:29:52 +00:00
Ignasi Barrera 652bc2f75e Improved setupPublicCurl script
With this changes, apt and yum helper functions can be used to install
many packages at one as follows:
ensure_cmd_or_install_package_apt git git-core build-essentials <...>
2012-11-04 19:43:39 +01:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole 5da5161485 Merge pull request #909 from andrewgaul/clear-container-timeout-exception
Throw TimeoutException from awaitCompletion
2012-10-30 08:57:20 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul 336ccfa2e6 Throw TimeoutException from awaitCompletion
This is a common error that callers should interpret correctly.  For
DeleteAllKeysInList, we integrate into its retry and backoff logic,
and for other callers, we continue to propagate RuntimeException.
2012-10-25 13:50:29 -07:00
Adrian Cole bc82296702 Issue 1103: isolate polling of nodes into its own class 2012-10-20 11:05:18 -07:00
Everett Toews add1182960 Made the polling period between updates for servers and images configurable when using the ComputeService. 2012-10-04 20:45:20 -05:00
Adrian Cole 1edbb0ab4b override-login-privateKey should be :override-login-private-key 2012-10-04 10:28:14 -07:00
Adrian Cole 8ca0dc3c1d better error reporting 2012-09-16 21:28:51 -07:00
Adrian Cole 2ebd5f0247 not all cloud providers accept mixed case metadata keys 2012-09-16 16:20:45 -07:00
Adrian Cole a70e3adb20 Issue 1075:switch to use jetty for java install/web service tests 2012-08-27 00:10:18 -07:00
Dies Koper b7666da170 nslookup on CentOS 6.2 doesn't set error code when failing, so grep expected output instead 2012-08-27 14:31:33 +10:00
Dies Koper cc5dc55bb0 configure .gitattributes to not convert shell scripts to CRLF on Windows 2012-08-24 17:29:40 +10:00
Adrian Cole 0d805574ed Issue 1070:TemplateBuilderSpec with loginUser=user:password doesn't use that for login credentials 2012-08-22 12:05:33 -07:00
Dies Koper c684a59cb3 add predicates and template builder live tests for location scopes SYSTEM and NETWORK 2012-08-06 23:29:26 +10:00
Adrian Cole 513fe2ee3e fixed typo 2012-08-01 21:54:37 -07:00
Adrian Cole b478b02bbe switched to binary-based package manager checks 2012-08-01 11:35:10 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 3e2e24493e Issue 981: better toString on template 2012-07-26 11:28:38 -07:00
Adrian Cole 5d6e005e8b Issue 1030:defaults not picking up on compute.templateOptions() 2012-07-25 00:33:39 -07:00
Adrian Cole 32da070317 revised tests that AdminAccess change recently broke 2012-07-23 19:28:58 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
David Ribeiro Alves d4453b2ac2 nodepool progress and AdminAccessBuilderSpec 2012-07-12 11:04:55 -07:00
Andrew Bayer 4aa8e1055a Issue #1020. Fill in GECOS field when creating a user.
We'll just use the username there as well for now.
2012-07-11 17:48:20 -07:00
Adrian Cole 9f05a64c8d usage update wrt group name 2012-07-05 10:12:21 -07:00
Adrian Cole 4d6e8fdd73 Issue 1005:openjdk install fails on ubuntu precise 2012-07-03 22:13:53 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adrian Cole 547c73ab00 cleaner error messages in templateBuilder 2012-07-02 12:21:13 -07:00
Aled Sage 65b813b1be Issue 989: handles transient node-not-found in nodeRunning
Sometimes on aws-ec2, the client returns null (i.e. node not found).
This fix will cause us retry with the correct node-id, rather than
"forgetting" the original nodeId and retrying with null each time.
2012-06-26 10:09:07 +01:00
Adrian Cole 8c4e74296d added min-disk to compute2.clj 2012-06-19 18:40:45 -06:00
Adrian Cole 09d5e8add4 consistent ordering of hardware 2012-06-19 18:31:39 -06:00
vijaykiran 600e6e0feb Add minDisk to toString. 2012-06-18 11:03:25 +02:00
vijaykiran c3a6ecf757 Test for minDisk 2012-06-18 10:52:26 +02:00
vijaykiran bd675a22eb Merge upstream changes to template builder 2012-06-18 10:12:11 +02:00
Adrian Cole 3afdcb66b3 Issue 981:Quiet down jclouds.compute logger 2012-06-16 18:27:29 -04:00
Adrian Cole 585f44639b Issue 978:image location ignored in templateBuilder 2012-06-15 23:36:21 -04:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00
Andrew Gaul 227dbf777a Correct spelled from delimeter to delimiter 2012-06-14 10:05:13 -04:00
Adrian Cole 73ddd9095c runscript data incorrectly in main source tree 2012-06-12 19:11:15 -07:00
Adrian Cole 4dd8fdd0e2 Issue 964:change script builder variable case format from lowerCamel to UPPER_UNDERSCORE 2012-06-12 19:11:09 -07:00
Adrian Cole cea605b2b0 Merge pull request #671 from aledsage/Fix-TemplateBuilder-javadoc
Fixes TemplateBuilder.from(...) javadoc
2012-06-12 09:51:59 -07:00
Aled Sage 899cd6ebd1 Fixes TemplateBuilder.from(...) javadoc 2012-06-12 17:39:29 +01:00
Aled Sage c50edefef6 Remove deprecated code
Removes PopulateDefaultLoginCredentialsForImageStrategy.execute().
The javadoc said it would be removed in jclouds 1.4.

Adds javadoc to ExecResponse.getExitCode, saying to be deleted in 1.6.
It was deprecated in 1.4 release (so 1.6 would be two releases time).
2012-06-11 15:03:31 -07:00