Commit Graph

660 Commits

Author SHA1 Message Date
Andrew Gaul 3ad36d25d5 Enforce no unnecessary parentheses via Checkstyle 2012-11-10 13:22:12 -08:00
Andrew Gaul cca02ae02d Improve use of Splitter.omitEmptyStrings 2012-11-07 22:30:52 -08:00
Adrian Cole c7c27e12e2 improved javadoc including where to look for alternative syntax 2012-11-07 12:02:52 -03:00
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Adrian Cole 6eb0cd197f Merge pull request #945 from nacx/scriptbuilder-install
Improved setupPublicCurl script
2012-11-05 11:30:44 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Aled Sage 3f3037c729 Support for setting RunScriptOnNode.Factory
- Set default RunScriptOnNode.Factory impl using @ImplementedBy,
  rather than hardcoding the binding
2012-11-04 22:29:52 +00:00
Ignasi Barrera 652bc2f75e Improved setupPublicCurl script
With this changes, apt and yum helper functions can be used to install
many packages at one as follows:
ensure_cmd_or_install_package_apt git git-core build-essentials <...>
2012-11-04 19:43:39 +01:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole 5da5161485 Merge pull request #909 from andrewgaul/clear-container-timeout-exception
Throw TimeoutException from awaitCompletion
2012-10-30 08:57:20 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Andrew Gaul 336ccfa2e6 Throw TimeoutException from awaitCompletion
This is a common error that callers should interpret correctly.  For
DeleteAllKeysInList, we integrate into its retry and backoff logic,
and for other callers, we continue to propagate RuntimeException.
2012-10-25 13:50:29 -07:00
Adrian Cole bc82296702 Issue 1103: isolate polling of nodes into its own class 2012-10-20 11:05:18 -07:00
Everett Toews add1182960 Made the polling period between updates for servers and images configurable when using the ComputeService. 2012-10-04 20:45:20 -05:00
Adrian Cole 1edbb0ab4b override-login-privateKey should be :override-login-private-key 2012-10-04 10:28:14 -07:00
Adrian Cole 28d766b9df bumped to 1.6.0-SNAPSHOT 2012-09-17 01:43:52 -07:00
Adrian Cole 8ca0dc3c1d better error reporting 2012-09-16 21:28:51 -07:00
Adrian Cole 2ebd5f0247 not all cloud providers accept mixed case metadata keys 2012-09-16 16:20:45 -07:00
Adrian Cole a70e3adb20 Issue 1075:switch to use jetty for java install/web service tests 2012-08-27 00:10:18 -07:00
Dies Koper b7666da170 nslookup on CentOS 6.2 doesn't set error code when failing, so grep expected output instead 2012-08-27 14:31:33 +10:00
Dies Koper cc5dc55bb0 configure .gitattributes to not convert shell scripts to CRLF on Windows 2012-08-24 17:29:40 +10:00
Adrian Cole 0d805574ed Issue 1070:TemplateBuilderSpec with loginUser=user:password doesn't use that for login credentials 2012-08-22 12:05:33 -07:00
Dies Koper c684a59cb3 add predicates and template builder live tests for location scopes SYSTEM and NETWORK 2012-08-06 23:29:26 +10:00
Adrian Cole 513fe2ee3e fixed typo 2012-08-01 21:54:37 -07:00
Adrian Cole b478b02bbe switched to binary-based package manager checks 2012-08-01 11:35:10 -07:00
Andrew Gaul 8ed0e28e68 Spelling corrections 2012-07-26 22:39:35 -07:00
Adrian Cole 3e2e24493e Issue 981: better toString on template 2012-07-26 11:28:38 -07:00
Adrian Cole 5d6e005e8b Issue 1030:defaults not picking up on compute.templateOptions() 2012-07-25 00:33:39 -07:00
Adrian Cole 32da070317 revised tests that AdminAccess change recently broke 2012-07-23 19:28:58 -07:00
Andrew Gaul 985cccff9a Prefer valueOf over explicit object creation
This allows use of cached values.  Patched with:

find -name \*.java | xargs sed -i 's/new Boolean(false)/Boolean.FALSE/g'
find -name \*.java | xargs sed -i 's/new Boolean(true)/Boolean.TRUE/g'
find -name \*.java | xargs sed -i 's/new Boolean(/Boolean.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Integer(/Integer.valueOf(/g'
find -name \*.java | xargs sed -i 's/new Long(/Long.valueOf(/g'
2012-07-22 21:01:46 -07:00
Andrew Gaul a40983a39d Prefer InputSupplier helpers
These ensure that inputs are closed properly.

Updated with: find -name \*.java | xargs sed -i
's/toStringAndClose(\(.*\)\.getInput())/toString(\1)/'
2012-07-18 17:42:48 -07:00
Adrian Cole 05fd64af44 cleaned up http builders and expect tests 2012-07-15 01:50:38 -07:00
David Ribeiro Alves d4453b2ac2 nodepool progress and AdminAccessBuilderSpec 2012-07-12 11:04:55 -07:00
Andrew Bayer 4aa8e1055a Issue #1020. Fill in GECOS field when creating a user.
We'll just use the username there as well for now.
2012-07-11 17:48:20 -07:00
Adrian Cole 9f05a64c8d usage update wrt group name 2012-07-05 10:12:21 -07:00
Adrian Cole 4d6e8fdd73 Issue 1005:openjdk install fails on ubuntu precise 2012-07-03 22:13:53 -07:00
Adrian Cole fb98ce82f7 cleanup of module binding, clarity in toStrings, reduced wrapper depth for memoized sets 2012-07-02 19:36:27 -07:00
Adrian Cole 547c73ab00 cleaner error messages in templateBuilder 2012-07-02 12:21:13 -07:00
Aled Sage 65b813b1be Issue 989: handles transient node-not-found in nodeRunning
Sometimes on aws-ec2, the client returns null (i.e. node not found).
This fix will cause us retry with the correct node-id, rather than
"forgetting" the original nodeId and retrying with null each time.
2012-06-26 10:09:07 +01:00
Adrian Cole 8c4e74296d added min-disk to compute2.clj 2012-06-19 18:40:45 -06:00
Adrian Cole 09d5e8add4 consistent ordering of hardware 2012-06-19 18:31:39 -06:00
vijaykiran 600e6e0feb Add minDisk to toString. 2012-06-18 11:03:25 +02:00
vijaykiran c3a6ecf757 Test for minDisk 2012-06-18 10:52:26 +02:00
vijaykiran bd675a22eb Merge upstream changes to template builder 2012-06-18 10:12:11 +02:00
Adrian Cole 3afdcb66b3 Issue 981:Quiet down jclouds.compute logger 2012-06-16 18:27:29 -04:00
Adrian Cole 585f44639b Issue 978:image location ignored in templateBuilder 2012-06-15 23:36:21 -04:00
Adrian Cole d980b4fd42 changed test poms to use provider.template and provider.ec2-template accordingly 2012-06-15 23:35:10 -04:00