Commit Graph

1425 Commits

Author SHA1 Message Date
adriancole 88871c9fe9 issue #1501: add Closeable annotation to all top-level apis 2013-04-08 16:13:09 -07:00
adriancole 4ced43566b issue #1501: allow Closeable, top-level apis to be used as opposed to RestContext 2013-04-08 15:14:59 -07:00
Ioannis Canellos a03d4183ae Add @Inject to the Compute class. 2013-04-05 01:51:43 +03:00
Adrian Cole 3e9c3dc6e6 Merge pull request #1490 from maginatics/do-slice-string-cast
Cast String Payloads to String
2013-04-03 17:56:45 -07:00
Adrian Cole 0f1675cc18 Merge pull request #1489 from maginatics/remove-input-suppliers
Remove InputSuppliers.of(String)
2013-04-03 17:55:25 -07:00
Adrian Cole 366a728b08 Merge pull request #1480 from maginatics/http-put-zero-content-length
Emit Content-Length: 0 for empty PUTs
2013-04-03 17:21:20 -07:00
Andrew Gaul be1da2501e Remove InputSuppliers.of(String)
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2013-04-03 15:52:43 -07:00
Andrew Gaul 10d29f5ef2 Cast String Payloads to String 2013-04-03 15:51:44 -07:00
Adrian Cole d938349229 Merge pull request #1488 from maginatics/remove-input-suppliers-of-input-stream
Remove InputSuppliers.of(InputStream)
2013-04-03 15:39:58 -07:00
Andrew Gaul 648e6c2a8a Remove InputSuppliers.of(InputStream)
This method breaks the contract of an InputSupplier since every call
to getInput returns the same InputStream instance.  This is
particularly dangerous when one of the callers mutates or closes the
InputStream which causes all others callers to fail.
2013-04-03 13:19:42 -07:00
Andrew Gaul 843ed57c8a Emit Content-Length: 0 for empty PUTs
HttpUrlConnection reverts Content-Length: 0 on PUT without
doOutput(true), similar to POST.  This commit allows Azure container
create to succeed.  Closes #1420.
2013-04-01 13:42:59 -07:00
Andrew Phillips db4e4af931 Not making methods of core Java classes accessible in Reflection2 2013-03-30 17:00:43 -04:00
Andrew Gaul eb2a9b6ed5 Correct HttpAsyncClient.put Javadoc 2013-03-27 12:44:29 -07:00
Everett Toews 870c7d8450 PaginatedCollection for Rackspace style pagination. 2013-03-25 14:22:32 -05:00
adriancole cd79a9d876 HttpUrlConnection reverts Content-Length=0 on POST unless doOutput is set to true 2013-03-24 20:58:29 -07:00
Adrian Cole 254aafb157 Merge pull request #1449 from zack-shoylev/windows-fix
Fixes running maven tests on windows.
2013-03-22 15:18:26 -07:00
zack-shoylev b19b4d701a Fixes running maven tests on windows. The tests and the private key
builder code were not all properly using
System.getProperty("line.separator") and were instead in some cases just
using "\n"

lineSeparator variable shortened
jclouds formatting applied

reverts and refixes formatting changes

This should fix some missing changes
2013-03-22 21:15:56 +00:00
Dies Koper 7a5cc9e2af add PROPERTY_PROXY_FOR_SOCKETS constant to allow ssh connections to bypass HTTP proxies 2013-03-19 18:16:05 +11:00
Andrew Gaul 9132c7880c Upgrade to Guava 14.0.1
Release notes:
https://code.google.com/p/guava-libraries/wiki/Release14
2013-03-15 21:20:23 -07:00
adriancole 6f9794dedb correct order of List<Byte> gson registration and filled missing test 2013-03-14 09:44:28 -07:00
Andrew Gaul 371db8d18f Address Xlint warnings 2013-03-13 22:23:19 -07:00
Adrian Cole 168121f9b3 Merge pull request #1422 from maginatics/filebackedoutputstream-reset
Call FileBackedOutputStream.reset on InputStream.close
2013-03-13 18:21:22 -07:00
adriancole ef2718629f make it possible to deserialize into ctors that have immutable collection parameters 2013-03-13 12:22:41 -07:00
adriancole 8932e9fd81 pass absent instead of null to ctor parameters of type Optional 2013-03-13 11:07:17 -07:00
Andrew Gaul 2d44332559 Call FileBackedOutputStream.reset on InputStream.close
This ensures that we delete temporary files created by Wire logging.
2013-03-13 10:43:41 -07:00
adriancole 92bfb8224f fix issue #1409: regression where we broke streaming payloads 2013-03-12 11:35:31 -07:00
Adrian Cole d3bb6d6e69 Merge pull request #1406 from maginatics/null-http-response
Annotate possibly null return value
2013-03-11 15:47:24 -07:00
Adrian Cole e1b3ded0d0 Merge pull request #1408 from maginatics/null-payload
Annotate possibly null return value
2013-03-11 15:46:23 -07:00
Andrew Gaul 395116ebf1 Annotate possibly null return value 2013-03-10 15:59:19 -07:00
Andrew Gaul 5a69e01cfd Annotate possibly null return value 2013-03-10 15:43:49 -07:00
Adrian Cole fb69ae0fa9 bump master to 1.7.0-SNAPSHOT 2013-03-08 23:02:40 -08:00
Everett Toews 5ad9867e27 Initial commit for the Rackspace DNS API. 2013-03-06 16:02:39 -06:00
Everett Toews bbede1bd0a Updated Javadoc for PagedIterable. Removed example that was out-of-date. Changed example to something that actually returns PagedIterable. 2013-03-06 11:51:41 -06:00
adriancole c31145e42e [maven-release-plugin] prepare for next development iteration 2013-03-04 06:13:59 -08:00
adriancole 0eb3ee8091 [maven-release-plugin] prepare release jclouds-1.6.0-alpha.4 2013-03-04 06:13:57 -08:00
adriancole 4f2c64681a do not send payload when method doesn't send payload 2013-03-03 17:22:23 -08:00
Adrian Cole 8e881bd5c2 remove default add of Expect 100 Continue header 2013-03-03 12:24:28 -08:00
Andrew Gaul ac60647057 Upgrade to Guava 14.0
Release notes:
https://code.google.com/p/guava-libraries/wiki/Release14
2013-02-26 10:07:53 -08:00
Adrian Cole d9c4cf2d39 consider @FormParam on @Delegate calls 2013-02-24 23:14:13 -08:00
Adrian Cole 1338daec50 added function to grab first arg during pagination 2013-02-24 12:34:00 -08:00
Adrian Cole 86d5d69128 Merge pull request #1344 from maginatics/findbugs
Address FindBugs complaints
2013-02-22 12:19:09 -08:00
Andrew Gaul ec4cdfda05 Address FindBugs complaints 2013-02-22 09:29:22 -08:00
Andrew Gaul 2b7d2ded4d Upgrade to Guava 14.0-rc3 2013-02-21 18:25:27 -08:00
adriancole ebf96596c5 @Delegate considers @PayloadParam 2013-02-21 11:44:03 -08:00
adriancole 67d74528db RedirectionRetryHandler ignored PROPERTY_MAX_REDIRECTS on backoff 2013-02-19 01:39:11 -08:00
adriancole 89fda8ee28 [maven-release-plugin] prepare for next development iteration 2013-02-04 17:30:46 -08:00
adriancole 2b0ad28f26 [maven-release-plugin] prepare release jclouds-1.6.0-alpha.2 2013-02-04 17:30:44 -08:00
adriancole 6c658f6450 fix issue #1297 put with zero length payload 2013-02-04 10:32:03 -08:00
adriancole 267069755e [maven-release-plugin] prepare for next development iteration 2013-02-02 08:41:53 -08:00
adriancole 7c924b312f [maven-release-plugin] prepare release jclouds-1.6.0-alpha.1 2013-02-02 08:41:51 -08:00
adriancole 865005afd9 fix issue #1289 bug in zero length put 2013-02-01 15:09:31 -08:00
adriancole ece2c962a0 worked around issue where GET can become POST 2013-01-31 17:43:49 -08:00
Adrian Cole 6a80aa4313 unwrap UncheckedExecutionException 2013-01-31 11:55:36 -08:00
adriancole fd3a5a3b9a decoupled InvokeHttpMethod, which allows circular dependencies in cloudstack to resolve 2013-01-30 12:51:17 -08:00
Adrian Cole 55a10d4c5d allow SelectJson to specify multiple field names, in case the server renamed something 2013-01-30 09:03:50 -08:00
adriancole 878313582a issue #1089 synchronous commands no longer spawn threads unless a timeout is specified 2013-01-29 04:08:42 -08:00
Dies Koper 17451c3e49 Core, compute: improved poll retry timeout comments 2013-01-28 16:15:47 +11:00
Andrew Phillips 2a1fc363e0 Moving the complex test for 93e2f24c62 into a separate file and allowing it to run in parallel with other tests 2013-01-24 23:13:14 -05:00
Andrew Phillips 4c5cef1be4 Updated implementation comment in Reflection2 2013-01-24 21:41:09 -05:00
Andrew Gaul fb93f774aa Remove unneeded Predicate
Inspired by:
https://code.google.com/p/guava-libraries/wiki/FunctionalExplained#Caveats
2013-01-24 16:55:01 -08:00
Adrian Cole 92c64bc856 Merge pull request #1230 from jclouds/use-system-line-sep-in-tests
Making core tests run on Windows
2013-01-24 08:20:19 -08:00
Andrew Phillips 66bab1342c Using checkArgument instead of throwing an IllegalArgException directly 2013-01-24 02:00:32 -05:00
Andrew Phillips 93e2f24c62 Ignoring synthetic methods to always return the nearest method with the most specific return type from Reflection2.method 2013-01-24 01:59:01 -05:00
Adrian Cole cafd3f9b08 Merge pull request #1232 from dkoper/master
makes fgcp live tests (at least most of them) pass again, and added @Named annotation on async api methods
2013-01-23 10:20:18 -08:00
Dies Koper 494adcaeda Fgcp: changed broken base64 logic and added unit tests 2013-01-23 18:29:40 +11:00
Andrew Phillips 5914436ae0 Making test assertions use the system line separator rather than always '\n' 2013-01-22 21:37:35 -05:00
adriancole 2aea1355a1 added ability to set field exclusion policies for json serialization 2013-01-22 17:12:08 -08:00
Andrew Gaul af963df92d Use Map.entrySet where possible
Improves run-time efficiency and addresses FindBugs warnings.
2013-01-21 23:59:42 -08:00
adriancole 847561ee00 ensure identity/credential properties are not needed when using credential supplier 2013-01-21 10:02:46 -08:00
Adrian Cole d5f7f8b07e refactored json internals to use Reflections2 2013-01-20 23:13:22 -08:00
Adrian Cole a625127fd2 added ability to look up constructors as Invokables 2013-01-20 23:13:22 -08:00
Everett Toews 242d3e07be The Connection API for Rackspace Cloud Load Balancers. 2013-01-20 19:51:06 -06:00
Andrew Gaul 70af02d9d9 Space optimize Strings2.toStringAndClose
Avoid creating a byte array before creating a String.  This reduces
peak memory usage when parsing large JSON responses such as listing a
container.
2013-01-19 22:57:01 -08:00
Adrian Cole 58a986997b removed all compile warnings in core except json package 2013-01-19 20:39:47 -08:00
Adrian Cole c5e3b24d3e decoupled ProxyConfig and introduced PROPERTY_PROXY_TYPE 2013-01-19 20:06:18 -08:00
Adrian Cole e27d9e94fe fix issue #1205: removed copied in tests from Suppliers.memoize as current code is no longer a derivative of that 2013-01-19 19:49:00 -08:00
Adrian Cole 58f0f577d0 centralize construction of invokables 2013-01-19 17:17:06 -08:00
Adrian Cole 4980367991 centralize TypeToken creation 2013-01-19 11:31:55 -08:00
adriancole dc4ca1efbd removed deprecated methods which were easy to do 2013-01-19 08:32:45 -08:00
adriancole 04fe89b75a update to guava 14.0-rc2 2013-01-18 16:02:25 -08:00
adriancole b3901deeb9 rewrote aws config to use standard op names 2013-01-16 10:54:17 -08:00
adriancole 95b1849199 process timeouts based on @Named annotations 2013-01-16 10:54:00 -08:00
Adrian Cole a7e4564c8e support changing credentials at runtime 2013-01-15 22:26:24 -08:00
Adrian Cole b07984435f unwound a few stack traces by making DelegatesToInvocationFunction an invocation handler directly 2013-01-13 22:41:06 -08:00
Adrian Cole f18d3b433f Merge pull request #1177 from jclouds/retryablepredicate-highlander
There can be only one retryable predicate; use Predicates2.retry
2013-01-13 22:07:42 -08:00
Adrian Cole 3ac6f475e7 unwound dependencies relating to ssh keys and crypt 2013-01-13 20:53:59 -08:00
Adrian Cole a49a060152 There can be only one retryable predicate; use Predicates2.retry decorator 2013-01-13 20:30:34 -08:00
Adrian Cole 6a8ac673aa fixed hanging test 2013-01-13 20:27:44 -08:00
Adrian Cole 713a498c22 removed custom version of guava Futures, awkward DescribedFuture, and migrated to native ListenableFuture 2013-01-13 09:29:24 -08:00
Adrian Cole 547f574eea got rid of custom MoreExecutors.sameThreadExecutor 2013-01-12 15:47:58 -08:00
Adrian Cole f1819fe8b9 decorating cacheloader only used in s3 2013-01-12 15:47:51 -08:00
Adrian Cole 45bb35971e replaced usage of checkNotEmpty with checkNotNull(emptyToNull 2013-01-12 15:20:11 -08:00
Adrian Cole 0e4c10e29f PasswordGenerator only used in scriptbuilder 2013-01-12 14:09:58 -08:00
Adrian Cole 015fbf22a2 removed redundant retrying assertion code 2013-01-12 14:04:47 -08:00
Adrian Cole cca73d8a69 removed function only used once and only accessing a single if branch 2013-01-12 13:47:07 -08:00
Adrian Cole 60ab6d8e26 Merge pull request #1169 from jclouds/ucdetector
cleaned up code references detected as unnecessary by UEC plugin
2013-01-12 13:11:47 -08:00
Adrian Cole d57197c103 cleaned up code references detected as unnecessary by UEC plugin 2013-01-12 12:31:00 -08:00
Adrian Cole 2f5e38d237 equals doesn't check null 2013-01-12 08:01:31 -08:00
Adrian Cole 21f6431f50 masked field 2013-01-12 07:55:49 -08:00
Adrian Cole a7389ac9eb equals on different types 2013-01-12 07:49:01 -08:00
Adrian Cole 202b9be5e5 refactored tests and internal code due to removing custom guava code 2013-01-08 22:23:47 -08:00
Adrian Cole d38ae1420d Updated invokable to include enclosing type and started refactoring SyncProxy 2013-01-08 00:32:17 -08:00
Adrian Cole 3089111621 refactored internal code and tests to use FunctionalReflection 2013-01-07 00:36:31 -08:00
Adrian Cole bd9e998b12 introduced functional model for dynamic proxies 2013-01-07 00:36:18 -08:00
Adrian Cole 69c7cd74df migrated from j.l.r.Method -> Invokable 2013-01-05 18:51:03 -08:00
Adrian Cole c43aac2ecc made AbstractInvocationHandler that uses safer objects 2013-01-05 18:48:22 -08:00
Adrian Cole afc070ac07 First wave of RestAnnotationParser refactoring introduces Invokable, removes SeedAnnotationCache and associated race conditions 2013-01-04 13:51:46 -08:00
Adrian Cole 36123a6068 deterministic creation of requests based on arg order 2013-01-04 12:44:26 -08:00
Ignasi Barrera f1d81eaf12 Make JAXBResponseParser parameterizable
By default, RestAnnotationProcessor builds the JAXBParser with the
return type of the invoked method. This, however, can make it impossible
to combine the JAXBResponseParser with the Transform annotation. The
payload of the response to be parsed with the JAXBResponseParser could
be of a different type than the output generated by the transformer
function.

This makes it necessary to configure the type for the response parser in
the JAXBResponseParser annotation and set the return type of the invoked
method to the type generated by the transformer function.
2013-01-03 23:06:03 +01:00
Adrian Cole c948c0cf53 Update core/src/main/java/org/jclouds/crypto/Pems.java
removed unused method
2013-01-01 20:35:52 -08:00
Adrian Cole 3c5135dbe5 Update core/src/main/java/org/jclouds/crypto/ASN1Codec.java 2013-01-01 20:33:18 -08:00
Adrian Cole 42c7037a59 removed unused code or duplicated code; moved code only used once to where its used 2013-01-01 00:08:34 -08:00
Adrian Cole e1afa8c516 transitioned from FindResourceInSet to FluentIterable 2012-12-31 22:11:34 -08:00
Adrian Cole d9164ddcbd Merge pull request #1129 from jclouds/no-transformingset
removed TransformingSetSupplier as it is replaced with FluentIterable
2012-12-31 22:06:18 -08:00
Adrian Cole 955b3a3f85 Merge pull request #1128 from jclouds/osgi-cleanup
osgi code formatting and cleanup
2012-12-31 21:14:24 -08:00
Adrian Cole b19e4a7a0f removed TransformingSetSupplier as it is replaced with FluentIterable 2012-12-31 20:46:04 -08:00
Adrian Cole a30ff81c15 osgi code formatting and cleanup 2012-12-31 20:07:19 -08:00
Adrian Cole 9745e9dc2f fixed covariance and warnings on ApiMetadata subclasses 2012-12-31 19:40:49 -08:00
Adrian Cole c39503b682 TimeoutException is controllable via upping timeout properties; don't add more retry loops and stacktraces 2012-12-31 17:09:27 -08:00
Adrian Cole f5743a7f41 removed code redudant to guava FutureFallback 2012-12-31 16:08:09 -08:00
Adrian Cole bb953c981e fix issue #1101: Move to Guava 14 BaseEncoding and Hashing 2012-12-31 14:48:31 -08:00
Adrian Cole cddd35bc51 removed unnecessary generic types and made RestAnnotationProcessor immutable 2012-12-30 23:18:59 -08:00
Adrian Cole 2523ab54ac removed use of static fields to share type mapping info 2012-12-30 17:22:03 -08:00
Adrian Cole 038e550d2d moved off deprecated FluentIterable methods 2012-12-30 13:20:09 -08:00
Adrian Cole 13d8b9c402 replaced @Timeout w/explicit properties 2012-12-30 12:31:43 -08:00
Adrian Cole 7dcc27a63d missing file from last commit 2012-12-29 00:02:06 -08:00
Adrian Cole 023b549e20 Remove explicit dependency on bouncycastle for PEM parsing 2012-12-28 23:11:42 -08:00
Adrian Cole 207b3db41f remove dependency on bcpkix-jdk15on 2012-12-27 23:23:28 -08:00
Adrian Cole 9b1872c6ff removed custom code that duplicates functionality of guava fallbacks 2012-12-27 16:54:31 -08:00
Adrian Cole 20c3426fc8 replaced jersey w/Uris & UriTemplates; removed complexity in url encoding and edge cases like matrix params 2012-12-24 14:32:59 -08:00
Adrian Cole e484d7033f Merge pull request #1091 from jclouds/no-aop
removed unused aop dep
2012-12-23 09:28:55 -08:00
Adrian Cole 847b1c7352 Merge pull request #1090 from jclouds/no-matrix
removed explicit matrix param support as their use is edge case in rest
2012-12-23 09:28:45 -08:00
Adrian Cole a816f09dc7 removed unused aop dep 2012-12-22 23:30:55 -08:00
Adrian Cole 3be1089538 removed explicit matrix param support as their use is edge case in rest 2012-12-22 17:45:31 -08:00
Adrian Cole e5e26e223d update to latest version of bouncycastle including moving off deprecated stuff 2012-12-20 12:04:32 -08:00
Everett Toews ad6c257424 Added support for Iterable collections to QueryParam. 2012-12-20 10:48:48 -06:00
Adrian Cole f071128f5a Merge pull request #1060 from rackspace/clb-modernize
Modernizing the Rackspace Cloud Load Balancers API.
2012-12-10 16:47:47 -08:00
Adrian Cole 2edc0ef19d Merge pull request #1056 from jclouds/jclouds-549-retry-after
introduce RetryAfterException + make Nova use it
2012-12-10 16:24:26 -08:00
Everett Toews 0b0373c91f Modernizing the Rackspace Cloud Load Balancers API. Following naming conventions and using PagedIterable. 2012-12-10 12:15:38 -06:00
Adrian Cole b4fd69287f Merge pull request #1059 from jclouds/delegate-with-paths
Delegate with paths
2012-12-09 12:19:36 -08:00
Adrian Cole 00560b3224 Path annotation ignored when endpoint not set on caller 2012-12-09 11:34:30 -08:00
Adrian Cole 99d778c1ca cleaned up unnecessary wrapping of ExecutionException 2012-12-09 11:34:25 -08:00
Ignasi Barrera 89f2f133d4 Remove net.oauth dependency 2012-12-09 19:12:59 +01:00
Adrian Cole 24f8e665d4 added RetryAfterException and placed in default exception handling 2012-12-09 03:00:45 -08:00
Adrian Cole b8eb49f0a9 added rfc822 + iso8601Seconds to DateCodecFactory and simplified ctor 2012-12-09 02:47:09 -08:00
Ignasi Barrera 72deb93570 Fixed decoding of some PKCS1 encoded public keys 2012-12-08 21:49:15 -08:00
Ioannis Canellos b7863ae394 fix issue #1044: Added listener interfaces for Providers and Apis. 2012-12-08 16:55:22 -08:00
Adrian Cole 27dfdd571b fix issue #607: NPE in compareTo method of ResourceMetadataImpl 2012-12-04 22:42:47 -08:00
Adrian Cole 6563ba1ad9 Merge pull request #995 from LeanderBB/openstack-nova-diagnostics
Started work on adding the nova diagnostics command to JClouds
2012-12-04 07:47:31 -08:00
Adrian Cole c30fedec20 updated to employ Reflection.newProxy + AbstractInvocationHandler 2012-12-02 12:27:57 -08:00
Adrian Cole 1001021ecd switched setup annotation to operate on Class to avoid InterruptedExceptions; accomodated OpenJDK behavior change wrt Expect: 100-continue 2012-12-01 18:40:07 -08:00
Adrian Cole ac8be50461 Merge pull request #1017 from jclouds/cleanup-basehttptest
clean up style on base http test class
2012-12-01 15:14:55 -08:00
Adrian Cole 1a0e0e3594 cleaned up clutter in base http tests and converted known failures to skip exceptions 2012-12-01 14:01:18 -08:00
Adrian Cole 6a20e00102 changed to use FlexBase64 from Jason Greene 2012-12-01 10:19:15 -08:00
Leander Bessa Beernaert 38be08eb6b Extends JClouds' OpenStack Nova API with the Diagnostics command
The diagnostics command returns a collection of system information
for the a given server. At the moment, there is no formal
specification for this command. Therefore, it is returned as
a Map of hypervisor specific entries and corresponding values.
More information about the command can be viewed here [1]
in the section "Server Diagnostics".

[1] http://api.openstack.org/api-ref.html
2012-11-30 17:40:12 +00:00
Adrian Cole 1b1bb39deb ensure UTC can be used where GMT is 2012-11-27 11:22:28 -08:00
Adrian Cole 9f95ff1476 Merge pull request #996 from jclouds/undo-serializable
undid Serializable and added checkstyle
2012-11-19 17:45:04 -08:00
Guy Korland 0c38cd584a Avoid NPE in case value is null but contains return true. 2012-11-19 17:35:41 +02:00
Guy Korland 405ca5648a Add missing argumnet in Exception 2012-11-19 17:13:49 +02:00
Adrian Cole 878ec1bcab undid Serializable and added checkstyle InterfaceIsType:allowMarkerInterfaces=false 2012-11-18 09:23:44 -08:00
Andrew Gaul b9e4543cdb Enforce no use of star imports via Checkstyle 2012-11-13 20:51:59 -08:00
Andrew Gaul b16ca139a4 Honor PROPERTY_REQUEST_TIMEOUT in clearContainer 2012-11-13 13:27:18 -08:00
Adrian Cole 0b0d240b4e Merge pull request #981 from jclouds/since-api-version
added ability to test if an api is available based on apiVersion
2012-11-12 17:04:09 -08:00
Andrew Gaul d7380114a6 Enforce use of Atomics.newReference via Checkstyle
Avoids duplicating types.
2012-11-12 11:56:48 -08:00
Adrian Cole 2dc9533e0b added ability to test if an api is available based on apiVersion 2012-11-11 11:07:03 -08:00
Andrew Gaul 3ad36d25d5 Enforce no unnecessary parentheses via Checkstyle 2012-11-10 13:22:12 -08:00
Andrew Gaul cca02ae02d Improve use of Splitter.omitEmptyStrings 2012-11-07 22:30:52 -08:00
Adrian Cole 6352cbccfd Merge pull request #967 from jclouds/better-factory-javadoc
improved javadoc including where to look for alternative syntax
2012-11-07 07:43:44 -08:00
Adrian Cole c7c27e12e2 improved javadoc including where to look for alternative syntax 2012-11-07 12:02:52 -03:00
Adrian Cole 489783d5c3 renamed syntax of base64 url-safe to be consistent with guava 14 + fixed bad import from prior PR 2012-11-07 10:43:56 -03:00
Adrian Cole 64a8fd0cbb Merge pull request #961 from andrewgaul/checkstyle-collection-helpers
Enforce use of Collection helpers via Checkstyle
2012-11-05 11:38:49 -08:00
Andrew Gaul 3d191253ec Enforce use of Collection helpers via Checkstyle
This ensures that we do not repeat the type name.  Some instances remain
due to auto-generated code in dmtf/cim/Cim*.
2012-11-04 20:45:49 -08:00
Andrew Gaul 9d643b569a Enforce a single variable declaration per line 2012-11-04 17:37:16 -08:00
Adrian Cole c00ef4c941 Merge pull request #956 from andrewgaul/checkstyle-illegal-throws
Enforce no illegal throws via Checkstyle
2012-11-04 17:14:14 -08:00
Andrew Gaul 41154d552c Enforce no illegal throws via Checkstyle
Also remove a stray unused import.
2012-11-04 15:48:44 -08:00
Adrian Cole 2c900d1bab Issue 1120: support base64 encode/decode for url applications 2012-11-04 15:38:13 -08:00
Andrew Gaul 0761874578 Prefer Assert.fail over assert
The former cannot be disabled.
2012-11-03 14:51:52 -07:00
Andrew Gaul 08b9982384 Enforce modifier order via Checkstyle
Also fix violations, via:

find -name \*.java | xargs sed -i 's/final static/static final/'
find -name \*.java | xargs sed -i 's/static private/private static/'
find -name \*.java | xargs sed -i 's/static abstract/abstract static/'
2012-11-01 20:01:30 -07:00
Andrew Gaul 88d53b8792 Enforce no empty statements via Checkstyle 2012-11-01 18:59:18 -07:00
Andrew Gaul 35ce78f15a Correct typos 2012-11-01 13:25:44 -07:00
Adrian Cole 4c72c5c803 Merge pull request #927 from iocanel/jclouds-osgi-fixes
Jclouds osgi fixes
2012-11-01 13:12:01 -07:00
Ioannis Canellos f76b67ac33 Specified a wider version range for rocoto. 2012-10-31 11:10:57 +02:00
Ioannis Canellos f49cca46f0 MetadataBundleListener now works with multiple providers/apis per bundle. Added a class assignable check in MetadataBundleListener. Added unit test for MetadataBundleListener. Fixed spelling and formatting of MetadataBundleListener and MetadataBundleListenerTest. 2012-10-31 11:10:20 +02:00
Adrian Cole 5da5161485 Merge pull request #909 from andrewgaul/clear-container-timeout-exception
Throw TimeoutException from awaitCompletion
2012-10-30 08:57:20 -07:00
Andrew Gaul 93d69ece2b Enforce newline at end of file via Checkstyle
Also address all warnings, via:

find -name \*.java | while read i; do if [ x`tail -c 1 $i` != x"" ]; then echo >> $i; fi; done
2012-10-29 22:12:44 -07:00
Andrew Gaul 709ca69a2d Enforce that all imports are used via Checkstyle
Also remove all unused imports, via:

mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | awk -v FS=: '/warning/{print "sed -i " $2 "d " $1}' | while read i; do $i; done
2012-10-29 17:11:08 -07:00
Adrian Cole 3a2905ee1e Merge pull request #926 from andrewgaul/to-string-and-close-exception-handling
Propagate exceptions from toStringAndClose
2012-10-29 16:50:37 -07:00
Adrian Cole 3a00a2c389 Merge pull request #924 from andrewgaul/copyright-notice
Address minor copyright notice typos
2012-10-29 16:50:01 -07:00
Andrew Gaul aad4d4dbcf Propagate exceptions from toStringAndClose
This method already declares throws IOException and callers should
handle these errors appropriately.
2012-10-29 09:37:46 -07:00
Aled Sage 09425f4f69 Version upgrades
- gson from 2.2 to 2.2.2
- guava from 13.0 to 13.0.1
- rocoto from 6.1 to 6.2
- log4j from 1.2.16 to 1.2.17
- log back from 1.0.0 to 1.0.7
- httpclient from 4.1.3 to 4.2.2
- netty from 3.3.1 to 3.5.9
- slf4j from 1.6.4 to 1.7.2
- testing from various to 6.8
- jetty from 8.1.1 to 8.1.7
- snakeyaml from 1.10 to 1.11
2012-10-29 13:00:44 +00:00
Andrew Gaul e7dde3aff5 Address minor copyright notice typos 2012-10-28 23:27:56 -07:00
Andrew Gaul 336ccfa2e6 Throw TimeoutException from awaitCompletion
This is a common error that callers should interpret correctly.  For
DeleteAllKeysInList, we integrate into its retry and backoff logic,
and for other callers, we continue to propagate RuntimeException.
2012-10-25 13:50:29 -07:00
Andrew Gaul 28d7a6f143 Prefer immutable over empty collections
The former does not create an object when calling iterator(), as
discussed here:

https://groups.google.com/d/msg/jclouds-dev/l7BviKDXreA/mP6Ow_RYxIgJ
2012-10-20 15:35:29 -07:00
Andrew Gaul 90f42d01ce Remove InputSuppliers.of(byte[])
Callers rarely want this functionality and should call
ByteStreams.newInputStreamSupplier when they do.
2012-10-17 11:35:45 -07:00
Adrian Cole ffa9cd3bb0 corrected guice bindings for swift-based blob signatures and backfilled expect tests 2012-10-10 12:03:23 +02:00
Andrew Gaul 9024c77405 Improve use of Charsets 2012-10-07 22:31:49 -07:00
Adrian Cole 5b213c2171 Merge pull request #883 from andrewgaul/unsupported-encoding-exception
Remove unneeded UnsupportedEncodingExceptions
2012-10-07 18:04:31 -07:00
Adrian Cole 298e764f85 fixed context builder when params in properties 2012-10-07 17:50:59 -07:00
Andrew Gaul 07ca6ab27b Remove unneeded UnsupportedEncodingExceptions
Enabled by use of Charsets.  Remaining calls due to URLEncoder.encode
and decode.
2012-10-07 17:16:02 -07:00
Andrew Gaul 8a0900d6ca Prefer fail over assertTrue(false) where possible 2012-10-06 19:25:54 -07:00