8fa209b15e
Use more specific testng asserts where possible
...
These asserts yield more informative error messages. Found with:
grep -rI 'assertTrue(.* =='
grep -rI 'assertTrue(.* !='
grep -rI 'assertTrue(.*\.equals('
2014-06-24 13:54:01 -07:00
309c053c77
JCLOUDS-584: HP Cloud Object Storage Fixes for 13.5
2014-06-24 12:01:51 -07:00
e799a7409c
JCLOUDS-597: HashCode methods for Content-MD5
...
This works more naturally with Guava Hashing methods and immutability
provides better safety guarantees. Also deprecate existing byte[]
methods.
2014-06-12 15:29:17 -07:00
9cdd53b0b7
JCLOUDS-546: Remove Javadoc @author annotations
...
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
2014-06-07 21:44:54 -07:00
da8517f295
Increase timeouts for signed URL tests
...
Clock skew between the client and blobstore can cause these tests to
spuriously fail. This commit allows 5 seconds skew in either
direction.
2014-05-30 14:58:40 -07:00
2342abd3c5
Address Checkstyle violations
2014-05-30 11:10:14 -07:00
186f052022
Remove BlobBuilder and Payloads.calculateMD5
...
Callers should instead explicitly set contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers. Further it removes a dangerous
rebuffering of arbitrarily-large non-repeatable Payloads.
2014-05-28 12:54:18 -07:00
c6d4e6645c
JCLOUDS-402: Allow Guava MediaType Content-Type
...
This promotes type-safety. Keep the String interface for unknown
content types.
2014-05-28 11:45:00 -07:00
70cf3e1f7c
Make constants final classes instead of interfaces
...
This commit prohibits implementation of the empty interface and
instantiation of the class. Refer to _Effective Java_ item 19 for
more background.
2014-05-16 09:45:52 -07:00
8d51ad6f87
Prefer Guava HttpHeaders over JAX-RS
...
jclouds code contains more instances of the former and Guava has
additional constants like CONTENT_MD5.
2014-05-15 01:55:51 -07:00
7f28dcef07
Remove deprecation from getConsistencyModel
...
This method informs callers of the expected blobstore behavior,
avoiding unnecessary work for providers which support strict
consistency (Azure, mock blobstores).
2014-05-09 13:20:42 -07:00
2d88f5164e
Enforce that all commas have trailing whitespace
2014-05-08 18:28:08 -07:00
a45124c51a
JCLOUDS-505: Remove unused ObjectMD5
...
The only users of this seem to be
org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and
org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which
are themselves unused.
2014-05-07 10:16:18 +02:00
c6cb169dee
Creating a separate function to delete directories
...
Small refactoring to reuse some code.
2014-04-22 11:22:13 +02:00
d0bd30cc15
Address several Guava InputSupplier deprecations
...
Many remain due to Payload implementing InputSupplier<InputStream>. Guava 18
will remove InputSupplier.
2014-04-12 12:02:26 -07:00
655aa444d7
JCLOUDS-510 Delete objects in a container efficiently.
...
The existing approach for deleting objects in a container suffers
from a head-of-line blocking problem. This commit implements a better
scheme which does not have that problem. This scheme uses a counting
semaphore for making sure that a certain number of futures are
issued in parallel. As each of these futures is completed, one
permit of the semaphore is released.
Added unit tests for testing this new scheme.
2014-03-26 13:48:28 -07:00
d7e0b3b10c
Remove WriteTo
...
Guava helpers capture this functionality in a more idiomatic way.
2014-02-21 17:13:31 -08:00
9a1aae8cfc
JCLOUDS-410: Remove StreamingPayload
...
Only two tests use this class. Callers should use ByteSourcePayload
or InputStreamPayload instead.
2014-02-19 21:27:31 -08:00
f5c9a72243
Add ByteSource Payload support for Clojure
2014-02-19 21:09:55 -08:00
266d7f847b
Prefer ByteSource over deprecated InputSupplier
2014-02-18 22:35:10 -08:00
9416416ff4
Address Checkstyle violations
2014-01-19 20:51:51 -08:00
c7b0f66544
Replace calls to Closeables.closeQuietly
...
Guava 16 removes this API. Replace with Closeables2.closeQuietly.
References JCLOUDS-413 and JCLOUDS-415.
2013-12-21 12:30:59 -08:00
c1ee11d9bd
Updating to 1.8.0-SNAPSHOT
2013-12-17 11:31:56 -08:00
d25e972344
JCLOUDS-401. Make BlobName Function type-safe
2013-12-16 15:04:14 -08:00
ac06e32e72
JCLOUDS-399: Deprecate BlobBuilder.calculateMD5
...
Callers should instead call BlobBuilder.contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers.
2013-12-16 13:40:38 -08:00
e48d4985ea
JCLOUDS-410. Add support for ByteSource Payloads
...
Also deprecate byte[], File, InputSupplier<InputStream>, and String
Payloads. Callers should instead provide a ByteSource via
ByteSource.wrap(byte[]) and Files.asByteSource(File)
2013-12-16 13:06:30 -08:00
ac1f05ffac
Remove unneeded calls to ByteSources.asByteSource
2013-12-15 22:57:32 -08:00
828d8790c2
Enforce no unused imports via Checkstyle
...
Removed with:
mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
2013-12-11 17:27:43 -08:00
4cef85d1cd
Address Checkstyle violations in tests
2013-12-09 14:40:07 -08:00
6c5effcdb1
Address error-prone empty statement warnings
2013-11-05 16:22:44 -08:00
cb9a6b9413
Reduces parallelism to make test work better with slower connections Adjusts test timing to work properly and reliably
2013-10-30 10:33:15 -05:00
f196ee3b6b
Move Expect: 100 stripping after asserts against the request
...
Follow-up to e30f86521
2013-10-19 20:05:42 -07:00
e30f865215
Work around CloudFiles test failures
...
Java helpfully interprets Expect: 100-continue instead of returning
the response code. This commit reverts
100afba1d8
2013-10-17 13:08:02 -07:00
7593935380
JCLOUDS-332 Skips tests broken on windows
2013-10-08 15:07:35 -05:00
7d20658b02
JCLOUDS-334. Return URI only if container created
...
This allows us to honor the BlobStore.createContainerInLocation
interface and gives consistency with other providers.
2013-10-08 13:03:55 -07:00
f1fc63ab76
Add whitespace around keywords and braces
2013-09-30 09:39:29 -07:00
5f8961723f
Remove BlobStore Map abstractions
...
These provide little end-user benefit and make evolving the core API
more difficult. We deprecated these in 1.6.0.
2013-09-25 20:46:31 -07:00
94452a97cd
Skip unimplemented test with transient blobstore
2013-09-16 02:48:57 -07:00
6cc8e36f43
Add test for correct and incorrect contentMD5
...
Tested against atmos (skipped), aws-s3, azureblob, cloudfiles-us, and
filesystem (skipped).
2013-09-11 16:10:45 -07:00
8bdded3222
Delete containers after integration tests
...
Also return newly allocated containers to the pool.
2013-09-09 16:47:40 -07:00
0d6ef06076
Reduce testFileGetParallel input size to ~160 KB
...
Previously this test downloaded 45 MB in 30 seconds which failed on
slower connections, causing spurious test failures. The larger input
size provides no benefit.
2013-09-04 19:49:46 -07:00
3ad6b275d4
Run some filesystem integration tests
...
Previously no integration tests ran, now we see:
Tests run: 43, Failures: 0, Errors: 0, Skipped: 8
2013-09-04 13:26:46 -07:00
e27ae6117c
Reduce testPutFileParallel input size to ~160 KB
...
Previously this test uploaded ~10 MB in 30 seconds which failed on
slower connections, causing spurious test failures. The larger input
size provides no benefit.
2013-09-02 19:33:15 -07:00
607b178c6b
Simplify testPutFileParallel
...
Create only one temporary file and use explicit delete instead
finalization to remove it.
2013-08-27 23:06:18 -07:00
4ca531aa98
Allocate new container name using prefix
...
Before we used the previous container name, which kept appending and
hit S3 limits during integration tests like:
Caused by: java.lang.IllegalArgumentException: Object 'gaul-blobstore27-4348532805015069992-1155797412711190448-1465016400636204031' doesn't match S3 bucket virtual host naming convention. Reason: Can't be null or empty. Length must be 3 to 63 symbols.. For more info, please refer to http://docs.amazonwebservices.com/AmazonS3/latest/index.html?BucketRestrictions.html
2013-08-27 23:02:55 -07:00
d387a25113
Enforce a non-negative content length
2013-08-26 20:20:49 -04:00
d60d2681d1
JCLOUDS-251: Swift: Delete chunks when deleting a multipart blob
...
Also:
- Make SwiftBlobIntegrationLiveTest.testMultipartChunkedFileStream more realistic by uploading a file large enough to be split into parts.
- JavaDoc fixes for SwiftBlobStore: don't reference nonexistent methods.
2013-08-25 10:20:22 -05:00
1a6be0eb67
Do not repeat array type in initializers
2013-06-18 21:02:50 -07:00
86147cd961
Remove AsyncBlobStore from DeleteAllKeysInList
...
We deprecated AsyncBlobStore in 1.6.0. Subsequent commits will
require the caller to provide an ExecutorService.
2013-06-05 10:41:55 -07:00
64e9a4e4c6
Remove Strings2.replaceAll(String, char, String)
...
String.replace(String, String) serves this purpose better.
2013-06-03 14:41:18 -07:00
Andrew Gaul
Chris Custine
Shri Javadekar
Andrew Bayer
Zack Shoylev
Andrew Phillips
Francis Devereux